Commit graph

4 commits

Author SHA1 Message Date
Eberhard Beilharz
1aac4e3170
docs(common): update documentation comments
Addresses code review comment.

Build-bot: skip
Test-bot: skip
2026-01-14 11:03:09 +01:00
Eberhard Beilharz
3a7663f7c1
fix(common): properly use newly installed node version
Previously, if we had to install a new node version, we activated it in
the same subshell as the installation. This had the effect that `NVM_BIN`
was set to the new version only in the subshell, but otherwise it still
had the wrong value. This caused build failures. Subsequent builds would
succeed because the node version was now available.

This change fixes things by using an explicit `if` instead of the
construct with parens which opened another subshell.

Fixes: #14056
Test-bot: skip
2025-05-27 17:07:23 +02:00
Eberhard Beilharz
ddb6631d2a
chore(common): improve offline builds
`nvm install` will fail if trying to build while offline. This
change tries to use the required node version first and if that
fails installs and then uses it.
2024-11-28 11:45:26 +01:00
Marc Durdin
fc4df037bb chore(common): use nvm to select version of node for builds
Used by default only on build agents. See docs/build/node.md and
resources/build/_builder_nvm.sh for documentation of this change.

Fixes: #11376
2024-08-01 05:09:08 +07:00