Commit graph

5430 commits

Author SHA1 Message Date
Darcy Wong
3d221381fe chore(common): Skip issue folder 2023-04-25 07:33:41 +07:00
Darcy Wong
91c9cbf61d chore(common): Skip issue folder 2023-04-25 07:18:23 +07:00
Darcy Wong
aa218d4896 chore(common): cd to $THIS_DIR 2023-04-25 07:09:28 +07:00
Darcy Wong
92670f4100 chore(common): Fix issue number 2023-04-24 15:30:41 +07:00
Darcy Wong
f216673f54 chore(common): Update path 2023-04-24 15:09:00 +07:00
Darcy Wong
23f1e79d2f chore(common): Move the_99 test keyboard to issue folder 2023-04-24 15:06:53 +07:00
Marc Durdin
f9c818f103 chore(common): update dependency paths 2023-04-24 08:51:39 +07:00
Marc Durdin
cf4022ac8a feat(developer): use CompilerEvent for messages in all of kmc
Cleans up majority of remaining kmc-* modules to use CompilerEvent
messages instead of console.log and friends, adding
InfrastructureMessages class for kmc CLI messages.

Consolidates schema loading functions into a single `loadSchema`
function in the CompilerCallbacks interface and implementations.

Moves responsibility for instantiating NodeCompilerCallbacks out of
each individual BuildActivity and into higher level modules.

Fixes return value for failing builds.
2023-04-24 07:26:43 +07:00
Ross
4019a79676 chore(windows): address review comments 2023-04-21 18:43:50 +10:00
Marc Durdin
66a7a6fc4e feat(developer): support FollowKeyboardVersion in kmc-package
Fixes #7340.

Removes the unused <Version> element from <LexicalModel> element in the
.kps schema. (This needs to be copied to api.keyman.com also.)

Updates compiler to check for <FollowKeyboardVersion> and read the
version data from the .kmx in that case.

Unit tests updated. Some of the fixtures were incorrect as they had
<FollowKeyboardVersion> set for model-type packages or packages that
contained no keyboards. Fixed.
2023-04-21 14:04:06 +07:00
Marc Durdin
8ec69471dc feat(common): kmx file reader
Read a .kmx file into memory in Typescript. Currently only reads stores
from the file, as these are the most common things needed for other
processes. Will add support for reading other metadata and rules in
future when required.
2023-04-21 11:52:18 +07:00
Marc Durdin
e0ed058e89 refactor(developer): kmc-model to use CompilerEvent
Replaces the existing error reporting in kmc-model with CompilerEvent
style messages. Some of the existing error reporting was kinda nice, but
consistency trumps pretty here.

One downside at present is the global filename and line variables in the
model-compiler-errors.ts unit. This is fragile, and should probably be
refactored further in the future.

Where it made sense, I converted various throws into ModelCompilerError
instances. If it appeared to be an internal error, I left it as-is, but
the external API interfaces wrap all unknown exceptions and convert them
into a compiler error message, so these APIs (compileModel and
loadFromFilename) now have a guarantee that they will never throw.

At this point, all of the error messages in the model compiler are
unrecoverable -- they will halt the compile entirely. However, the
pathway is there to support recoverable errors through the normal
callbacks.reportMessage mechanisms.

The message-counting mechanism is currently missing from this, as it
belongs in the API consumer, rather than in the low-level reporting
infrastructure. This means that models with large numbers of warnings
are going to generate scads of messages for now.

Note that the _users_ of CompilerCallbacks are subject to change in the
future, once we have all the compilers using the callbacks.
2023-04-20 16:40:04 +07:00
Marc Durdin
39d473fb2d refactor(developer): move comperr.h to kmn_compiler_errors.h
Consolidates the two copies of comperr.h (they were identical) and
moves to a common folder. Updates all references to comperr.h, except
for one github commit ref.
2023-04-20 13:20:29 +07:00
Joshua Horton
4588fbcb68
Merge pull request #8629 from keymanapp/fix/common/web/pred-text-test-dependency
chore(web): sets kmc-model as dependency of input-processor test action
2023-04-20 11:24:25 +07:00
Marc Durdin
cc187ce858
Merge pull request #8628 from keymanapp/feat/developer/8150-non-binary-kvk-file-warning
feat(developer): warn if .kps file includes a non-binary .kvk file
2023-04-20 13:46:11 +10:00
Marc Durdin
7d14ab4870
Merge pull request #8625 from keymanapp/feat/developer/kmc-kmn-use-new-message-infrastructure
feat(developer): use new message infrastructure in kmc-kmn
2023-04-20 13:45:01 +10:00
Joshua A. Horton
78562a0bd9 chore(web): cleanup per PR reviews 2023-04-20 10:30:49 +07:00
Marc Durdin
2f7407b4b8 feat(developer): warn if .kps file includes a non-binary .kvk file
Relates to #8150.

Legacy .kmp compiler would transform xml-format .kvk files into a binary
.kvk file; now we want that to remain the responsibility of the keyboard
compiler, so we'll warn the few users who are still doing this.
2023-04-19 15:32:29 +07:00
Joshua A. Horton
66da792319 chore(web): sets kmc-model as dependency of input-processor test action 2023-04-19 14:26:44 +07:00
Marc Durdin
66542f6323 feat(developer): use new message infrastructure in kmc-kmn
Moves to using the `reportMessage` callback for reporting all errors in
kmc-kmn.

This required some patching to common/web/types in order to get the new
constants in place and add support for line numbers to `CompilerEvent`,
so at the same time I refactored `compilerErrorSeverityName` into the
module.

After the refactor, coverage tests were failing because they included
the test/ folder, so cleaned that up at the same time.
2023-04-19 10:13:14 +07:00
Joshua A. Horton
7efcda73d7 fix(web): defines --ci for lm-worker test use 2023-04-18 10:41:52 +07:00
Joshua A. Horton
ab7c4b5e9e fix(common/models): build script fix for models/templates ci test 2023-04-18 08:26:19 +07:00
Marc Durdin
b58ac8fe4a fix(developer): package editor no longer loses RTL flag for LMs
Fixes #8595.
2023-04-18 05:40:50 +07:00
Joshua A. Horton
f37f2c868c fix(common/models): messed up an elif's syntax 2023-04-17 13:38:58 +07:00
Joshua A. Horton
30da35c5a2 fix(common): CI test-build issues for lm-layer config, other configs 2023-04-17 12:24:37 +07:00
Joshua A. Horton
89dd8d13ae fix(web): android API 21 compat issues 2023-04-17 10:25:56 +07:00
Joshua Horton
77b3b8aecd
Merge pull request #8521 from keymanapp/change/web/set-active-keyboard
change(web): modularization, refinement of setActiveKeyboard 🧩
2023-04-13 13:51:07 +07:00
Joshua A. Horton
cb73fdb05e chore(web): Merge branch 'change/web/set-active-keyboard' into fix/web/webview-android-launch 2023-04-13 13:31:07 +07:00
Joshua A. Horton
ea1be84871 chore(web): Merge branch 'feature-esmodule-web-engine' into change/web/set-active-keyboard 2023-04-13 13:29:20 +07:00
Marc Durdin
501cf03dc2 chore(common): update description for 'build.sh pack' 2023-04-12 14:18:31 +07:00
Marc Durdin
3265a714f2 chore(common): add missing deps and files for npm publish
The build/ folder for most packages was missing due to being listed in
.gitignore.

Also, @keymanapp/ldml-keyboard-constants package was not being published
despite being a dependency of @keymanapp/kmc-keyboard.

Instead of relying on npm's use of .gitignore / .npmignore (which has
seriously wonky behaviours), we list the files that should be included
in package.json.

NPM Wonky behaviours: it seems that .npmignore causes .gitignore in the
same folder to be ignored. But, higher level .gitignore files still
affect the files included in the package, which makes
specification-by-exclusion painful (negating exclusions, etc). We do not
recommend use of .npmignore anywhere for this reason.
2023-04-12 14:05:05 +07:00
Marc Durdin
10a59f789d fix(common): support npm pack and consolidate npm publishing
Fixes #8586.

All npm publish actions in the repository are now run as part of the
Developer release build, hosted at present by kmc, until we setup a
higher-level build script to do it.

Adds a 'pack' action which mirrors 'publish' for all npm packages.

Removes unnecessary dev dependencies of models-templates and
models-wordbreakers from kmc-model.

Web Release build CI step has been updated to check for presence of
.build-builder.
2023-04-12 11:55:31 +07:00
Joshua A. Horton
7eef5699b9 chore(web): Merge branch 'master' into chore/web/master-to-esmodule-merge-a17s10 2023-04-12 09:56:48 +07:00
Joshua A. Horton
6a65421813 refactor(web): reworks keyboard-load error reporting with a clearer pattern 2023-04-12 09:46:28 +07:00
Joshua A. Horton
7b7fa52a95 chore(web): renames app/webview output, preserves name within embedding apps 2023-04-12 09:00:17 +07:00
Marc Durdin
035c447a31 chore(core): move test_assert.h and test_color.h to common 2023-04-10 15:21:45 +07:00
Joshua A. Horton
549a3d183a chore(web): missed committing one change 2023-04-10 10:54:08 +07:00
Marc Durdin
c5d79a9fb4
Merge pull request #7330 from keymanapp/feature-kmcompx
epic: kmcompx - kmcmpdll cross-platform compiler 🚑
2023-04-10 07:34:04 +10:00
Joshua A. Horton
b4fee54336 chore(web): Merge branch 'change/web/set-active-keyboard' into fix/web/webview-android-launch 2023-04-07 09:57:10 +07:00
Joshua A. Horton
3c185b3182 chore(web): Merge branch 'feature-esmodule-web-engine' into change/web/set-active-keyboard 2023-04-07 09:54:37 +07:00
Joshua A. Horton
7f4debdfbf chore(web): restores feature-esmodule-web-engine to prior state
Revert "Merge pull request #8553 from keymanapp/revert-8549-chore/master-to-esmodule-merge-a17s9"

This reverts commit 518750f94e, reversing
changes made to 6df63eddc5.
2023-03-31 12:53:00 +07:00
Marc Durdin
787b32ba34
Revert "chore(web): merge master into feature-esmodule-web-engine (A17S9 end) 🧩" 2023-03-31 14:17:37 +11:00
Joshua Horton
6df63eddc5
Merge pull request #8549 from keymanapp/chore/master-to-esmodule-merge-a17s9 2023-03-31 08:51:27 +07:00
Joshua A. Horton
371f967768 fix(common/web): lm-worker --debug build fix 2023-03-30 19:03:30 +07:00
Joshua A. Horton
d5ec58c52a fix(web): lots of little connection points for actual in-app use; gets Android app functional 2023-03-29 15:31:55 +07:00
Joshua A. Horton
48610a3b43 fix(common/web): modularizes SentryManager, re-enables it 2023-03-29 09:54:24 +07:00
Joshua A. Horton
3f4fd65d07 fix(web): android debug-host page linkage 2023-03-28 14:36:58 +07:00
Joshua A. Horton
173d491d62 feat(web): initial app/webview build product 2023-03-28 12:33:04 +07:00
Joshua A. Horton
c75a4b94a3 fix(web): handling of the spacebar-text setting 2023-03-28 09:13:12 +07:00
Marc Durdin
3468a36100 chore(common): add baseline.kpj
This makes it possible to run the common/test/keyboards build.sh and
makes all the baseline keyboards available as a build artifact (but
currently only in .kmx, not .kmp; this may come as a future update.)
2023-03-28 06:50:00 +07:00