Commit graph

5430 commits

Author SHA1 Message Date
Joshua A. Horton
d74bc8f926 docs(web): doc-comment typo 2024-02-29 13:03:12 +07:00
Joshua A. Horton
495ee46938 chore(web): minor extra cleanup 2024-02-29 12:59:17 +07:00
Marc Durdin
4bb9b39ba2 refactor(developer): reorganize messages for adding details
Moved the ERROR_Message line above the Error_Message line for every
message in the compiler message files, as it makes the grouping clearer
once we start adding message details. For example, see the start of the
KmnCompilerMessages class.

Also wraps potentially-undefined parameters to the messages with a new
function `def`, shorthand for `CompilerMessageDef`, which converts the
parameter to '<param>' if it is undefined, which is helpful for
documentation.
2024-02-28 16:00:02 +07:00
Marc Durdin
c7afed7201 refactor(developer): split messages with callstacks into separate generator
Relates to #10207.

In order to include message detail in messages, it is helpful to split
out the exception messages which have a separate parameter, so that
parameter at the same position can be the message detail.

Introduces the CompilerMessageSpecWithException function which takes an
exceptionVar parameter to achieve this differentiation.
2024-02-28 11:34:49 +07:00
Steven R. Loomis
9c2a73a290 chore(common,developer): rename unicodeSet to uset in code
Fixes: rename unicodeSet to uset 🙀  #10657
2024-02-27 18:15:57 -06:00
Marc Durdin
e1a8ce47e3
Merge pull request #10821 from keymanapp/fix/developer/10396-repeated-options-in-kmc
fix(developer): repeated options in kmc must now be fully specified
2024-02-27 16:04:50 +07:00
Joshua A. Horton
b09a1ba176 change(web): concurrency lock-management ordering 2024-02-27 13:31:08 +07:00
Joshua A. Horton
fd30786ac5 feat(web): an extra unit test 2024-02-27 13:16:33 +07:00
Joshua A. Horton
b5cf14a6e0 feat(web): closure-queue unit tests 2024-02-27 13:08:53 +07:00
Joshua A. Horton
2da832816a change(web): unlockTouchpoint -> fulfillInputStart 2024-02-27 10:59:07 +07:00
Joshua A. Horton
dae1126098 change(web): better nomenclature, fixes triggerEvent 2024-02-27 10:40:02 +07:00
Joshua A. Horton
03a329ae46 docs(web): minor comment tweak 2024-02-27 10:06:17 +07:00
Joshua A. Horton
e8fb4a1441 change(web): more explicit 'cancelled'-rejection handling, documentation 2024-02-27 10:02:09 +07:00
Joshua A. Horton
3e7c8fa164 fix(web): triggerEvent should fire just one, not loop 2024-02-27 09:25:06 +07:00
Marc Durdin
70a50f0f67 refactor(developer): move osk module from common-types to developer-utils
This module is used only by Keyman Developer compiler. It was originally
in common-types because we didn't have a shared module for Developer.

Moving it to @keymanapp/developer-utils in order to improve its
documentation.
2024-02-26 14:57:27 +07:00
Joshua A. Horton
c915d1e6a2 fix(web): unit test adjustment for compat with last commit 2024-02-26 14:02:12 +07:00
Joshua A. Horton
fd97412bc4 change(web): implements a touch-event sequentialization queue 2024-02-26 14:01:52 +07:00
Joshua A. Horton
57079f3c02 chore(web): cleans condition comment 2024-02-26 12:09:43 +07:00
Joshua A. Horton
f9d5ddc809 change(web): local var name, for clarity/consistency 2024-02-26 12:03:00 +07:00
Joshua A. Horton
5e4de069c3 fix(web): proper gesture-match sequencing 2024-02-26 12:01:28 +07:00
Joshua A. Horton
028ff13b0d fix(web): infinite model-match replacement looping 2024-02-26 11:05:09 +07:00
Joshua A. Horton
bd012679c0 fix(web): early gesture-match abort when unable to extend existing gestures 2024-02-26 10:54:10 +07:00
Marc Durdin
7b198eb4a4 fix(developer): repeated options in kmc must now be fully specified
Fixes #10396.

Instead of `--message 20ae 5006`, which is ambiguous, because 5006 could
be a filename, you must now specify the parameter option flag each time:
`--message 20ae --message 5006` (or `-m 20ae -m 5006`).
2024-02-23 13:17:11 +07:00
Marc Durdin
144456821b chore(common): loosen .keyman-touch-layout schema layer id requirements
Fixes #9843.
2024-02-23 10:38:45 +07:00
Joshua A. Horton
36e7a2b51a chore(web): proper reporting of errors from es5 KMW 2024-02-22 10:20:32 +07:00
Marc Durdin
457275e46f fix(developer): ensure fatal errors report message or made non-fatal
Fixes #10678.

Some messages have been reduced to ERROR instead of FATAL, as they are
not internal compiler errors.

Where fatal messages are raised, the message will now be reported
through correctly to Sentry.
2024-02-20 11:10:39 +07:00
Marc Durdin
c956168d44
Merge pull request #10750 from keymanapp/chore/merge-master-into-windows-updates
chore: merge master into windows-updates
2024-02-17 15:32:01 +07:00
Joshua A. Horton
346556b74f fix(web): conditional import path 2024-02-16 11:57:24 +07:00
Joshua A. Horton
47d945f309 fix(web): conditional import path 2024-02-16 11:56:44 +07:00
Steven R. Loomis
7cd2e2d4e0 fix(developer): fix for incorrectly-stateful regex
- take out the /g flag for regex used with .exec

For #10734
2024-02-15 15:47:41 -06:00
Joshua A. Horton
593189b30d chore(web): Merge branch 'beta' into fix/web/transform-selection-interactions 2024-02-15 10:47:42 +07:00
Steven R. Loomis
8787073c40 feat(developer): errs on \uXXXX escapes 🙀
- note, some older test cases had to be fixed also.

For: #10389
2024-02-13 12:26:46 -06:00
Steven R. Loomis
b99a2cf2a5
Merge branch 'master' into feat/developer/10389-bad-regex-no-biscuit 2024-02-13 10:17:58 -06:00
Joshua A. Horton
0e06b7a20b docs(web): adds a bit of extra documentation re: method return value paradigm 2024-02-13 11:05:38 +07:00
Joshua Horton
c246993a0f
Merge pull request #10641 from keymanapp/fix/web/invalid-longpress-shortcut
fix(web): prevent invalid longpress shortcut triggers
2024-02-13 09:47:57 +07:00
Joshua A. Horton
0b79b86197 feat(common/models): initial pass for encoded-string wordbreaker data tables 2024-02-13 08:29:38 +07:00
Joshua A. Horton
58c7575d4b feat(web): full property data-table generation functionality; data is exact match 2024-02-13 08:29:25 +07:00
Joshua A. Horton
901861a75d feat(web): implements string-encoded prop-array search 2024-02-13 08:29:25 +07:00
Joshua A. Horton
9093c0719b change(web): preps for wordbreaker child projects 2024-02-13 08:29:24 +07:00
Steven R. Loomis
da4b544471 feat(developer): errs on unparseable regex 🙀
- also, make sure NFD-incompliant ranges get mapped to escaped chars
- also, propagate UnicodeSet errs out

For: #10389
2024-02-12 18:16:34 -06:00
rc-swag
89f6770a78 chore(windows): add const to argument definition
Updated the call stack to keep a const string for the value parameter
being written to registry.

SaveKeyboardOptionCoretoRegistry calls
IntSaveKeyboardOptionCoretoRegistry which calls
RegistryFullAccess::WriteString which calls
RegSetValueExW, which takes a const data parameter.
2024-02-09 11:11:27 +10:00
Joshua A. Horton
444aeec509 chore(web): unit test patchup after method rename 2024-02-08 15:40:39 +07:00
Joshua A. Horton
aefef2181d chore(web): further PR cleanup 2024-02-08 13:12:26 +07:00
Joshua A. Horton
f36aba7bad chore(web): explicit edge case condition 2024-02-08 11:52:13 +07:00
Joshua A. Horton
c32691c2e7 feat(web): extra edge-case unit tests 2024-02-08 08:19:40 +07:00
Joshua A. Horton
0f0784a0e7 change(web): simpler return value 2024-02-07 16:24:42 +07:00
Joshua A. Horton
1222b2b3e2 chore(web): minor simplification 2024-02-07 16:04:42 +07:00
Joshua A. Horton
b1adb857b3 fix(web): forgot to delete a ref to deleted name 2024-02-07 15:41:56 +07:00
Joshua A. Horton
e3da931606 change(web): clearer maxInterval handling 2024-02-07 15:40:36 +07:00
Joshua A. Horton
a903bb91e7 chore(web): some more cleanup + docs 2024-02-07 15:36:21 +07:00