Regression introduced in #7661 (17.0 alpha), #7825 (16.0 beta).
When shutting down CEF cleanly, we needed to pause the form destruction
sequence in order for CEF to complete its shutdown tasks. However, for
a dialog form, it will commonly be closed by setting `ModalResult` to a
non-zero value. In our fix, we inadvertently lost any `ModalResult`
value by calling `Close` after CEF was finished, which sets
`ModalResult` to `mrCancel` (value of 2).
This fix caches the `ModalResult` value, and if non-zero, uses it
instead after CEF shuts down, to achieve the same result.
Regression introduced in #7661 (17.0 alpha), #7825 (16.0 beta).
When shutting down CEF cleanly, we needed to pause the form destruction
sequence in order for CEF to complete its shutdown tasks. However, for
a dialog form, it will commonly be closed by setting `ModalResult` to a
non-zero value. In our fix, we inadvertently lost any `ModalResult`
value by calling `Close` after CEF was finished, which sets
`ModalResult` to `mrCancel` (value of 2).
This fix caches the `ModalResult` value, and if non-zero, uses it
instead after CEF shuts down, to achieve the same result.
Try to get this to pass tests again
test data:
- put withfolders.qaa.sencoten.model in the right spot
- add kmp.json as it seems to be included
- remove copyLocation: 0 as kmp-compiler drops it
test-package-compiler:
- improve the jszip-contents test
- assume kmp.json is included in the zip
- bug: withfolders.qaa.sencoten.model.js and example.qaa.sencoten.model.js show up in an unrelated KPS. But, include for now.
KmpCompiler
- attempt to pull version from kps.info.version: comments to the contrary, some kps files do not have kmxes.
- map backslash to forward slash so that relative path resolution works
For #7042
Fixes#7926.
Android 5.0 (Chrome 37) only supports ES3. Thus, we should transpile our
lexical models to ES3 rather than ES2015, for now at least.
For example, this forces constructs such as `const` to be replaced with
`var`.
This change removes the unused JENKINS environment variable
from `reconf.sh`. The code got refactored some time ago to use
the common scripts to retrieve the version. That made the JENKINS
variable obsolete.
When we added the API check we introduced a mis-spelled dependency
which lead to Keyman being uninstallable. This change fixes things.
(cherry picked from commit 29fe7dae59)
