Commit graph

3486 commits

Author SHA1 Message Date
Marc Durdin
8bef1290e0
Merge pull request #4138 from keymanapp/chore/windows/4042-remove-importkeyboard
chore(windows): remove obsolete importkeyboard app
2020-12-16 07:24:16 +11:00
Marc Durdin
439171e988 fix(windows): Online Update dialog layout was messy
Fixes #4040.

Also now prevents the spurious "no updates are available" message from
appearing when the user cancels the update dialog.
2020-12-15 15:42:06 +11:00
Marc Durdin
fefe69f882 fix(windows): exit button position on setup 2020-12-15 15:03:06 +11:00
Marc Durdin
a56ba3ce20 chore: fixup guid 2020-12-15 14:39:09 +11:00
Marc Durdin
1046a84328 chore: fix oopsie 2020-12-15 14:37:22 +11:00
Marc Durdin
82719788e5 fix(windows): Text editor font bugs
Fixes #4008.

Fixes issue of font helper popping out separately and secondary crash,
as well as the font helper not actually working because the font data
was never passed in.

In the future, we could improve this by moving the font enumeration into
the back end web server thread but that's a bigger refactor and not
appropriate for beta.
2020-12-15 14:31:38 +11:00
Marc Durdin
06b96400f5 fix(windows): help window centred on load
Fixes #4004.

Centres the help window when it first appears.

There is still a small resizing event but that will be handled with a
separate PR for #3765.
2020-12-15 13:58:53 +11:00
Marc Durdin
51f415c337 fix(windows): uninstall language button z-index
Fixes #4009.

Brings the uninstall language button above the text so it is clickable
even when the text overlaps.
2020-12-15 12:37:33 +11:00
Marc Durdin
cf2a0ecc60 fix(windows): Canonicalize BCP 47 tag on keyboard download
Fixes #4111.

The keyboard tag passed in from search would  often be missing a region
tag which is required on Windows.
2020-12-15 12:28:57 +11:00
Marc Durdin
32d9fc78d1 chore(windows): rename variables 2020-12-15 12:21:20 +11:00
Marc Durdin
895cd8b375 fix(windows): beta uses wrong server 2020-12-15 12:11:11 +11:00
Marc Durdin
49de5cffd2 fix(windows): remove obsolete option 'Switch to OSK/Help'
Fixes #4113.

The option "Switch to On Screen Keyboard/Help automatically when a
keyboard is selected" is obsolete and we should remove it from the UI.

Note that this does not remove the API surface, just hides the option
from view, as there may be apps relying on the API value.

Not touching help just now as that will be addressed in a help update
in the future.
2020-12-15 11:58:42 +11:00
Marc Durdin
ad932cdb74 fix(windows): menu scroll positions need reset at popup
Fixes #4012.

If the menu previously was scrollable, then it would potentially show
items at the wrong offset because the offsets were not reset when the
menu popup was called if no scroll was needed.
2020-12-15 11:46:30 +11:00
Marc Durdin
80d8169a4e fix(windows): glitch in keyboard menu
Fixes #4112.

Glitch in keyboard menu from scrollable buttons being drawn at top-left.
2020-12-15 11:44:59 +11:00
Marc Durdin
900eef7945 chore(windows): remove obsolete importkeyboard app
Functionality has been ported to kmconvert.

Fixes #4042.
2020-12-15 11:20:09 +11:00
Marc Durdin
3fb2c5fe64 chore(windows): apply eberhard's suggestions 2020-12-08 08:37:48 +11:00
Marc Durdin
e7c87ca65a chore(windows): titles and missing files 2020-12-08 06:31:47 +11:00
Marc Durdin
016a0a6588 chore: also build web help 2020-12-07 14:05:01 +11:00
Marc Durdin
80cee4101f fix(windows): help deployment
Reworks help-keyman-com.sh and brings help build.sh in line with it
so that it opens a PR now on help.keyman.com
2020-12-07 06:24:21 +11:00
Marc Durdin
9df408856b
Merge pull request #4075 from keymanapp/chore/windows/remove-docbook-libxslt
chore(windows): remove docbook and libxslt
2020-12-04 14:08:45 +11:00
Marc Durdin
ff127ca8d6
Merge pull request #4074 from keymanapp/feat/windows/convert-desktop-help-to-markdown
feat(windows): convert Keyman for Windows help to Markdown
2020-12-04 14:08:20 +11:00
Marc Durdin
d7c2333cef chore(windows): remove old xsltproc reference 2020-12-04 13:43:47 +11:00
Marc Durdin
b8da7cf962 chore(windows): remove docbook and libxslt
As we now build help files from Markdown, we no longer
need these two dependencies.
2020-12-04 13:43:46 +11:00
Marc Durdin
c6689a0763 chore(windows): hhc return values 2020-12-04 12:24:15 +11:00
Marc Durdin
361e8ddaac chore(windows): fix Makefile 2020-12-04 11:24:35 +11:00
Marc Durdin
93353a91e6 feat(windows): convert Keyman for Windows help to Markdown
1. This is an initial conversion, so much editing to do.
2. Establishes a build script with pandoc dependency.
3. Works to build both .chm and .md on website.
4. Docbook is no longer required; removed in follow-up PR.
2020-12-04 10:59:42 +11:00
Marc Durdin
ed117958d5 fix(windows): keyman: link with = sign is mishandled
Fixes #4068.

If a keyman://download/keyboard/ link contains an `=` sign (e.g. for
BCP 47 tag), then kmshell was treating it as a parameterised local
filename rather than giving it the property url protocol handler
treatment.
2020-12-03 16:12:59 +11:00
Marc Durdin
bf0c4962ec chore(windows): fix typo 2020-12-03 15:14:02 +11:00
Marc Durdin
498100f78b fix(windows): split signed and unsigned versions of setup.exe 2020-12-03 14:56:25 +11:00
Marc Durdin
8d9054f255 fix(windows): bootstrap installer not signed
Fixes #4066.
2020-12-03 14:15:16 +11:00
Marc Durdin
5237d44175 fix(windows): logo was repeating 2020-12-02 15:26:09 +11:00
Marc Durdin
d89f66b073 chore(windows): rollback install path 2020-12-02 14:39:25 +11:00
Marc Durdin
475b13193f fix(windows): typo in wxs 2020-12-02 12:03:52 +11:00
Marc Durdin
2a182946b2 chore(windows): fix wxs bug 2020-12-02 11:09:58 +11:00
Marc Durdin
76407b2d86 fix(windows): rollback registry changes and fix one bug 2020-12-02 10:42:43 +11:00
Marc Durdin
9e46b555d9 fix(windows): Rename to Keyman
Fixes #4003.

This addresses the majority of locations where we use the name "Keyman
Desktop" in code. There will be some filenames and paths that do not
change at this point -- particularly at a source level. For now, the
focus is on the user interface changes.

While making these changes, I also made the VERSION and MANIFEST
resources more consistent.
2020-12-02 09:56:14 +11:00
Marc Durdin
b221088de3 fix(windows): Rename to Keyman in help files
Relates to #4003.

Some minor edits have been made but the help files need a revisit before
release as there is much out of date content.
2020-12-02 09:52:39 +11:00
Marc Durdin
1b0d4aafd5 chore(windows): remove obsolete newhelp folder 2020-12-02 09:51:11 +11:00
Marc Durdin
f91702fd33
Merge pull request #4037 from keymanapp/chore/windows/disable-started-sentry-event
chore(windows): disable Sentry 'Started' event
2020-12-01 17:29:39 +11:00
Marc Durdin
50b382a38e
Merge pull request #4036 from keymanapp/fix/windows/3993-handle-network-errors
fix(windows): Handle network errors when downloading keyboards
2020-12-01 17:29:26 +11:00
Marc Durdin
62d13ed2a5
Merge pull request #4035 from keymanapp/fix/windows/3563-keep-language-associations-update
fix(windows): Keep language associations when updating keyboard
2020-12-01 17:29:18 +11:00
Marc Durdin
9c902184a0
Merge pull request #4034 from keymanapp/fix/windows/4005-crash-onlineupdate-package
fix(windows): crash with package online update
2020-12-01 17:29:10 +11:00
Marc Durdin
1897ff14d6 chore(windows): cleanup task deletion issues 2020-12-01 16:45:59 +11:00
Marc Durdin
ae8bb689af chore: improve logging on uninstall 2020-12-01 11:25:38 +11:00
Marc Durdin
7ccde0e3ed chore(windows): disable Sentry 'Started' event
We used the 'Started' event when testing Sentry integration. We no
longer need it, but I left it in as commented code so we can re-enable
if/when we do Sentry updates in the future and need to re-test.
2020-12-01 10:45:22 +11:00
Marc Durdin
d122b3943b fix(windows): Handle network errors when downloading keyboards
Fixes #3993.
Fixes KEYMAN-WINDOWS-4P.

Handles network errors which caused an exception, e.g. connection timed
out, or 12030 The connection with the server was terminated abnormally.
2020-12-01 10:32:31 +11:00
Marc Durdin
1c7ed746dd fix(windows): Keep language associations when updating keyboard
Fixes #3563.

When a keyboard is updated in an online update check, keep the existing
language assocations. This is fixed by using the new install paradigm
which does not change the user's language associations, and so it also
happens to fix issues with non-elevated users who do an update and would
end up with no languages installed.
2020-12-01 10:18:19 +11:00
Marc Durdin
bbfe5adcc8 fix(windows): crash with package online update
Fixes #4005.

The wrong object was being freed which caused an access violation
internally.
2020-12-01 10:15:05 +11:00
Marc Durdin
a2d6f7d3e8 fix(windows): Task creation and deletion cleanup
Fixes #3994.

Task creation was failing for some users because Windows Tasks are all
stored in a shared folder, so attempts to use the same task name by
different users were failing, especially if the user was a non-admin
user.

Furthermore, attempts to execute the trigger would fail because Windows
treats keyman.exe as needing elevation in this context (even though it
doesn't, actually), and so I changed the trigger to call `kmshell -s`,
which then does the needful.

Finally, the uninstaller now attempts to remove all the scheduled tasks
in the Keyman folder. It doesn't care if it fails -- it's just cleanup
and doesn't impact the system adversely if the tasks hang around.
2020-12-01 09:28:14 +11:00
Marc Durdin
376454229f chore(windows): cleanup unused variable 2020-11-27 15:58:52 +11:00