Commit graph

3486 commits

Author SHA1 Message Date
Darcy Wong
3dbd78a0ef chore(common): Add Crowdin strings for Kannada 2023-01-03 11:10:57 +07:00
Steven R. Loomis
015e7185a6 chore: merge master into feature-ldml 2023-01-02 13:44:21 -06:00
Marc Durdin
d9eae3869d
Merge branch 'master' into chore/a17s2-beta-to-master 2022-12-23 08:44:42 +11:00
Steven R. Loomis
aedcc4c680 Merge remote-tracking branch 'upstream/master' into chore/merge-master3-epic-ldml 2022-12-22 14:35:33 -06:00
rc-swag
206e619bea
fix(windows): more detailed error message
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-12-22 08:56:43 +10:00
rc-swag
6669d232a6
fix(windows): extra bracket after removing nested if
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-12-21 16:07:17 +10:00
Ross
2c02d34746 fix(windows): modifer event is always serialized
PR #7449 added modifier event to make ensure modifer events
where sent to the serializer even if the key stroke was determined
the key stroke did not need seralizing. However, a logic error was made
trying to use the exiting 'Flag' however this was not set in the
!UseCachedHotkeyModifierState case. This change adds helper function
to simply check if the key is a modifier key and send it to the
event seralizer in that case. Separating from the other logic which
is more concerned with handling hotkeys.
2022-12-21 14:09:35 +10:00
Marc Durdin
184aa0c0db fix(windows): shutdown fix masked modal result
Regression introduced in #7661 (17.0 alpha), #7825 (16.0 beta).

When shutting down CEF cleanly, we needed to pause the form destruction
sequence in order for CEF to complete its shutdown tasks. However, for
a dialog form, it will commonly be closed by setting `ModalResult` to a
non-zero value. In our fix, we inadvertently lost any `ModalResult`
value by calling `Close` after CEF was finished, which sets
`ModalResult` to `mrCancel` (value of 2).

This fix caches the `ModalResult` value, and if non-zero, uses it
instead after CEF shuts down, to achieve the same result.
2022-12-21 08:14:01 +11:00
Marc Durdin
6a273d0fda fix(windows): shutdown fix masked modal result
Regression introduced in #7661 (17.0 alpha), #7825 (16.0 beta).

When shutting down CEF cleanly, we needed to pause the form destruction
sequence in order for CEF to complete its shutdown tasks. However, for
a dialog form, it will commonly be closed by setting `ModalResult` to a
non-zero value. In our fix, we inadvertently lost any `ModalResult`
value by calling `Close` after CEF was finished, which sets
`ModalResult` to `mrCancel` (value of 2).

This fix caches the `ModalResult` value, and if non-zero, uses it
instead after CEF shuts down, to achieve the same result.
2022-12-21 08:06:59 +11:00
Ross
5b88ea932f fix(windows): add sentry error message keyboardid
add sentry error message for when the just installed keyboardid
lookup fails.
2022-12-20 16:37:37 +10:00
Steven R. Loomis
bc14f18460 Merge remote-tracking branch 'origin/master' into chore/core/mergemaster4-epic-ldml 2022-12-15 17:55:13 -06:00
Ross
8b7a6fa08d fix(windows): no languages warning source changed
The red colouring of the "Languages:" label was driven by a xml
element which was taken from a registry value whose cache is not
refreshed without restarting the app. The new xml element is
driven by registery languages value that is refreshed straight
away.
2022-12-14 08:52:04 +10:00
Ross
bb6f1a9974 fix(windows): Improve disable keyboard appearance
The Keyboard layouts tab: When a keyboard is disabled
Just the details text on the right is 'greyed' out. The buttons
on the left our no longer greyed out except for 'Add/remove'
which is now disabled.
2022-12-13 20:37:50 +10:00
Ross
285a779400 fix(windows): Enable active keyboard after Doinstall
After installing a the keyboard language it makes sense to enable the
keyboard. This change adds a step to also enable the keyboard.
2022-12-01 11:48:43 +10:00
Marc Durdin
a81798478e
Merge pull request #7836 from keymanapp/fix/windows/symbol-filenames
fix(windows): lower case filenames for projects
2022-11-29 16:42:48 +11:00
Marc Durdin
fb245bfbeb fix(windows): lower case filenames for projects
Fixes #7828.

Moves all projects to lower case filenames so that we don't end up with
filename conflicts in symbol servers.
2022-11-28 19:29:48 +07:00
Marc Durdin
529278c045 fix(windows): lower case filenames for projects
Fixes #7828.

Moves all projects to lower case filenames so that we don't end up with
filename conflicts in symbol servers.
2022-11-28 19:28:14 +07:00
Marc Durdin
a9a66f28ed fix(windows): Cleanup CEF more correctly in shutdown
Hopefully fixes KEYMAN-WINDOWS-1MR, and probably many related crash
reports. Will monitor on alpha before porting to stable/beta.

This changes the form destruction sequence to make sure that it
doesn't close the form until CEF has been shutdown correctly.
2022-11-27 07:39:34 +07:00
Darcy Wong
fded9721e2 chore(common): Merge branch 'beta' into chore/common/beta-b16s2 2022-11-25 07:58:23 +07:00
Darcy Wong
2001f98d86
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-11-23 07:39:24 +07:00
Darcy Wong
c584f0cb45 chore(common): Add notes about bugfixes 2022-11-22 10:50:21 +07:00
Darcy Wong
f98b342fee chore(common): Update whatsnew for 16.0 2022-11-22 10:30:44 +07:00
Marc Durdin
92770fb68b
Merge branch 'beta' into fix/windows/options-buttons-in-list 2022-11-22 06:14:15 +11:00
Marc Durdin
e378feac81 chore(windows): Merge branch 'beta' into fix/windows/7750-arrow-keys-in-options 2022-11-22 06:11:27 +11:00
Marc Durdin
afce1d44bd
Merge pull request #7760 from keymanapp/chore/windows/7759-remove-unused-option-strings
chore(windows): remove unused options from locales and UI
2022-11-21 13:18:44 +11:00
rc-swag
0b22c302c1
Merge pull request #7758 from keymanapp/fix/windows/7747/text-selectable-configuration
fix(windows): Fix text selectable configuration
2022-11-21 11:23:43 +10:00
rc-swag
7c5bfff3d5
Merge pull request #7765 from keymanapp/fix/windows/revert-ms-button-add-lang
fix(windows): backout ms button style for add lang pop up
2022-11-21 09:31:37 +10:00
Darcy Wong
cd27527646
Merge branch 'beta' into chore/common/crowdin-update-zhcn 2022-11-18 16:47:28 +07:00
Darcy Wong
53debd015b
Merge pull request #7715 from keymanapp/chore/common/crowdin-update-ff-ng
chore(common): Update crowin strings for Fulfulde
2022-11-18 14:20:54 +07:00
rc-swag
3b896f826d
fix(windows): delete file not belonging to repo 2022-11-18 16:48:18 +10:00
Ross
c7776a7220 fix(windows): backout ms button style for add lang pop up 2022-11-18 16:28:13 +10:00
Ross
a6a0192b8e fix(windows): fix checkbox and hint help button styles 2022-11-18 15:03:39 +10:00
Ross
5129a9d087 fix(windows): remove dead code 2022-11-18 13:43:29 +10:00
Ross
235e3b81cd fix(windows): remove dead code 2022-11-18 13:33:44 +10:00
Marc Durdin
038e9c2a56
Merge pull request #7754 from keymanapp/fix/windows/7737-elevate-icon-style
fix(windows): tweak elevate icon in Config dialog
2022-11-18 14:07:54 +11:00
Marc Durdin
fa46c14a29 chore(windows): restore koAutoOpenOSK 2022-11-18 12:02:36 +11:00
Marc Durdin
4308dea250 chore(windows): remove unused options from locales and UI
Removes koRunElevatedInVista, koSwitchLanguageForAllApplications,
koSwitchLanguageWithKeyboard, koUnknownLanguage, koTurnOnSurrogates
from localizations and from UI.

These options are no longer relevant, mostly due to improved operating
system support.

Only one option was still visible, koSwitchLanguageForAllApplications,
so this has been hidden in keyman_options.xsl, for future full removal.
2022-11-18 11:57:12 +11:00
Ross
70a7b7426b fix(windows): add user select to keep in touch
Adding this property to the frame even though embeded web page will
overide it
2022-11-18 10:22:19 +10:00
Ross
6269163483 fix(windows): remover user select from configuration 2022-11-18 10:19:42 +10:00
Marc Durdin
c4898bcc3a chore: move Reset Hints below hints option 2022-11-18 11:01:11 +11:00
Marc Durdin
8142be1abc fix(windows): buttons should be in list in Options tab
Relates to #7750.

Makes the buttons in the Options tab part of the list and can be
accessed via arrow keys.
2022-11-18 10:58:09 +11:00
Marc Durdin
d29cccee8e chore(windows): let not same as var 2022-11-18 10:30:47 +11:00
Marc Durdin
446089a8d3 fix(windows): arrow keys need to select next/prev item in options tab
Fixes #7750.
2022-11-18 10:28:25 +11:00
Marc Durdin
5d431d184d fix(windows): Download Keyboard blue footer
Fixes #7753.
2022-11-18 10:14:17 +11:00
Marc Durdin
dd08cc576d fix(windows): tweak elevate icon in Config dialog 2022-11-18 10:01:05 +11:00
Marc Durdin
0671c5b4ba
Merge pull request #7689 from keymanapp/chore/windows/7687-set-core-platform-explicitly
chore(windows): set platform core env explicitly
2022-11-17 06:18:32 +11:00
rc-swag
350279eb15
Merge pull request #7714 from keymanapp/chore/windows/unit-test-for-envin-vars
chore(windows): add unit test for SetupCoreEnvironment
2022-11-16 10:49:22 +10:00
Ross
2fcc0feed0 chore(windows): rearrange mock_options_update add commment 2022-11-15 11:03:41 +10:00
rc-swag
c61ef09312
Merge pull request #7207 from keymanapp/fix/windows/ezip-file-not-avail-elevated-admin
fix(windows): check if permissions for thread to access file
2022-11-14 14:16:47 +10:00
Darcy Wong
7ca7cb8d70 chore(common): Update crowin strings for Fulfulde 2022-11-14 10:27:30 +07:00