Marc Durdin
fa39ae0b22
chore(core): fixup types on unit test
2024-01-23 13:12:47 +07:00
Marc Durdin
39b64be67a
refactor(developer): use km_core_state_get_actions for LDML keyboard debugger
...
Relates to #10416 .
Moves from using action queue to action struct for the LDML keyboard
debugger. Does not do the same for the KMX keyboard debugger, because
that relies on action items to do single-step debugging.
2024-01-23 12:42:27 +07:00
Steven R. Loomis
aecf4e4552
Update core/tests/unit/kmnkbd/test_actions_normalize.cpp
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2024-01-22 16:47:28 -06:00
Eberhard Beilharz
4fa014a098
chore(core): Address code review comments
2024-01-22 11:58:35 +01:00
Steven R. Loomis
c3bae838ec
feat(developer): ldml marker normalization in ts 🙀
...
- use Intl.Segmenter instead.
For: #10317
2024-01-19 18:32:08 -06:00
Steven R. Loomis
f2082d79a6
feat(developer): ldml marker normalization in ts 🙀
...
- cleanup and move marker_no_index into the shared area
For: #10317
2024-01-19 18:07:51 -06:00
Steven R. Loomis
72371675dd
Merge branch 'master' into feat/developer/10317-dev-nfd-epic-ldml
2024-01-19 18:01:38 -06:00
Steven R. Loomis
2bb4747c2f
feat(developer): ldml marker normalization in ts 🙀
...
- add nfd table from ICU
For: #10317
2024-01-19 16:26:01 -06:00
Steven R. Loomis
384ee3b189
feat(developer): ldml marker normalization in ts 🙀
...
- C++ build fix
For: #10317
2024-01-19 14:30:19 -06:00
Steven R. Loomis
ac315661ed
feat(core): ldml actions: include what you use 🌱
...
- missed an include
For: #10410
2024-01-19 13:45:12 -06:00
Steven R. Loomis
259471408a
feat(core): ldml actions: reinstate divergence test 🌱
...
- compare context to test context, but SKIPPING markers.
For: #10410
2024-01-19 11:43:33 -06:00
Steven R. Loomis
04a6e164d7
feat(core): ldml actions: updates per code review 🌱
...
- fix backspace processing
- fix k_102 - we can no longer test for context invalidation here
- fix a test that assumed non-const km_core_actions.output
For: #10410
2024-01-19 11:24:41 -06:00
Steven R. Loomis
6ea83391a7
Merge remote-tracking branch 'origin/epic/core/9999-normalization' into feat/core/10410-ldml-really-use-action-struct
2024-01-19 10:40:42 -06:00
Eberhard Beilharz
a4c940418f
fix(core): Fix nuances when updating context
...
Fixes #10100 .
2024-01-19 15:56:40 +01:00
Marc Durdin
249ed77835
Merge branch 'epic/core/9999-normalization' into chore/merge-master-into-core/9999-normalization
2024-01-19 17:42:40 +11:00
Steven R. Loomis
ade29e0d84
feat(core): ldml marker: assert that all markers were re-added 🙀
...
For: #10369
2024-01-19 00:13:08 -06:00
Steven R. Loomis
93340649d1
Merge pull request #10425 from keymanapp/feat/core/19410-ldml-use-action-struct
...
chore(core): ldml shuffle some deck chairs 🌱
2024-01-19 00:05:59 -06:00
Steven R. Loomis
9ff937b4ab
Apply suggestions from code review
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2024-01-18 23:59:29 -06:00
Marc Durdin
583b0836de
Merge pull request #10430 from keymanapp/chore/core/10424-surrogate-pair-tests
...
chore(core): add surrogate pair tests to test_actions_normalize 🌱
2024-01-19 13:51:16 +11:00
Marc Durdin
c1304a9c19
Merge pull request #10428 from keymanapp/refactor/core/10423-move=context-helpers
...
refactor(core): move context helpers to a new module 🌱
2024-01-19 13:51:09 +11:00
Marc Durdin
4f909dcc83
Merge pull request #10403 from keymanapp/feat/core/9999-normalize-output
...
feat(core): infrastructure for normalization of output 🌱
2024-01-19 13:51:00 +11:00
Marc Durdin
ba46d2127d
chore(core): address review comments
2024-01-19 09:50:00 +07:00
Marc Durdin
a26e21aba7
chore(core): address review comments
2024-01-19 08:01:45 +07:00
Steven R. Loomis
ae00eda4a0
chore(core): ldml shuffle some deck chairs 🌱
...
- move the emit_ and context functions into an ldml_event_state object
For #10410
2024-01-18 15:47:15 -06:00
Steven R. Loomis
6e2030b3b8
feat(developer): ldml marker normalization in ts 🙀
...
- intial parsing
For: #10317
2024-01-18 12:39:19 -06:00
Steven R. Loomis
973cf5d044
feat(core): ldml use action struct in tests 🌱
...
- clarify warnings in ldml.cpp for assertions we are skipping for now
- remove unused parameter
For: #10410
2024-01-18 08:48:50 -06:00
Steven R. Loomis
8095977bec
feat(core): ldml action struct test runner changes 🌱
...
- change ldml test suite, with TODOs
- backspace validation is different, as we don't know the expected char.
For: #10410
2024-01-18 22:55:06 -06:00
Steven R. Loomis
4c322ddb8a
feat(core): ldml action struct 🌱
...
- update km_core_actions.output to be a const*
- for now, call state->actions().commit() from ldml_event_state::commit()
For: #10410
2024-01-18 22:26:46 -06:00
Steven R. Loomis
20a13fa682
feat(core): ldml attempt to use action struct 🌱
...
- not quite working
For: #10410
2024-01-18 17:00:04 -06:00
Steven R. Loomis
16d641fc3b
feat(developer): ldml marker normalization in ts 🙀
...
- scaffolding and tests
For: #10317
2024-01-18 05:43:44 -06:00
Steven R. Loomis
64c808c4cc
feat(core): ldml marker segments: fix build errs 🙀
...
- remove unused function
For: #10369
2024-01-18 02:54:55 -06:00
Steven R. Loomis
2c56223f53
feat(core): ldml marker: improve segment algorithm 🙀
...
- easier to understand loop
- comments
For: #10369
2024-01-18 14:39:10 -06:00
Steven R. Loomis
3ccffe9430
feat(core): ldml marker: refactor, use nfd props 🙀
...
- split out parse_next_marker()
- use NFD safe boundaries to segment marker interaction
For: #10369
2024-01-18 13:51:40 -06:00
Marc Durdin
83f80c061a
refactor(core): remove unused context APIs
...
Fixes #10431 .
The `km_core_` prefix has been removed from internal-only functions, and
these function declarations moved to context.hpp.
The functions have not been moved from km_core_context_api.cpp at this
stage.
Rewrote the function documentation in Javadoc style comments for the
internal use functions.
2024-01-18 12:18:07 +07:00
Marc Durdin
c6acf86629
Merge pull request #10419 from keymanapp/chore/core/10410-ldml-just-say-no-to-action-queues
...
chore(core): ldml assert if queue functions are called 🌱
2024-01-18 14:47:04 +11:00
Marc Durdin
eece9716b7
refactor(core): additional comments
2024-01-18 10:42:18 +07:00
Marc Durdin
8b3c247520
chore(core): add surrogate pair tests to test_actions_normalize
...
Fixes #10424 .
2024-01-18 09:48:29 +07:00
Marc Durdin
63574f8513
chore(core): add assertions to context helpers
2024-01-18 09:31:13 +07:00
Marc Durdin
b3261b8dc4
refactor(core): move context helpers to a new module
...
Fixes #10423 .
2024-01-18 09:26:58 +07:00
Marc Durdin
3878394787
chore(core): remove todo comment
2024-01-18 08:53:55 +07:00
Marc Durdin
425ebe36b0
feat(core): synchronize app_context for non-normalizing keyboardprocessors
...
Fixes #10421 .
2024-01-18 08:52:59 +07:00
Marc Durdin
4ab47ea435
chore(core): further debug assertions for actions_normalize
2024-01-18 08:39:53 +07:00
Marc Durdin
823120b0c4
chore(core): simplify input assumptions for actions_normalize
...
Per discussion in #10422 , we can assume that input cached_context is
always NFD. However input actions->output may not start at a
normalization boundary, so we still need to backtrack to a normalization
boundary in order to get our NFC output. But cached_context never need
change.
This makes no change to the algorithm, but tweaks some of the unit tests
to adhere to this input assumption.
Note: we could consider adding a debug assertion that cached_context is
NFD.
2024-01-18 08:25:15 +07:00
Steven R. Loomis
7bc8831267
feat(core): updates to add_back_markers 🙀
...
- support out-of-order re-adding
- test for updated marker map
2024-01-17 19:04:11 -06:00
Steven R. Loomis
2e46bfea81
chore: reformat
2024-01-17 19:04:05 -06:00
Steven R. Loomis
990635eb09
feat(core): WIP attempt at cross segment markers 🙀
...
#10369
2024-01-17 19:03:43 -06:00
Steven R. Loomis
e4e7d9fd27
Merge branch 'feat/core/10319-escaping-you-epic-ldml' into feat/developer/10319-remove-old-escape-epic-ldml
2024-01-17 18:49:50 -06:00
Steven R. Loomis
b6a6b7e6b8
feat(core): ldml fix test case and parser 🙀
...
For: #10319
2024-01-17 18:32:39 -06:00
Steven R. Loomis
d08e7051cf
feat(core): ldml updates per code review 🙀
...
- don't try to remove irregular sentinel sequences
- update test
For: #10319
2024-01-17 18:34:56 -06:00
Steven R. Loomis
763bc96739
feat(core): ldml updates per code review 🙀
...
- remove stray change to kmx_processevent.cpp
- fix escaping of syntax chars
- fix comment per review
For: #10319
2024-01-17 18:05:28 -06:00