Commit graph

1032 commits

Author SHA1 Message Date
Steven R. Loomis
2d05c8f379 spec(core): ldml: document KMXPlus update process 🙀
For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
2022-11-22 18:45:33 -06:00
Steven R. Loomis
3496939073 feat(core): ldml: steps for list/key2 🙀
- update kmx-plus.ts for key2 and list sections
- add tests for key2
- TODO: binary write, basic fixture, layr

For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
2022-11-22 18:39:25 -06:00
Steven R. Loomis
bccb64c911 feat(core): ldml: kmx-plus.ts for layr/key2/list 🙀
- update kmx-plus for layr/key2/list

For #7532
2022-11-17 15:37:25 -06:00
Steven R. Loomis
208a6e40a0 feat(core): ldml: C++ builds 🙀
For #7532
2022-11-17 14:17:55 -06:00
Steven R. Loomis
02ab5b5851 feat(core): ldml: correct length of list 🙀
For #7532
2022-11-17 14:17:27 -06:00
Steven R. Loomis
06308a26da feat(core): ldml: spec: correct length of list 🙀
For #7532
2022-11-17 14:17:07 -06:00
Steven R. Loomis
64c5c796a1 feat(core): ldml: steps for list/key2 🙀
- update .ts constants
- update builder to support digits in section id
- update XML and stub KMXPlusData

For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
2022-11-16 19:05:14 -06:00
Steven R. Loomis
b639d80a01 feat(core): ldml: spec: correct padding key2 🙀
- also document key2.flicks.flags

For #7532
2022-11-16 19:05:14 -06:00
Steven R. Loomis
0e6aa6566f feat(core): ldml: First steps for layr 🙀
For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532

- dummy Layr class for compilation
- fleshed out Layr class
- CPP validation side
2022-11-16 19:04:55 -06:00
Eberhard Beilharz
108e849459
fix(linux): Fix lintian warnings 2022-11-16 18:45:34 +01:00
Ross
2fcc0feed0 chore(windows): rearrange mock_options_update add commment 2022-11-15 11:03:41 +10:00
Steven R. Loomis
2b9a90f6eb
Merge pull request #7561 from keymanapp/feat/core/7532-fullspec-epic-ldml 2022-11-14 09:13:10 -06:00
rc-swag
9117b391e3
chore(windows): address review comments
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-11-14 16:15:40 +10:00
Ross
578a9017f4 chore(windows): add unit test for SetupCoreEnvironment 2022-11-14 12:55:13 +10:00
Steven R. Loomis
34013b3fe9 feat(core): ldml: spec, add 'list' section, others 🙀
- multiTap
- flicks
- longPress

New 'list' section for string lists

For #7532
2022-11-10 18:24:11 -06:00
Marc Durdin
42a9f2ca72 fix(core): emit keystroke was writing to wrong queue
Fixes #7649.

emit_keystroke code path in kmx processor was writing directly to the
core queue instead of to the internal kmx processor queue. This caused
it to be out-of-order in the actions sent to the engine/debugger.

Engines didn't really care but it broke the debugger, for example if
only a deadkey was in the buffer and backspace was pressed, Developer
would assert as it would get unexpected context for the deletions.
2022-11-08 16:31:30 +11:00
Steven R. Loomis
57648d87a2 fix(core): ldml: spec WIP 🙀
For #7532
2022-11-07 15:30:23 -06:00
Steven R. Loomis
d2546060d5
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-11-07 11:26:09 -06:00
Marc Durdin
8e5c26bc2a fix(core): m_actions already existed in KMX_Options 2022-11-07 10:50:14 +11:00
Marc Durdin
a8c3854431 fix(core): save() should be on internal kmx action queue
Fixes #7643.

The kmn statement `save()` action was being written directly to the
state queue, bypassing the internal kmx action queue. This caused two
issues:

1. save() actions were out-of-order with other actions on the same key
   event.
2. The number of items in the internal action queue became out of sync
   with the debug item queue, which would cause the debugger to fail
   with an assertion.

The new test in debug_api.cpp validates this second issue as the number
of items in the action queue now matches the expected count in the
corresponding debug item.
2022-11-07 10:28:58 +11:00
Steven R. Loomis
670791d3a9 fix(core): ldml spec typo 2022-11-04 15:28:26 -05:00
Steven R. Loomis
1f2d8e782a fix(core): sprintf to snprintf 2022-11-04 15:06:12 -05:00
Steven R. Loomis
a9daefb293 feat(core): ldml: updates to C7043.1 spec 🙀
- merge all but the kitchen sink into layr element :)
- update numbers
2022-11-04 13:24:05 -05:00
Steven R. Loomis
a00ea0423a chore(core): ldml: cleanup 🙀
- minor cleanup in the .cpp

#5015
2022-11-02 13:39:17 -05:00
Steven R. Loomis
5421b6ec0b Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-11-02 13:36:24 -05:00
Steven R. Loomis
1c7517c5a8 fix(developer): ldml: yet more review feedback fixes 🙀
🙀 #7532
2022-11-02 13:36:24 -05:00
Steven R. Loomis
49b46f42ea feat(common): ldml: builder disp 🙀
- with initial core updates

For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
2022-11-02 13:36:24 -05:00
Steven R. Loomis
bf45412b72 feat(core): ldml: add constants for disp 🙀
For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532

depends on #7566
2022-11-02 13:36:24 -05:00
Steven R. Loomis
2d888ecfe2 fix(core): ldml: fix const builder 🙀
- fix tsconfig per review comments
- update builder to compile again
- add some err checking

#7566
2022-11-02 13:33:00 -05:00
Steven R. Loomis
f140093088
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-11-02 13:09:35 -05:00
Steven R. Loomis
c191fc7cc7 feat(core): ldml: updates to C7043.1 spec 🙀
merge layr into lyrs
2022-10-28 18:28:18 -05:00
Steven R. Loomis
87dc1f79bb feat(core): ldml: updates to C7043.1 spec 🙀
- add layers, rows, display
- draft status
2022-10-28 18:28:18 -05:00
Steven R. Loomis
8bfa0bbfcd fix(core): ldml: fix const builder 🙀
- fix config
- Add .js to the import statement
(not a great fix)

Fixes #7566
2022-10-28 18:25:56 -05:00
Marc Durdin
7ef6f288c4
Merge pull request #7520 from keymanapp/fix/core/7487-remove-visibility-attribute-from-callback-type
fix(core): remove `KMN_API` from callback spec
2022-10-28 11:55:54 +11:00
Marc Durdin
9c2edbcbc0 fix(core): remove KMN_API from callback spec
Fixes #7487.

`KMN_API` defines only import/export/static modifiers for functions, so
it makes no sense to apply it to a typedef. (Previously, I thought it
also included a calling convention, but it doesn't.)
2022-10-25 11:59:37 +11:00
Marc Durdin
920d22795c chore(core): additional cleanup 2022-10-21 15:33:09 +11:00
Marc Durdin
ae68f059b8 chore(core): move DebugLog into parent folder
Fixes #7447.
2022-10-21 15:26:41 +11:00
Eberhard Beilharz
e04acb8295
fix(core): Add missing include files
Recently some include files got added to `common/include` which are
referenced by `core/include/keyman`. This change adds the necessary
code to install them in the same directory as the other include files.

Fixes #7490.
2022-10-20 17:06:35 +02:00
Steven R. Loomis
85da473a85 chore(developer): update DTD location 🙀
- dtd is in a subdirectory to match CLDR layout
2022-10-18 12:52:27 -05:00
Steven R. Loomis
66a5cdb1f9 chore(developer): ldml: update tools and data for keyboard-preview 🙀
- update tooling in common and kmc
- update spec
- update test files
2022-10-18 11:32:41 -05:00
Steven R. Loomis
85ed41e16c
Merge pull request #7410 from keymanapp/fix/developer/7404-elem0-epic-ldml 2022-10-17 08:53:23 -05:00
Marc Durdin
4505497dd2
Merge pull request #7456 from keymanapp/chore/common/epic-ldml/update-build-script-deps
chore(common): update build.sh dependencies for epic-ldml 🙀
2022-10-17 04:51:02 +11:00
Steven R. Loomis
7e5c9ec675 fix(developer): offset of 0th elem str must be 0000 🙀
- update test fixture
- update kmx_plus.cpp to require this

Fix: 7404
2022-10-14 15:00:49 -05:00
Marc Durdin
cbb15b2cb9 chore(core): tweak scripts 2022-10-14 16:32:57 +11:00
Steven R. Loomis
9cb5a03a0d
Merge pull request #7454 from keymanapp/fix/core/7418-utf32-suggestions
fix(core): xstring/utf32 review feedback
2022-10-14 00:00:45 -05:00
Marc Durdin
2cf6bf3f60 chore(common): update build.sh dependencies for epic-ldml 2022-10-14 10:45:00 +11:00
Steven R. Loomis
67cac5f147
Merge pull request #7436 from keymanapp/chore/core/refactor-vkeys-epic-ldml
chore(core): ldml: split out vkey processing 🙀
2022-10-13 17:13:07 -05:00
Steven R. Loomis
fc554c4901 fix(core): xstring/utf32 review feedback
For: #7418

Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
2022-10-13 17:05:39 -05:00
Steven R. Loomis
45bc101e77 fix(core): ldml: update per review comments 🙀
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-10-13 16:34:36 -05:00
Steven R. Loomis
ab0f2c1b24 feat(core): ldml: basic transforms, utf32 fixes 🙀
for #7234
2022-10-12 19:31:05 -05:00