Commit graph

5162 commits

Author SHA1 Message Date
Marc Durdin
ab1e916086
Merge pull request #11590 from keymanapp/fix/developer/11589-single-pixel-top-row-for-touch-on-character-map
fix(developer): make top row of Character Map 1 pixel to avoid DIV/0 in gestures
2024-05-31 13:07:21 +07:00
Joshua Horton
c4932b7fd1
docs(web): adds suggested documentation from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2024-05-31 10:06:05 +07:00
Joshua Horton
8f3569681b
docs(web): Update codes.ts with docs on use of the 50000 literal 2024-05-30 16:56:30 +07:00
Joshua Horton
006f15b225
change(web): minor simplification from review
Co-authored-by: Marc Durdin <marc@durdin.net>
2024-05-30 16:53:17 +07:00
Joshua A. Horton
487a28da8e docs(web): for EncodedVisualKeyboard 2024-05-30 16:44:27 +07:00
Joshua A. Horton
10033f4dea docs(web): fixes detail about readonly keystroke params 2024-05-30 16:40:59 +07:00
Joshua A. Horton
61dfcc98f6 docs(web): documents KeyboardObject properties 2024-05-30 16:37:00 +07:00
Joshua Horton
ee0c107afe
fix(web): for...of, not for...in
We moved to the Object.keys() pattern, which means replacing the 'in'

Co-authored-by: Marc Durdin <marc@durdin.net>
2024-05-30 15:58:57 +07:00
Joshua Horton
321ded4776
Merge pull request #11460 from keymanapp/chore/web/remove-unused-locals
chore(web): removes unused locals, imports, and private fields 🔩
2024-05-30 15:50:45 +07:00
Joshua Horton
da4cf64ebf
Merge pull request #11598 from keymanapp/fix/web/worker-prediction-match-token
fix(web): use intended source for prediction-to-context matching 🔩
2024-05-30 15:50:31 +07:00
Joshua Horton
dbee817d80
Merge pull request #11459 from keymanapp/chore/web/fix-implicit-this
chore(web): fixes implicit-this cases 🔩
2024-05-30 15:50:24 +07:00
Joshua Horton
f283d955a7
Merge pull request #11596 from keymanapp/fix/web/recorder-core-strictness
fix(web): headless recorder unhandled paths, invalid test-sequence references 🔩
2024-05-30 15:50:12 +07:00
Joshua Horton
47f91d8b13
change(web): Apply suggestions from code review
We bothered defining a local const, so why not use it everywhere that makes sense?  (Small polishing)

Co-authored-by: Marc Durdin <marc@durdin.net>
2024-05-30 14:07:34 +07:00
Joshua Horton
a3c8daa218
Merge pull request #11414 from keymanapp/chore/web/update-typescript
chore(web): updates TypeScript version to 5.4.5
2024-05-30 14:03:48 +07:00
Joshua Horton
65a0c22bda
Merge pull request #11579 from keymanapp/fix/web/sentry-report-null-debug-info
fix(web): add null guard for missing debug info when reporting to Sentry
2024-05-30 13:59:52 +07:00
Joshua Horton
b6d27d0548
Merge pull request #11472 from keymanapp/fix/web/kbd-doc-generation
fix(web): correctly handle cross-origin stylesheets when calculating keyboard size and key cap font size
2024-05-30 13:59:26 +07:00
Marc Durdin
a68124b5e6 chore(windows): support port in THTTPUploader
This can be useful for debugging scenarios, where we want to use a local
test HTTP server on a different port, e.g. setting
`development.urls.api_keyman_com_host` to `localhost:8058`.
2024-05-30 08:20:43 +07:00
Eberhard Beilharz
c85ae47a20
change(web): Output warning if we can't apply suggestion
This addresses code review comments. We output a separate error if
the configuration isn't yet set because the model isn't fully loaded yet.
2024-05-29 19:25:25 +02:00
Joshua A. Horton
70c7268192 chore(web): and the corresponding patch-up for gesture unit-tests 2024-05-29 10:58:04 +07:00
Joshua A. Horton
f34fd85130 chore(web): gesture-recognizer unit-test noImplicitAny touchup 2024-05-29 10:54:23 +07:00
Joshua A. Horton
d5b5eebe00 chore(web): previously-missed spot in gesture-recognizer 2024-05-29 10:54:19 +07:00
Joshua A. Horton
5ddcf2cbe5 chore(web): patches web tools for enforcement of no implicit any 2024-05-29 10:43:12 +07:00
Joshua A. Horton
6591c61eeb chore(web): enforces noImplicitAny for app/browser and app/webview 2024-05-29 10:43:11 +07:00
Joshua A. Horton
12c91d90c3 fix(web): better suggestionApplier fix for the 'reversion' path 2024-05-29 10:36:38 +07:00
Joshua A. Horton
2f42f3943c chore(web): better use of scope within getVKDictionaryCode 2024-05-29 10:36:38 +07:00
Joshua A. Horton
04244415a4 chore(web): resolves some nits observed in review 2024-05-29 10:36:37 +07:00
Joshua A. Horton
3530314cbd chore(web): noImplicitReturns, strictNullChecks 2024-05-29 10:36:37 +07:00
Joshua A. Horton
35b7ed647f fix(web): gesture-recognizer tests aren't ready yet 2024-05-29 10:36:36 +07:00
Joshua A. Horton
32d72bf2dc chore(web): also, strictFunctionTypes - an easy one at lower-levels 2024-05-29 10:36:35 +07:00
Joshua A. Horton
09416e50b6 chore(web): preps gesture-recognizer, but doesn't remove setting 2024-05-29 10:36:35 +07:00
Joshua A. Horton
b56628ea24 chore(web): removes all Web-related implicit-any usage outside of web/ and common/web/gesture-recognizer 2024-05-29 10:36:30 +07:00
Joshua A. Horton
fbe9f4d2fd fix(web): missing return value when setting stores 2024-05-29 10:24:24 +07:00
Joshua A. Horton
be1cc343ef change(web): remove broken redundant check for keys to not correct 2024-05-29 10:22:28 +07:00
Joshua A. Horton
fec1bbc008 fix(web): legacy BK array typing - uses array of strings, not a singlestring 2024-05-29 10:10:50 +07:00
Joshua A. Horton
3e8cd1b73e refactor(web): keyboard-layout preprocessing property transplantation 2024-05-29 09:30:31 +07:00
Joshua A. Horton
50a194aa71 change(web): suggested 'utf-8' change from code review 2024-05-29 09:24:38 +07:00
Joshua A. Horton
3d82272989 chore(web): previously-missed spot in gesture-recognizer 2024-05-29 09:24:37 +07:00
Joshua A. Horton
41a090cce9 chore(web): converts JS unit test to TS 2024-05-29 09:24:17 +07:00
Joshua A. Horton
084916a893 chore(web): removes gesture-recognizer unit-test unused locals 2024-05-29 09:24:16 +07:00
Joshua A. Horton
826204cdc1 chore(web): cleans up unused locals outside of web/ 2024-05-29 09:24:16 +07:00
Joshua A. Horton
fff9e23ecd chore(web): Merge branch 'chore/web/fix-implicit-this' into fix/web/worker-prediction-match-token 2024-05-29 09:12:15 +07:00
Joshua A. Horton
b85286ba03 fix(web): post-rebase build error 2024-05-29 09:11:31 +07:00
Joshua A. Horton
5a8f231ef9 fix(web): use intended source for prediction-to-context matching 2024-05-29 08:56:38 +07:00
Joshua A. Horton
bdbf94bd47 chore(web): replaces a couple of 'var's 2024-05-29 08:42:39 +07:00
Eberhard Beilharz
8dc30c9d28
fix(web): Don't apply suggestion unless fully configured
We can't really apply a suggestion unless we have the configuration object
(that provides the context).

Fixes: #11593
Fixes: KEYMAN-WEB-FX
2024-05-28 20:55:35 +02:00
Marc Durdin
1826c13f35 fix(developer): make top row of Character Map 1 pixel to avoid DIV/0 in gestures
An apparent issue in the Grid control in Delphi is that if the top row
is zero pixels high (hiding it), a pan gesture on touchscreen causes an
EDivByZero. This patch works around the issue by making the top row 1
pixel high.

Fixes: #11589
Fixes: KEYMAN-DEVELOPER-1C3
Fixes: KEYMAN-WINDOWS-43C
2024-05-28 14:25:48 +07:00
Joshua A. Horton
2503dfa3a8 fix(web): headless recorder unhandled paths, invalid test-sequence reference 2024-05-28 09:40:50 +07:00
Joshua A. Horton
903d214b43 fix(web): null guard missing debug info when reporting to Sentry
Fixes #11548.
2024-05-28 08:20:35 +07:00
Joshua A. Horton
2c79db4cb5 chore(web): Merge branch 'master' into chore/web/update-typescript 2024-05-27 09:20:01 +07:00
Marc Durdin
78f4cbf8d5 chore: Merge branch 'epic/windows-updates' into chore/merge-master-into-windows-updates
Note: deleted TODO.md, had only one minor update
2024-05-25 05:53:48 +07:00