Commit graph

101 commits

Author SHA1 Message Date
Joshua A. Horton
8c2fb269b6 fix(web): fixes unintended auto-acceptance of suggestion after reverting 2022-09-16 14:26:28 +07:00
jahorton
aa8730acda fix(web): properly binds 'suggestionApplied' event handler 2022-07-04 09:19:51 +07:00
Marc Durdin
49eb062c65 feat(web): prediction casing follows current layer
Fixes #6455.

This involved adding an extra hint to the data passed into the lexical
model layer, being the CasingForm that the current layer wants to use.

Given there are several entry points to the lexical model layer, this
meant a few places where we needed to check the current layer.

I refactored the very long function `InputProcessor.processKeyEvent` to
extract out the `buildAlternates` function. There should be no
functional changes to the `buildAlternates` code. But it makes
`processKeyEvent` significantly easier to read.
2022-04-08 16:14:01 +10:00
Marc Durdin
e616900cad
Revert "feat(web): prediction casing follows current layer" 2022-04-08 14:50:32 +10:00
Marc Durdin
b7ce99480f feat(web): prediction casing follows current layer
Fixes #6455.

This involved adding an extra hint to the data passed into the lexical
model layer, being the CasingForm that the current layer wants to use.

Given there are several entry points to the lexical model layer, this
meant a few places where we needed to check the current layer.

I refactored the very long function `InputProcessor.processKeyEvent` to
extract out the `buildAlternates` function. There should be no
functional changes to the `buildAlternates` code. But it makes
`processKeyEvent` significantly easier to read.
2022-04-01 16:20:50 +11:00
Marc Durdin
45c5f8a1ea chore(web): remove 0 from store defaults 2022-03-13 08:31:15 +11:00
Marc Durdin
b23df3fbc8 feat(web): &newLayer and &oldLayer
Fixes #6364.

Removes `&layerChanged` and adds `&newLayer` and `&oldLayer` system
stores with the additional nuances around values as described in #6364.
2022-03-13 08:29:15 +11:00
Marc Durdin
ac2cc93f2a fix(web): add readonly mode for rule behavior finalization
Relates to #5853.

Two things happened here:

1. Construction of Mocks made an assumption that the selection should
   always be deleted (outputTarget.ts:363). However, for NewContext and
   PostKeystroke processes, we don't want to change anything.

2. Even if nothing is changed, the transcription would emit what is
   in theory a no-op ruleTransform (insert="", deleteLeft=0,
   deleteRight=0). But apps would treat this as deleting the selection.

This fix goes a little broader than I would have preferred, but adds a
readonly mode to the transcription and mock model, so that we can
control explicitly when changes are applied to the text store.
2022-02-22 10:42:20 +11:00
Marc Durdin
ce1ce4e428
Update web/source/osk/banner.ts
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2021-12-07 19:57:29 +11:00
Marc Durdin
10ef52624d chore: remove commented code 2021-12-03 14:15:48 +11:00
Marc Durdin
5e65120b3f fix(web): call postKeystroke on banner touch
Relates to #3621.

Ensures that the `begin postKeystroke` entry point is called when the
user accepts a suggestion.
2021-12-03 14:13:43 +11:00
jahorton
f53df318dc feat(web): functional banner mouse interactions 2021-09-22 12:37:33 +07:00
jahorton
283b36eb00 change(web): moves uiTouchHandlerBase class 2021-07-30 08:15:14 +07:00
jahorton
0d109b12b0 refactor(web): 'easy' part of abstracted RealizedGesture for subkeys 2021-06-24 12:34:43 +07:00
jahorton
125a2ec0d0 refactor(web): two-stages embedded longpress/subkey 2021-06-24 12:12:28 +07:00
jahorton
78c7821f9f change(web): banner display no longer deferred 2021-01-29 11:31:56 +07:00
Darcy Wong
ca04394751 fix(web/ui): Add check for suggestion.tag
Fixes #4079
2020-12-07 08:59:46 +07:00
jahorton
07daee7b16 fix(common/models): fixes post-wordbreak suggestions 2020-12-04 13:39:04 +07:00
Joshua Horton
6efb6d23be
Merge pull request #3685 from keymanapp/feat/common/models/context-reversion
feat(common/models): context reversion modeling
2020-10-20 08:42:07 +07:00
Joshua Horton
73a20cfe8c
Merge pull request #3702 from keymanapp/feat/common/core/web/selective-wordbreak-swallow
feat(common/core/web): selective wordbreak swallowing after accepting suggestions
2020-10-14 08:25:35 +07:00
jahorton
f272efdeca feat(common/core/web): selective wordbreak swallowing after accepted suggestion 2020-10-12 15:33:40 +07:00
jahorton
46eecb81cd feat(common/models): disables "keep" when word is not suggestion otherwise 2020-10-12 12:51:47 +07:00
jahorton
4aae922fb0 change(web): rips out unused suggestion-rotation code 2020-10-09 09:21:33 +07:00
jahorton
2e2fa5475f refactor(web): refactor of Web-side reversion to match 2020-10-08 15:15:56 +07:00
jahorton
7d9d6c0d3f fix(web): more reversion typing 2020-10-08 15:13:59 +07:00
jahorton
cbf56266d5 change(common/core/web): nomenclature shift - accept > apply 2020-10-02 10:17:10 +07:00
jahorton
0c2c591e17 refactor(web/engine): application of predictive suggestions 2020-09-15 15:22:16 +07:00
Joshua Horton
9135c41a05
Merge pull request #2982 from keymanapp/refactor/web/engine/web-core-build-prep
refactor(web/engine): web-core build prep
2020-04-17 08:36:56 +07:00
jahorton
a7dadacbc9 refactor(web/engine): better dependency for same role + a fix 2020-04-16 09:00:12 +07:00
jahorton
8c0f81f8ba refactor(web/engine): headless LanguageProcessor (aside from lmlayer) 2020-04-09 14:51:49 +07:00
jahorton
68dc9a7ddc feat(web/engine): LanguageProcessor events now EventEmitter-backed 2020-04-09 14:05:30 +07:00
jahorton
2f6e1e42af refactor(web/engine): initial ModelManager split 2020-04-09 09:22:35 +07:00
jahorton
7a04baa9a5 change(web/engine): kbdProcessor.core => core.keyboardProcessor 2020-04-06 13:17:32 +07:00
jahorton
8fa4b1eaf1 refactor(web/engine): moves getOutputTarget() => DOM space 2020-03-31 11:48:14 +07:00
jahorton
69b309104a refactor(web/engine): moves CJK, RTL, chiral checks to Keyboard wrapper 2020-03-21 21:40:40 +07:00
jahorton
359003928a fix(ios): fixes image banner alignment. Fixes #2834 2020-03-17 16:15:34 +07:00
jahorton
1b22d3ae19 feat(web): restyles prediction banner 2020-02-11 15:14:20 +07:00
jahorton
678acdfafb feat(ios): Considerable progress toward rendered banner imgs 2020-02-05 10:53:49 +07:00
jahorton
15c1a2dc84 fix(web): removes old, not-working RTL-mark attempt logic 2020-01-30 14:50:09 +07:00
jahorton
97874c60db feat(web): LTR / RTL marks on suggestions based on current kbd 2020-01-30 13:16:22 +07:00
jahorton
7234f8736c fix(web): Suggestions for RTL languages now in RTL order 2020-01-30 12:10:47 +07:00
jahorton
73cbd275d5 Multi-backspace predictive state management 2019-09-02 14:17:31 +07:00
Joshua Horton
715729fec2
Merge pull request #1851 from keymanapp/lmlayer-context-management
[LMLayer, Web] Context Management + Suggestion UX
2019-07-04 11:08:51 +07:00
jahorton
2e3e20559d Moves .isKeep prop to .tag == 'keep'. 2019-07-04 08:09:30 +07:00
jahorton
9c769a5e17 Corrects reversion transform post-bksp change 2019-07-02 09:21:29 +07:00
jahorton
2e4d42e164 Removes post-accept BSKP swallowing 2019-07-02 09:03:22 +07:00
jahorton
bbb1301b55 Initial implementation of revert suggestion option 2019-07-02 09:00:18 +07:00
jahorton
549dcb33d0 KMW wordbreak request for reversion option 2019-07-01 16:02:44 +07:00
jahorton
96225f1fdb KMW now uses LMLayer's new 'keep' suggestion 2019-07-01 15:34:13 +07:00
Marc Durdin
2ca79c7682 [Web] Tweak positioning of banner and layout of OSK 2019-06-17 12:57:34 +10:00