Commit graph

374 commits

Author SHA1 Message Date
Steven R. Loomis
35db576dea
Merge branch 'feat/developer/13935-ln-usetcompiler' into feat/developer/13937-ln-tran-bksp 2025-06-02 10:14:53 -05:00
Steven R. Loomis
cf68b2a3bd
Merge branch 'feat/developer/13932-ln-more-strscompiler' into feat/developer/13935-ln-usetcompiler 2025-06-02 10:14:25 -05:00
Steven R. Loomis
536cdc3c45 feat(developer): ldml: fix for test case
Fixes: #13932
2025-06-02 09:27:46 -05:00
Steven R. Loomis
961a18e0bd Merge remote-tracking branch 'origin/feat/developer/13935-ln-usetcompiler' into feat/developer/13937-ln-tran-bksp 2025-06-02 08:45:04 -05:00
Steven R. Loomis
401015d8ad
Merge branch 'feat/developer/13932-ln-more-strscompiler' into feat/developer/13935-ln-usetcompiler 2025-06-02 08:44:22 -05:00
Steven R. Loomis
706ff1a858
Merge branch 'master' into feat/developer/13932-ln-more-strscompiler 2025-06-02 08:41:41 -05:00
Steven R. Loomis
bc3a8ff36d feat(developer): ldml: tran compiler: all relevant messages in ldml have line numbers!
Fixes: #13937
2025-05-30 15:41:16 -05:00
Steven R. Loomis
814c9b9ef9 feat(developer): ldml: list compiler: add context to linter
Fixes: #13935
2025-05-30 14:47:10 -05:00
Steven R. Loomis
9d0d34bf09 feat(developer): ldml: list compiler: add context to lists. vars, markers, usets...
- update several messages and the substitution tracker to take context

Fixes: #13935
2025-05-30 14:34:40 -05:00
Steven R. Loomis
8662acc46d feat(developer): ldml: list compiler: add context to lists
add contexts to lists and elements and uset

Fixes: #13935
2025-05-30 12:55:57 -05:00
Steven R. Loomis
96f0f783f5 feat(developer): ldml: strscompiler: remaining allocString() calls
This concludes all of the allocString() calls that aren't part of lists, sets, elements etc.

Fixes: #13932
2025-05-30 11:34:57 -05:00
Steven R. Loomis
097c03d2c3 feat(developer): ldml: strscompiler: exclude line numbers from some tests assertions
- remove line number information for some "simpler" uses of the compileKeyboard() test helper

For: #13932
2025-05-30 09:26:39 -05:00
Steven R. Loomis
70ced9847a chore(developer): ldml: unit test for .run() validation
- re-run invalid-illegal.xml through compiler.run()
- ensure it fails

Fixes: #14067
2025-05-29 13:53:23 -05:00
Steven R. Loomis
c3705bf9ef feat(developer): ldml: strscompiler: add context to more allocString call sites
- disp, keys, layr, tran

For: #13932
2025-05-29 09:09:58 -05:00
Steven R. Loomis
633f9551c7 feat(developer): update strs compiler to collect context
- attempt to find an object with a context

For: #13932
2025-05-28 20:17:44 -05:00
Steven R. Loomis
c70464e23f fix(developer): ldml: make sure .run() calls compile() with postValidation
- .run() doesn't call validate() and then compile(), so it needs to call compile() with postValidation=true

Fixes: #14067
2025-05-28 20:15:33 -05:00
Steven R. Loomis
153c03e9f5
Merge branch 'feat/developer/13939-ln-layrcompiler' into feat/developer/13940-ln-locacompiler 2025-05-27 10:54:16 -05:00
Steven R. Loomis
0674fccb05
Merge branch 'feat/developer/13938-ln-dispcompiler' into feat/developer/13939-ln-layrcompiler 2025-05-27 10:54:10 -05:00
Steven R. Loomis
a13cf744fd
Merge branch 'feat/developer/13937-line-numbers-trancompiler' into feat/developer/13938-ln-dispcompiler 2025-05-27 10:53:41 -05:00
Steven R. Loomis
28b919bce8 feat(developer): update tran compiler per code review
For: #13937
2025-05-27 10:46:16 -05:00
Steven R. Loomis
f9305f33f2 feat(developer): add line numbers to loca compiler
Fixes #13940
2025-05-26 13:12:40 -05:00
Steven R. Loomis
b681885eca feat(developer): add more tests to layr compiler
- check for duplicate minDeviceWidth
- check for invalid minDeviceWidth

Fixes #13939
2025-05-26 12:30:59 -05:00
Steven R. Loomis
d2af8cf41a feat(developer): add line numbers to layr compiler
Fixes #13939
2025-05-26 11:34:05 -05:00
Steven R. Loomis
577b439721 feat(developer): add line numbers to disp compiler
Fixes #13938
2025-05-26 10:44:12 -05:00
Steven R. Loomis
00b4de5f53 feat(developer): add line numbers to tran compiler
- move ObjectWithMetadata into symbol utils
- don't validate transforms twice (tran + bksp)

This is for #13937 but does not resolve all items
2025-05-22 17:03:40 -05:00
Steven R. Loomis
870dec3da3 feat(developer): add percentage (permille) of messages without line numbers 2025-05-22 15:54:08 -05:00
Steven R. Loomis
be9ca8323b feat(developer): add line numbers to vars compiler
- some are remaining without errors

This is for #13936 but does not resolve all items
2025-05-22 13:14:18 -05:00
Steven R. Loomis
d176a9dc2e feat(developer): revamp line numbers per design doc
- update the mx() signature and add jsdoc with recommendation
- fix call sites

Fixes: #13941
2025-05-21 07:51:29 -05:00
Joshua Horton
7b1310a7d5
Merge pull request #13899 from keymanapp/maint/update-mocha
maint: update mocha
2025-05-19 08:42:53 +07:00
Steven R. Loomis
158661aee1
Merge pull request #13916 from keymanapp/feat/developer/10622-line-number-meta
feat(developer):  add line number for MetaCompiler 🙀
2025-05-15 09:20:31 -05:00
Steven R. Loomis
419b43c496 feat(developer): bug fix per review
Fixes: #10622
2025-05-15 08:40:24 -05:00
Steven R. Loomis
be1668aa55
Merge branch 'feat/developer/10622-add-more-line-number-issues' into feat/developer/10622-line-number-meta 2025-05-14 16:53:03 -05:00
Steven R. Loomis
497405c4df feat(developer): fixup for api test
Fixes: #10622
2025-05-14 16:52:12 -05:00
Steven R. Loomis
30099fc75d feat(developer): add line number for meta
- made the 'x' parameter optional for some cases

Fixes: #10622
2025-05-14 16:47:54 -05:00
Steven R. Loomis
155b5558bf feat(developer): add line number for keys
- all remaining tests for KeysCompiler
- who's next?

Fixes: #10622
2025-05-14 16:25:59 -05:00
Steven R. Loomis
bdb8823eff feat(developer): add line number for keys
- restructure form loading a little bit, so that we remember the form object
- add a commented-out test that validates that offsets are actually produced

Fixes: #10622
2025-05-14 15:56:19 -05:00
Steven R. Loomis
21c87e2cdc feat(developer): add line number for Warn_CustomForm
- improve test machinery so that it ignores offsets (line number) most of the time unless retainOffsetInMessages is set
- add Warn_CustomForm() using a new model, changing 'o' to be an LKKeys
- update test with the new warning

Fixes: #10622
2025-05-14 14:33:57 -05:00
Steven R. Loomis
7f2d2b945e feat(developer): tests for offsets (line numbers in messages)
- add unit test that complains if no tests have offset(line) numbers, and whine if any don't. Also round trip tests the column number working as expected.
- rename helper withColumn() to withOffset()

Fixes: #10622
2025-05-14 08:50:32 -05:00
Joshua Horton
155c1a2b12 maint: update mocha
Some of the npm audit warnings left after #13897 require an updated `mocha` version to remedy.  As we only really use `mocha` to do unit-testing, it should be safe to update if all of our existing tests pass with the new version.

Test-bot: skip
2025-05-13 14:02:02 +07:00
Steven R. Loomis
42d9c68e2b feat(developer): fix Error() function
- swap x, o because the 'api' call getMessageDetail() is going to call with {}

Fixes: #10622
2025-05-09 16:43:59 -05:00
Steven R. Loomis
6194392310 feat(developer): update for line numbers
- reduce whitespace churn
- other review comments

Fixes: #10622

Co-authored-by: Marc Durdin <marc@durdin.net>
2025-05-09 13:07:51 -05:00
Steven R. Loomis
ad0ea8678b feat(developer): update for line numbers
- added new DelegatingCompilerCallbacks class
- added ResolvingCompilerCallbacks which does event resolution
- added the XML file name metadata to *every object* after XML parse.

Fixes: #10622
2025-05-08 17:29:30 -05:00
Steven R. Loomis
937573869b Merge remote-tracking branch 'upstream/master' into feat/developer/10622-xml-parse-line-numbers-epic-ldml 2025-05-05 09:28:15 -05:00
Joshua Horton
63ad1a8fff change(developer): clean up developer/src/kmc-ldml linter issues 2025-04-30 09:20:12 +07:00
Steven R. Loomis
e003612ea0 feat(developer): update for line numbers
- remove resolver complexity in callback subclasses
- call LDMLKeyboardXMLSourceFileReader.eventResolver.resolve() statically from ldml-compiler-messages

Fixes: #10622
2025-04-10 17:22:51 -05:00
Steven R. Loomis
29f387bebe Merge remote-tracking branch 'upstream/master' into feat/developer/10622-xml-parse-line-numbers-epic-ldml 2025-03-31 16:16:10 -05:00
Steven R. Loomis
0c290bd37a feat(developer): update for line numbers
- update to metadata branch of fast-xml-parser
- restructure metadata handling
- use type safety for fast-xml-parser options

Fixes: #10622
2025-03-31 16:11:19 -05:00
Marc Durdin
ab59fa29b4
Merge branch 'master' into chore/b18s4-merge-beta-to-master 2025-03-29 05:41:03 +07:00
Marc Durdin
a52437c407 chore: Merge branch 'master' into chore/b18s4-merge-beta-to-master 2025-03-29 05:38:08 +07:00
Marc Durdin
de5a02f8ce chore(developer): rewrap detail on semver LDML message 2025-03-29 04:14:38 +07:00