Commit graph

63 commits

Author SHA1 Message Date
jahorton
897c8d5bfe fix(web): fixes osk resize-popping effect 2021-07-06 12:54:49 +07:00
Marc Durdin
ff9cdd7376 fix(web): move function 2021-04-22 14:44:40 +10:00
Marc Durdin
ecb760780e fix(web): reset dfltX and dfltY in restorePosition
Fixes #4948.

This resets `keyman.osk.dfltX` and `keyman.osk.dfltY` in the
`restorePosition()` function, except when the user clicks the pin (or
`true` passed in for `keepDefaultPosition` parameter). It also moves the
grungy `window.event` hack out of the function and into a private
handler specifically for the pin div `onclick`.

I didn't want to reset `dfltX` and `dfltY` when the user clicks on the
pin, because that is a change in behaviour.
2021-04-22 14:44:39 +10:00
Marc Durdin
5ed38180da Update web/source/osk/oskManager.ts
Co-authored-by: Joshua Horton <joshua_horton@sil.org>
2021-04-22 14:44:38 +10:00
Marc Durdin
ffdf71f6ed fix(web): publish restorePosition() function
This makes the `osk.restorePosition()` function public and makes it work
even if the OSK is not presently visible. Also DRY out the repeated
implementation.
2021-04-22 14:44:37 +10:00
jahorton
6ca508a314 fix(web): removes package namespacing from kbd's CSS class 2021-02-24 14:26:10 +07:00
jahorton
a67e26fb1c fix(web): removes stylesheets from unloaded keyboards 2021-01-29 12:54:50 +07:00
jahorton
20ef2b359a change(web): addresses PR comments 2021-01-20 16:06:08 +07:00
Joshua Horton
15947400bb
fix(web): previous commit had accidental recursion in properties 2021-01-19 11:55:49 +07:00
jahorton
29363e0d37 change(web): VisualKeyboard no longer repeatedly references cookie during construction 2021-01-18 12:30:36 +07:00
jahorton
71a89b5531 refactor(web): OSK size now tracked on VisualKeyboard 2021-01-18 11:50:19 +07:00
jahorton
b9437c08e4 chore(web): mild cleanup 2021-01-12 12:53:47 +07:00
jahorton
f20098244a fix(web): fixes cookie/state mismatch 2021-01-12 12:48:19 +07:00
jahorton
360c2cd71c fix(web): osk size & position after focus changes 2021-01-12 12:02:30 +07:00
Marc Durdin
4d07a393b0 fix(web): sporadic blank keyboard on Android
Fixes #3996.

This is a tentative fix: it merely prevents `_Hide` from having any effect when in embedded mode. Tested on Android and could not force any issues.

However, it addresses the symptom and is probably sufficient but does not actually fix the root issue of the problem, which is that the `_Hide` method should never be called for embedded mode, as keyboard visibility is controlled by the host Keyman Engine on the device. Digging out those code paths is a much bigger job, and as the keyboard continues to function correctly if the effect of the hide (opacity=0) is undone by hand using web inspector, I am reasonably confident that this won't break other things.
2020-12-14 09:51:27 +11:00
jahorton
126a15e120 refactor(web/engine): renames DeviceSpec, moves to utils 2020-05-18 08:31:32 +07:00
jahorton
5c709f9468 chore(web/engine): post-rebase cleanup 2020-04-24 14:35:52 +07:00
jahorton
1eed004296 change(web): package rename + patchup 2020-04-24 13:53:39 +07:00
jahorton
373196dded change(web/engine): splits off the core/web/keyboard-processor module 2020-04-24 13:45:04 +07:00
jahorton
7a04baa9a5 change(web/engine): kbdProcessor.core => core.keyboardProcessor 2020-04-06 13:17:32 +07:00
jahorton
86cc033368 refactor(web/engine): supports 'hollow' Keyboards 2020-03-27 23:40:45 +07:00
jahorton
34dbcc36af refactor(web/engine): OSK construction uses Keyboard.layout 2020-03-27 23:00:15 +07:00
jahorton
c03829ffce refactor(web/engine): moves layout classes to keyboards namespace 2020-03-27 17:40:03 +07:00
jahorton
ac179ead84 chore(web/engine): Merge branch 'refactor/web/engine/keyboard-wrapper' into refactor/web/engine/keyboard-wrapper-2 2020-03-24 08:20:35 +07:00
jahorton
8900c06545 refactor(web/engine): Adds keyboard help properties 2020-03-23 12:28:09 +07:00
jahorton
69b309104a refactor(web/engine): moves CJK, RTL, chiral checks to Keyboard wrapper 2020-03-21 21:40:40 +07:00
jahorton
c74d7800a4 refactor(web/engine): more properties 2020-03-21 15:18:56 +07:00
jahorton
a3c9c9b156 refactor(web/engine): KN -> .name, KDU -> .displaysUnderlyingKeys 2020-03-21 14:55:45 +07:00
jahorton
712915e318 refactor(web/engine): .scriptObject['KI'] -> .id property 2020-03-21 14:37:36 +07:00
jahorton
e6788e2ad9 refactor(web/engine): wraps active keyboard 2020-03-21 14:30:33 +07:00
jahorton
08b7cb937a refactor(web/engine): activeKeyboard tracked on Processor 2020-03-20 21:44:25 +07:00
jahorton
30d688521b fix(web): fixes design-mode iframe UI/OSK positioning 2020-03-17 08:38:50 +07:00
Joshua A. Horton
1136a986f7 fix(web): Fixes #2289 2019-11-08 09:27:23 +07:00
Marc Durdin
2ca79c7682 [Web] Tweak positioning of banner and layout of OSK 2019-06-17 12:57:34 +10:00
Darcy Wong
51248da0a2 Allow app to set default banner height 2019-04-22 22:44:21 +07:00
Darcy Wong
242b5ac839 Accommodate dimension for Android device banner
* Also have Android app track the banner (suggestion vs blank) on lexical model change
2019-04-19 06:58:14 +07:00
Darcy Wong
aed2c5232c Merge remote-tracking branch 'origin/master' into android-init-height 2019-04-03 09:48:29 +07:00
Darcy Wong
9dc935be30 Cleanup comments 2019-04-02 23:50:08 +07:00
Darcy Wong
d99bd10a8a Adjust for banner height 2019-04-01 16:08:14 +07:00
Joshua A. Horton
2e14fcecf8 Refactor of SuggestionBanner 2019-03-29 12:30:54 +07:00
Joshua A. Horton
a8e69a3a60 Further fixes BannerManager and OSKManager. 2019-03-22 14:30:33 +07:00
Darcy Wong
1e4d06af5b Revert OSK styling 2019-03-21 15:21:23 +07:00
Darcy Wong
7323a6a110 Adjust suggestion styling
* Use full width
* Remove "extra" blank region
2019-03-21 09:03:12 +07:00
jahorton
ec022372d0 Adds OSKManager resizing on Banner swapping. Probably not robust. 2019-03-20 10:26:25 +07:00
jahorton
7e422acd1e Fixes BannerManager use of ImageBanner. Issue: mobile OSK not resizing 2019-03-20 10:07:16 +07:00
jahorton
775afa0ba4 Merge branch 'web-suggestion-ui' into web-banner-manager 2019-03-20 09:37:03 +07:00
Joshua A. Horton
b00e47fdfe Start of the BannerManager class. 2019-03-19 15:48:41 +07:00
Darcy Wong
f79cf355d5 More refactoring of banner
* add more getter/setters
* update how ImageBanner can update the image
2019-03-19 13:58:43 +07:00
Darcy Wong
904da4406a Reorder height calculations
Per review comment,  change `getKeyboardHeight` to not use banner height (revert it to original `getHeight` calculation)
2019-03-19 08:53:44 +07:00
Darcy Wong
5d3c5504bb Cleanup
* Separate `getBannerHeight`, `getKeyboardHeight`, and `get Height`
* Add typing to banner height
2019-03-19 08:43:50 +07:00