Commit graph

7 commits

Author SHA1 Message Date
darcywong00
cdd75ccf5f Refactor longpress logic so key text is not confused with key code
A tchad keyboard has a diacritic rule that converts `=` (U_003D) into a combining macron (U_0304).
A longpress on `»` (U_00BB) was inadvertently triggering the diacritic rule, and outputting the macron.

The longpress code in KMEA and KMW needs to be refactored so they dont confuse key text (U_00BB is decimal 187) with underlying keyCodes (`=` is keyCode 187).

- fix KMW executePopupKey so key code is dictionary lookup instead of parsing the keyID.
- clean up JS call to executePopupKey since it only uses the keyID
2017-10-12 14:21:29 +07:00
darcywong00
f06c727e51 Refactor longpress text when it's generated by Id
Currently on the touch layout, longpress for K_SPACE causes the app to crash because it is attempting to parse `K_SPACE` as an int for generating the longpress text.

- Clean up when key text is empty how it is parsed from Id
-Change Unicode hex string delimiter from `,0x` to `\\u` which makes it easier to read `executePopupKey()` in the logs.
2017-10-09 09:04:30 +07:00
darcywong00
3a30d23684 Clean up TestHarness
Fix onKeyboardChanged signature
2017-10-04 10:33:16 +07:00
darcywong00
d66f52b350 Update Samples and Tests projects for handler API change
Updates to new onKeyboardChanged signature

Also incorporated external keyboard support to KMSample2
2017-10-04 10:33:16 +07:00
darcywong00
f9f3dc7449 Document bitmasks and undo getActiveKeyboard refactor
* Document shift states and lock states in kmembedded.js, and standardize `lstates` parameter name
* Leave getActiveKeyboard() refactor as a TODO
2017-10-04 10:33:16 +07:00
darcywong00
353f09084e Change chirality test app to keyboardHarness
Per review comments
* Rename chirality to keyboardHarness
* Change namespace to com.keyman.android.tests.keyboardHarness
* Add readme.md for info
2017-10-04 10:33:16 +07:00
darcywong00
3a0ee92381 Move test chirality keyboard to new Tests/Chirality project
-Update KMEA to copy keyman-engine.aar to Tests/ for future test apps to consume.
2017-10-04 10:33:16 +07:00