Commit graph

1301 commits

Author SHA1 Message Date
Steven R. Loomis
ae45295dc6 Merge remote-tracking branch 'upstream/master' into chore/merge-master-a17s5-REDO-epic-ldml 2023-02-03 16:53:35 -06:00
Marc Durdin
224402b9cc
Merge pull request #8151 from keymanapp/feat/developer/8119-duplicated-language-codes
feat(developer): check for duplicated language codes in package editor and compiler
2023-02-03 12:30:11 +11:00
Marc Durdin
8ee8325c74 feat(developer): check for duplicated language codes in package editor and compiler
Fixes #8119.
2023-02-02 15:06:15 +07:00
Joshua A. Horton
ede1068d51 chore(web): Merge branch 'master' into change/web/reorg-source-src-reorg 2023-02-02 09:18:46 +07:00
Joshua A. Horton
61a789a9ca chore(web): Merge branch 'master' into chore/web/top-level-build-script-rework 2023-02-02 08:58:44 +07:00
Steven R. Loomis
72bde8bd11 fix(developer) todo cleanup, common code, tests 🙀
- fixup import

For: #8069
2023-01-31 18:30:05 -06:00
Steven R. Loomis
8c940292b1 fix(developer) todo cleanup, common code, tests 🙀
- move some shared code out of key2/keys and into util.ts
- add unit tests
- delete a null test-base.ts

For: #8069
2023-01-31 16:06:49 -06:00
Marc Durdin
17359dbf53 chore(developer): kmcmpdll debug src path
Adds the src build path in for kmcmpdll.dll for debugging purposes, when
running from any subdirectory of the KEYMAN_ROOT path.
2023-01-31 15:56:30 +07:00
Steven R. Loomis
bbd850c03b feat(common): ldml: imports: use cldr version from constants 🙀
- common: more robustness in importing.
- build: don't copy imports to kmc which doesn't need it

supports #7964
2023-01-27 12:45:00 -06:00
Steven R. Loomis
e5c5fd025e feat(common): ldml: change importer to use callbacks for fs 🙀
supports #7964
2023-01-27 12:45:00 -06:00
Steven R. Loomis
727056cb87 feat(developer): ldml support implied keys 🙀
- automatically add the import

Fixes: #7964

Apply suggestions from code review

Co-authored-by: Marc Durdin <marc@durdin.net>
2023-01-27 12:41:39 -06:00
Steven R. Loomis
6fd2e418bc feat(common): ldml implement imports 🙀
add tests:
- k_100, k_101, k_102 all failed for different reasons.
- rename test cases from 'fail' to 'keytest' since they don't fail anymore

For: #7401

- update k101_fail.xml / k102_fail.xml to use an implied import
- update build.sh to bring over the imports from CLDR

For #7534
2023-01-27 12:40:22 -06:00
Steven R. Loomis
5a4b44f2d7 chore(common): move CompilerEvent, CompilerCallbacks into types 🙀
- make CompilerCallbacks an interface
- concrete implementations for Node (CLI) and for Testing
- change loadFile to take a string|URL 🙀

supports #7964
2023-01-27 12:37:54 -06:00
Steven R. Loomis
592d4b0b5e
Merge pull request #7969 from keymanapp/feat/developer-7965-epic-ldml-spacebar
fix(common): update USVirtualKeyMap to actually be US🙀
2023-01-26 17:02:57 -06:00
Steven R. Loomis
70b351347a
Merge pull request #7570 from keymanapp/fix/core/7569-unicode-escaping-epic-ldml
fix(developer): ldml: fix for unescaping Unicode values 🙀
2023-01-26 14:29:17 -06:00
Steven R. Loomis
1d7e0d1922
Merge pull request #8030 from keymanapp/spec/core/7986-hardware-enum-epic-ldml
spec(core): ldml: make hardware be an enum 🙀
2023-01-26 14:05:26 -06:00
Steven R. Loomis
2f5459b929 fix(developer): test fix 🙀
- test case had two keys on the 'spacebar' row

For: #7965
2023-01-26 13:49:49 -06:00
Steven R. Loomis
2b3cedd5d4 fix(core): update escaping per review comment 🙀
- escape an emoji in source code

#7569
2023-01-26 13:13:36 -06:00
Steven R. Loomis
2af96fdb5b fix(developer): update error messages for layr 🙀
- per review notes, change from InvalidFile to specific errors

#7986
2023-01-26 12:38:46 -06:00
Steven R. Loomis
6500cda605 chore(developer): ldml layr: update tests, new utility for section tests 🙀
- updates from review comments
- new testCompilationCases to automate checking
2023-01-26 12:29:20 -06:00
Marc Durdin
067028cec2 chore: revise tag variable name to VERSION_GIT_TAG
Introduce new $VERSION_GIT_TAG environment variable, and update all
references to release@version in all projects to use the new variable.
2023-01-21 17:02:50 +07:00
Steven R. Loomis
e63745baff chore(coverage): ldml setup for visual code coverage 🙀
- generate coverage/lcov.info files in several places that were already using c8
- change kmc-package's 'npm test' to include coverage, leave 'coverage' as alias
- gitignore the lcov files

Fixes #8060
2023-01-20 11:22:44 -06:00
Steven R. Loomis
42fdba4bd1 chore(core): ldml: add unit tests 🙀
- for layer invalid cases

For: #7986
2023-01-19 22:09:03 -06:00
Steven R. Loomis
666d71f342 chore(core): ldml: update unit tests 🙀
- add hardware="us"

For: #7986
2023-01-19 21:36:04 -06:00
Steven R. Loomis
d7ce2191bf feat(core): ldml: make hardware be an enum 🙀
For: #7986
2023-01-19 12:24:47 -06:00
Joshua A. Horton
1020c0688c chore(web): Merge branch 'master' into chore/web/top-level-build-script-rework 2023-01-18 08:24:10 +07:00
Marc Durdin
34ece2182d fix(common): update sentry release identifiers to support semver
Fixes #7895.

This should mean that Sentry reports start to track semantic versions. I
have reviewed each project and I _think_ I've captured all the locations
where we need to construct release identifiers. Note that one of them
was fixed from a plain version number.

Docs on release format: https://docs.sentry.io/platforms/node/guides/serverless-cloud/configuration/releases/#bind-the-version
2023-01-17 17:04:24 +07:00
Steven R. Loomis
cbb5af2ae7 feat(core): ldml: Drop padding: common,core 🙀
- also add some checking in the builder
- add a Constants.str_section_id() for debugging
- update basic.txt

For: #7987
2023-01-09 16:35:47 -06:00
Steven R. Loomis
e4799d2498
Merge pull request #7956 from keymanapp/fix/core/maqtugha
fix(core): ldml: fix spelling of maqtugħa 🙀
2023-01-07 22:54:48 -06:00
Steven R. Loomis
30865fbb1b Merge remote-tracking branch 'upstream/feature-ldml' into fix/core/7569-unicode-escaping-epic-ldml 2023-01-07 22:38:42 -06:00
Steven R. Loomis
7f92eb3b84 Merge branch 'feature-ldml' into fix/core/7569-unicode-escaping-epic-ldml 2023-01-07 22:36:32 -06:00
Steven R. Loomis
d552a46104
Merge pull request #7630 from keymanapp/feat/core/7532-layr-epic-ldml 2023-01-06 17:40:06 -06:00
Steven R. Loomis
9f8b0352a2 fix(developer): ldml: updates per code review 🙀
- …/key2/flicks.xml deleted empty test file
- test-key2.ts: reinstated an assert

For #7532
2023-01-06 15:51:56 -06:00
Steven R. Loomis
564f98cc30
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-01-06 11:46:17 -06:00
Steven R. Loomis
b1191bb69e fix(developer): ldml: add escaping to key2 section 🙀
- also add functions to the ListItem class
- also fix a bug in ListItem.toString()
- add test cases

Fixes #7569
2023-01-05 16:02:08 -06:00
Steven R. Loomis
d68999e0ef fix(common): escaping: only unescape on some attributes 🙀
- keys:  key.to
- disp: display.to, display.display
- disp: displayOptions.baseCharacter

The rest will have to wait for downstream of PR #7630

For: #7569
2023-01-05 13:46:07 -06:00
Steven R. Loomis
1a8ee0b07d fix(developer): ldml: add escaping 🙀
- common util unescapeString with its own tests
- add a test case using the disp element

Fixes #7569
2023-01-05 13:46:04 -06:00
Steven R. Loomis
42b4ffe40d
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-01-04 10:14:04 -06:00
Steven R. Loomis
015e7185a6 chore: merge master into feature-ldml 2023-01-02 13:44:21 -06:00
Steven R. Loomis
f7f40a2bb8 fix(core): ldml: fix spelling of maqtugħa 🙀
- maqtua should be maqtugħa (cut) but spelled as maqtugha where used as an NMTOKEN
2022-12-30 17:01:48 -06:00
Steven R. Loomis
ac461e97b8 fix(developer): ldml: merge fixes: fix scope of JSZip in the test 🙀
- JSZip() needs to be in an inner function otherwise the single zip grows and grows
- also don't read the kps version when building the kmp

For #7042
2022-12-22 14:31:49 -06:00
Steven R. Loomis
ec9a5952fc fix(developer): ldml: merge fixes: fix scope of JSZip 🙀
- JSZip() needs to be in an inner function otherwise the single zip grows and grows

For #7042
2022-12-22 14:20:39 -06:00
Steven R. Loomis
80b764174a
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-12-22 13:56:08 -06:00
Steven R. Loomis
05656ac499 feat(core): ldml: fix off-by-one on section count 🙀
- yes, sect was counting itself. Too much automation!
- disable layr/key2/list loading in C++ for now

For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
2022-12-22 13:12:08 -06:00
Marc Durdin
905fcd1913
chore: Apply review comments 2022-12-22 08:07:42 +11:00
Steven R. Loomis
343f234a8e feat(core): ldml: updates to basic.txt and builders 🙀
- strs and ALL TESTS pass

For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
2022-12-20 19:16:41 -06:00
Steven R. Loomis
63fa53a028 feat(core): ldml: updates to basic.txt and builders 🙀
- layr now passes comparison

For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
2022-12-20 17:05:29 -06:00
Steven R. Loomis
47a9d16be9 chore(core): updates to kmc-package after merge 🙀
Try to get this to pass tests again

test data:
- put withfolders.qaa.sencoten.model in the right spot
- add kmp.json as it seems to be included
- remove copyLocation: 0 as kmp-compiler drops it

test-package-compiler:
- improve the jszip-contents test
- assume kmp.json is included in the zip
- bug: withfolders.qaa.sencoten.model.js and example.qaa.sencoten.model.js show up in an unrelated KPS. But, include for now.

KmpCompiler
- attempt to pull version from kps.info.version: comments to the contrary, some kps files do not have kmxes.
- map backslash to forward slash so that relative path resolution works

For #7042
2022-12-19 19:50:19 -06:00
Marc Durdin
74f0fe2d08 fix(developer): force ES3 code generation for LMs
Fixes #7926.

Android 5.0 (Chrome 37) only supports ES3. Thus, we should transpile our
lexical models to ES3 rather than ES2015, for now at least.

For example, this forces constructs such as `const` to be replaced with
`var`.
2022-12-19 14:48:05 +11:00
Steven R. Loomis
b036fc5840 feat(core): ldml: basic: updates to basic.txt for layr 🙀
- key2 now passes!
- starting on layr

For feat(developer): ldml: include all LDML data in kmx+ 🙀 #753
2022-12-16 17:53:14 -06:00