Commit graph

33476 commits

Author SHA1 Message Date
Joshua Horton
4e4fbc174a Merge branch 'chore/web/replace-kmwfromcharcode' into chore/web/add-string-handling-unit-tests 2025-04-30 08:33:02 +07:00
Joshua Horton
efb14e7b2a Merge branch 'change/web/lint-web-utils' into chore/web/replace-kmwfromcharcode 2025-04-30 08:32:09 +07:00
Joshua Horton
80f95d979a change(web): lint engine/common/web-utils
Does not lint kmwstring.ts, as that has an existing rework.  A separate PR will be added as a followup to the refactor PR (#13726) to handle it.
2025-04-30 08:30:06 +07:00
Marc Durdin
f8917d2454 maint(common): cleanup meson versioning
* Adds `VERSION_WITH_TAG` variable to standard.meson.build
* Consistently uses `file('VERSION.md')` to retrieve version number

Note that VERSION_WITH_TAG is not yet used but should be used for
version tagged files later.
2025-04-30 08:23:05 +07:00
Joshua Horton
efe8ed39cc Merge branch 'master' into chore/web/replace-kmwfromcharcode 2025-04-30 08:22:43 +07:00
Joshua Horton
d9bddee90e
Merge pull request #13714 from keymanapp/fix/web/web-util-unit-testing
fix(web): reconnect unit tests for low-level web utility classes/methods 🧶
2025-04-30 08:21:20 +07:00
Joshua Horton
56dbe78281
Merge pull request #13787 from keymanapp/change/web/add-kmw-linting
change(web): enable linting for Keyman Engine for Web modules
2025-04-30 08:17:34 +07:00
Marc Durdin
7a56017f5b maint(core): batch build kmx in tests for performance
Build all the .kmx files used for kmn and ldml unit tests in batch
rather than one at a time. The ldml-test-data builds remain unbatched
for now (and are visibly slow!).

Fixes: #13495
2025-04-30 06:02:59 +07:00
Keyman Server
dc6f661b67
Merge pull request #13794 from keymanapp/auto/version-master-19.0.29
auto: increment master version to 19.0.29
2025-04-29 11:02:24 -07:00
Keyman Build Agent
9e9153184e auto: increment master version to 19.0.29 2025-04-29 14:01:52 -04:00
Eberhard Beilharz
2ff9e309fa
chore(common): allow to run tests in virtual environment
This changes the shebang at the top of the file to allow use Python
from a virtual environment instead of hard-coding the path. This might
not be strictly necessary, but reduces confusion and doesn't hurt.
2025-04-29 19:20:49 +02:00
Eberhard Beilharz
0f8999a736
fix(common): fix configure step in check-markdown
The check-markdown tool gets called as part of a TC build. The
configure action in `build.sh` will select the correct node version
and set the necessary environment variables. However, previously this
failed because `${KEYMAN_ROOT}/node_modules` might already exist even
though we didn't configure check-markdown before.

This change checks a local directory as output of the configure action
and thus allows to build on a Noble based TC agent.
2025-04-29 11:54:39 +02:00
Eberhard Beilharz
b7649defd0
chore(common): override check when running on TC
This change overrides a check added in Ubuntu 24.04+ that prevents
mixing Python packages installed through apt and through pip. This
allows to install the necessary Python package for TC which isn't
available as Debian package. This change allows builds on Ubuntu 24.04
based TC agents.
2025-04-29 11:54:33 +02:00
Eberhard Beilharz
82cb949289
Merge pull request #13778 from keymanapp/change/linux/linkissue 2025-04-29 09:03:06 +02:00
Joshua Horton
94944b0dff chore: increase linter strictness
Fixes: #13776
2025-04-29 12:10:59 +07:00
Joshua Horton
8f04951c80 chore(web): enable web/ linting 2025-04-29 12:01:42 +07:00
Joshua Horton
d6579495f8 change(web): address recorder-tool linter errors 2025-04-29 11:54:44 +07:00
Joshua Horton
4762429e96 change(web): address app/ui linter errors 2025-04-29 11:40:19 +07:00
Joshua Horton
da138b098d change(web): address app/browser linter errors 2025-04-29 11:38:08 +07:00
Joshua Horton
241f9655f2 change(web): address app/webview linter errors 2025-04-29 11:32:35 +07:00
Joshua Horton
19021f1419 change(web): address engine/main linter errors 2025-04-29 11:30:30 +07:00
Joshua Horton
0288048340 change(web): address engine/keyboard-storage linter errors 2025-04-29 11:29:16 +07:00
Joshua Horton
7baf8d0b69 change(web): address engine/attachment linter errors 2025-04-29 11:28:28 +07:00
Marc Durdin
42cbe1f988
Merge pull request #13780 from keymanapp/maint/common/labels
chore(common): rename `chore` GH label to `maint`
2025-04-29 11:16:14 +07:00
Marc Durdin
8b3c2a710a chore: add maint to CONTRIBUTING.md 2025-04-29 11:15:55 +07:00
Darcy Wong
86740c9a91 fix(android): Show Dialog instead of Toast if package missing languages
If a keyboard package is missing associated languages, show an error dialog instead of Toast notification., This way we don't clutter Sentry with noise.

Fixes: #13782

Fixes: KEYMAN-ANDROID-251
2025-04-29 11:11:10 +07:00
Marc Durdin
2dc14c8f7a
Merge pull request #13765 from keymanapp/chore/labeler-for-19-round-two
chore: additional tweaks to scopes/labels
2025-04-29 11:07:50 +07:00
Joshua Horton
f839810cc0 change(web): address engine/osk/gesture-processor linter errors 2025-04-29 11:03:59 +07:00
Joshua Horton
f6134244f2 change(web): address engine/osk linter errors 2025-04-29 11:02:23 +07:00
Joshua Horton
6ba37bc61b change(web): address engine/interfaces linter errors 2025-04-29 10:57:52 +07:00
Joshua Horton
f1ca263da2 change(web): address engine/events linter errors 2025-04-29 10:57:28 +07:00
Joshua Horton
63f6216774 change(web): address engine/element-wrappers linter errors 2025-04-29 10:55:30 +07:00
Joshua Horton
db6b61e8fc change(web): address engine/js-processor linter errors 2025-04-29 10:54:37 +07:00
Joshua Horton
7b1cfe94ff change(web): address engine/dom-utils linting errors 2025-04-29 10:52:35 +07:00
Joshua Horton
e601d59b59 change(web): replace USVString with string in predictive-text engine
Fixes: #12046

It was only ever an alias (for `string`!) for its intended use, with actual `USVString` typing being unavailable in the browser.
2025-04-29 10:47:20 +07:00
Joshua Horton
43eb195ee1 fix(web): patch up detected behavior change 2025-04-29 10:19:38 +07:00
Joshua Horton
e8125898e5 Merge branch 'chore/web/add-string-handling-unit-tests' into refactor/web/eliminate-kmwstring-side-effects 2025-04-29 10:18:54 +07:00
Joshua Horton
b3633ec4d0 feat(web): add additional edge-case unit tests
Co-authored-by: Eberhard Beilharz <eberhard_beilharz@sil.org>
2025-04-29 10:12:10 +07:00
Darcy Wong
caa19fc8e8
Merge pull request #13775 from keymanapp/chore/gha-crowdin
chore(common): Update dependencies in crowdin GitHub action
2025-04-29 06:43:24 +07:00
Keyman Server
136a377c1d
Merge pull request #13781 from keymanapp/auto/version-master-19.0.28
auto: increment master version to 19.0.28
2025-04-28 11:01:48 -07:00
Keyman Build Agent
7371c2378b auto: increment master version to 19.0.28 2025-04-28 14:01:18 -04:00
Eberhard Beilharz
8a37b5f5b0
chore(common): rename chore GH label to maint
During the "M3: Maintenance Sprints" session of the April 2025 planning
conference we discussed that we'd rename the `chore` GH label to `maint`.

However, this change doesn't remove the existing `chore` label because
that is also used for merge commits.
2025-04-28 18:30:54 +02:00
Eberhard Beilharz
2134d8a466
change(linux): add link to issue 2025-04-28 16:42:46 +02:00
Darcy Wong
809e7bb66e chore(common): Update dependencies in crowdin GitHub action 2025-04-28 16:42:49 +07:00
Darcy Wong
40ae5ed2f5 fix(android): Revert ci build option. To deprecate in 20.0 2025-04-28 13:49:27 +07:00
Darcy Wong
ff1fb14768 fix(android/engine): Use build_is_ci_build for test action 2025-04-28 13:49:01 +07:00
Joshua Horton
cf85aca104 fix(ios): restore keyboard-scale settings for older, still-supported iOS devices
Fixes: #13769
Fixes: KEYMAN-IOS-JC
Fixes: KEYMAN-IOS-JG
Fixes: KEYMAN-IOS-JH
Fixes: KEYMAN-IOS-JJ
Fixes: KEYMAN-IOS-JY
Fixes: KEYMAN-IOS-JS
2025-04-28 13:26:06 +07:00
Joshua Horton
a701b97888 fix(web): add robustness for bad touch-layout fontsize specs
Fixes: #13766
Fixes: KEYMAN-WEB-QX

It seems that at some point, Developer has been compiling raw "12" values in the touch-layout JSON as a numeric 12 for the fontsize field.  This clearly happened for the inuktitut_pirurvik keyboard; we should also inspect urdu_phonetic, which has the same raw "12".

This change ensures that Web can handle this case without spewing tons of warning/error messages.  It also adds error-logging to help with diagnosis for any related issue in the future.
2025-04-28 13:25:28 +07:00
Darcy Wong
b9f1f51a33 chore(android): Use builder_is_ci_build rather than --ci flag 2025-04-28 10:42:52 +07:00
Marc Durdin
b8cef28538 chore: additional tweaks to scopes/labels 2025-04-28 09:21:12 +07:00