Commit graph

1254 commits

Author SHA1 Message Date
Joshua Horton
a783fbc902 maint(web): also fixes worker-thread inspectable browser test call 2025-05-13 12:44:26 +07:00
Joshua Horton
14dd36de4d fix(web): inspectable test-script mode should not be auto-enabled in local-env tests
This is a followup to the recent #13827, which automatically adds --debug to local-environment builds.  For web/ test scripts involving browser-based scripts, that same flag had been used to enable an _inspectable_ test mode that doesn't auto-return, which doesn't match the semantics of --debug for build configurations.

To rectify this, those scripts now have their --debug option renamed to --inspect, allowing them to be optionally turned on, but not automatically enabled.

Test-bot: skip
2025-05-13 12:38:47 +07:00
Joshua Horton
e9274d9874 change(web): permit flick cancellation
Fixes: #10876

This change blocks key output while a flick is in a "reset" state.  If the flick is in a direction-locked state, key output still results - be it the base key (if not slid far enough) or a target flick key.
2025-05-13 08:41:53 +07:00
Joshua Horton
e8630c2bf2 Merge branch 'master' into fix/web/flick-cancel-during-reset 2025-05-13 08:27:26 +07:00
Joshua Horton
dd563e8a11 fix(web): sustain active batched-layout mode when keyboard is switched
Fixes: #13859
Fixes: KEYMAN-WEB-R4
2025-05-08 13:56:23 +07:00
Joshua Horton
7d5a83633d fix(web): fix var declaration affected by linter strictness + length-style fix
Test-bot: skip
2025-05-06 11:29:31 +07:00
Joshua Horton
c3286ce4e1
Merge pull request #13774 from keymanapp/fix/web/layout-fontsize-robustness
fix(web): add robustness for bad touch-layout fontsize specs
2025-05-06 09:46:17 +07:00
Joshua Horton
9976af6f6c
docs(web): tweak comment per review
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
2025-05-06 08:18:42 +07:00
Joshua Horton
76da8f4e2a
Merge pull request #13805 from keymanapp/fix/web/gesture-fixture-extraction
fix(web): fix extraction of gesture-engine fixture used in DOM-based unit tests
2025-05-06 08:17:03 +07:00
Joshua Horton
b02f1d18bc
Merge pull request #13800 from keymanapp/change/web/lint-kmwstring
change(web): lint kmwstring web-utility 🧶
2025-05-06 08:16:56 +07:00
Joshua Horton
d606563a8c
Merge pull request #13820 from keymanapp/maint/web/simplify-worker-main-test-script
maint(web): simplify worker-main test.sh
2025-05-06 08:16:47 +07:00
Joshua Horton
1438704ee0
Merge pull request #13819 from keymanapp/maint/web/use-builder_is_ci_build
chore(web): replace --ci flag with builder_is_ci_build
2025-05-06 08:16:37 +07:00
Joshua Horton
e382bf45ce
Merge pull request #13785 from keymanapp/change/web/drop-usvstring-alias
change(web): replace USVString with string in predictive-text engine
2025-05-06 08:16:28 +07:00
Joshua Horton
2db4c16751
Merge pull request #13726 from keymanapp/refactor/web/eliminate-kmwstring-side-effects
refactor(web): refactor string-helper library to eliminate its module side-effect 🧶
2025-05-05 15:05:11 +07:00
Joshua Horton
18ffdef6ce
Merge pull request #13719 from keymanapp/chore/web/add-string-handling-unit-tests
chore(web): add unit tests for SMP-aware string-handling helper methods 🧶
2025-05-05 15:04:58 +07:00
Joshua Horton
f86ee91bac
Merge pull request #13716 from keymanapp/chore/web/replace-kmwfromcharcode
chore(web): replace kmwFromCharCode with its ES6 equivalent 🧶
2025-05-05 15:04:45 +07:00
Joshua Horton
eb5fefa4b4
Merge pull request #13797 from keymanapp/change/web/lint-web-utils
change(web): lint engine/common/web-utils 🧶
2025-05-05 15:04:30 +07:00
Joshua Horton
cf0b83081b change(web): use pt-style sizing for unitless touch-layout fontsizes 2025-05-02 12:49:17 +07:00
Joshua Horton
a0ce7d2934
change(web): apply suggestion from PR review
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
2025-05-02 11:58:33 +07:00
Joshua Horton
209e4e579e
Merge pull request #13807 from keymanapp/maint/disconnect-pred-text-only-ci-config
maint(web): merge LMLayer CI build config with standard Web CI build config
2025-05-02 09:55:37 +07:00
Joshua Horton
b6fbf165dd maint(web): simplify worker-main test.sh 2025-05-02 09:52:43 +07:00
Joshua Horton
cb5e3035a7 chore(web): replace --ci flag with builder_is_ci_build
Fixes: #12640
2025-05-02 09:39:39 +07:00
Joshua Horton
644837d47f Merge branch 'master' into fix/web/gesture-fixture-extraction 2025-05-02 08:25:42 +07:00
Joshua Horton
dfe3de4ce1
chore: fix indentation in worker-main/build.sh
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-05-02 08:13:30 +07:00
Joshua Horton
14657c3894 maint(web): run LMLayer tests during standard Web module tests
Related-to: #12872

Test-bot: skip
2025-04-30 15:06:11 +07:00
Joshua Horton
e5b9118356 chore(web): ensure gesture-recognizer unit tests run 2025-04-30 12:22:31 +07:00
Joshua Horton
dbbb6fd8bc fix(web): fix extraction of gesture-engine fixture used in DOM-based unit tests
Test-bot: skip
2025-04-30 12:20:35 +07:00
Joshua Horton
843221c466 chore(web): improve clean actions
A few cases weren't properly handled, while a few others simply weren't called by the top-level script.  This PR seeks to make the top-level clean action able to fully clean all built components, perhaps save for sample and test pages.

Test-bot: skip
2025-04-30 12:18:59 +07:00
Joshua Horton
de0eaa411b change(web): lint kmwstring web-utility
This removes the exception in #13797 for KMWString, properly including the newly-refactored code in linting as well.
2025-04-30 09:01:47 +07:00
Joshua Horton
16fb2fef49 Merge branch 'chore/web/add-string-handling-unit-tests' into refactor/web/eliminate-kmwstring-side-effects 2025-04-30 08:57:36 +07:00
Joshua Horton
7217d7cf72 feat(web): add more indexOf, lastIndexOf unit test statements
Co-authored-by: Eberhard Beilharz <eb1@sil.org>
2025-04-30 08:42:27 +07:00
Joshua Horton
4e4fbc174a Merge branch 'chore/web/replace-kmwfromcharcode' into chore/web/add-string-handling-unit-tests 2025-04-30 08:33:02 +07:00
Joshua Horton
efb14e7b2a Merge branch 'change/web/lint-web-utils' into chore/web/replace-kmwfromcharcode 2025-04-30 08:32:09 +07:00
Joshua Horton
80f95d979a change(web): lint engine/common/web-utils
Does not lint kmwstring.ts, as that has an existing rework.  A separate PR will be added as a followup to the refactor PR (#13726) to handle it.
2025-04-30 08:30:06 +07:00
Joshua Horton
efe8ed39cc Merge branch 'master' into chore/web/replace-kmwfromcharcode 2025-04-30 08:22:43 +07:00
Joshua Horton
19021f1419 change(web): address engine/main linter errors 2025-04-29 11:30:30 +07:00
Joshua Horton
0288048340 change(web): address engine/keyboard-storage linter errors 2025-04-29 11:29:16 +07:00
Joshua Horton
7baf8d0b69 change(web): address engine/attachment linter errors 2025-04-29 11:28:28 +07:00
Joshua Horton
f839810cc0 change(web): address engine/osk/gesture-processor linter errors 2025-04-29 11:03:59 +07:00
Joshua Horton
f6134244f2 change(web): address engine/osk linter errors 2025-04-29 11:02:23 +07:00
Joshua Horton
6ba37bc61b change(web): address engine/interfaces linter errors 2025-04-29 10:57:52 +07:00
Joshua Horton
f1ca263da2 change(web): address engine/events linter errors 2025-04-29 10:57:28 +07:00
Joshua Horton
63f6216774 change(web): address engine/element-wrappers linter errors 2025-04-29 10:55:30 +07:00
Joshua Horton
db6b61e8fc change(web): address engine/js-processor linter errors 2025-04-29 10:54:37 +07:00
Joshua Horton
7b1cfe94ff change(web): address engine/dom-utils linting errors 2025-04-29 10:52:35 +07:00
Joshua Horton
e601d59b59 change(web): replace USVString with string in predictive-text engine
Fixes: #12046

It was only ever an alias (for `string`!) for its intended use, with actual `USVString` typing being unavailable in the browser.
2025-04-29 10:47:20 +07:00
Joshua Horton
43eb195ee1 fix(web): patch up detected behavior change 2025-04-29 10:19:38 +07:00
Joshua Horton
e8125898e5 Merge branch 'chore/web/add-string-handling-unit-tests' into refactor/web/eliminate-kmwstring-side-effects 2025-04-29 10:18:54 +07:00
Joshua Horton
b3633ec4d0 feat(web): add additional edge-case unit tests
Co-authored-by: Eberhard Beilharz <eberhard_beilharz@sil.org>
2025-04-29 10:12:10 +07:00
Joshua Horton
a701b97888 fix(web): add robustness for bad touch-layout fontsize specs
Fixes: #13766
Fixes: KEYMAN-WEB-QX

It seems that at some point, Developer has been compiling raw "12" values in the touch-layout JSON as a numeric 12 for the fontsize field.  This clearly happened for the inuktitut_pirurvik keyboard; we should also inspect urdu_phonetic, which has the same raw "12".

This change ensures that Web can handle this case without spewing tons of warning/error messages.  It also adds error-logging to help with diagnosis for any related issue in the future.
2025-04-28 13:25:28 +07:00