Commit graph

5172 commits

Author SHA1 Message Date
Eberhard Beilharz
d307051836
Merge pull request #13854 from keymanapp/maint/common/versionvars
Previously the builder scripts defined a readonly `VERSION` environment variable for the Keyman version. That caused problems when another (external) script tried to define a `VERSION` variable. We encountered this problem when trying to move the TC build steps of a configuration into a single script (#13399) when we tried to source `~/.nvm/nvm.sh`.

This change uses a Keyman specific prefix for the version variables and renames `VERSION` → `KEYMAN_VERSION` etc. as well as `TIER` → `KEYMAN_TIER`. Unfortunately these variables are used in a lot of places, so this turned out to be a bit of a yak shave.
2025-05-12 08:58:19 +02:00
Joshua Horton
5d00ccdd53
Merge pull request #13860 from keymanapp/fix/web/sustain-batched-layout-on-swap
fix(web): sustain active batched-layout mode when keyboard is switched
2025-05-08 15:49:15 +07:00
Joshua Horton
dd563e8a11 fix(web): sustain active batched-layout mode when keyboard is switched
Fixes: #13859
Fixes: KEYMAN-WEB-R4
2025-05-08 13:56:23 +07:00
Eberhard Beilharz
4d81589f48
maint(common): use unique names for Keyman version variables
Previously the builder scripts defined a readonly `VERSION` environment
variable for the Keyman version. That caused problems when another
(external) script tried to define a `VERSION` variable. We encountered
this problem when trying to move the TC build steps of a configuration
into a single script (#13399) when we tried to source `~/.nvm/nvm.sh`.

This change uses a Keyman specific prefix for the version variables and
renames `VERSION` → `KEYMAN_VERSION` etc. Unfortunately these variables
are used in a lot of places, so this turned out to be a bit of a yak
shave.

Test-bot: skip
2025-05-07 18:46:51 +02:00
Eberhard Beilharz
ad3747cede
Merge pull request #13844 from keymanapp/maint/common/tcvars
This change makes use of the new builder script function to detect if the script is running on TeamCity. Also use the
`TEAMCITY_GIT_PATH` environment consistently to check if we're running on TC.
2025-05-07 11:06:06 +02:00
Joshua Horton
b8db20fddd
Merge pull request #13759 from keymanapp/docs/web/keystroke-lifecycle
docs(web): add a Web engine keystroke lifecycle internal doc
2025-05-07 10:18:08 +07:00
Joshua Horton
ea88aaeb3e
docs(web): apply suggestions from code review
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
2025-05-07 08:25:52 +07:00
Eberhard Beilharz
460de65f0d
maint(common): use same TC variable everywhere
Standardize on `TEAMCITY_GIT_PATH` environment variable to detect
if we're running on TeamCity.

Test-bot: skip
2025-05-06 17:42:25 +02:00
Joshua Horton
7d5a83633d fix(web): fix var declaration affected by linter strictness + length-style fix
Test-bot: skip
2025-05-06 11:29:31 +07:00
Joshua Horton
c3286ce4e1
Merge pull request #13774 from keymanapp/fix/web/layout-fontsize-robustness
fix(web): add robustness for bad touch-layout fontsize specs
2025-05-06 09:46:17 +07:00
Joshua Horton
9976af6f6c
docs(web): tweak comment per review
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
2025-05-06 08:18:42 +07:00
Joshua Horton
76da8f4e2a
Merge pull request #13805 from keymanapp/fix/web/gesture-fixture-extraction
fix(web): fix extraction of gesture-engine fixture used in DOM-based unit tests
2025-05-06 08:17:03 +07:00
Joshua Horton
b02f1d18bc
Merge pull request #13800 from keymanapp/change/web/lint-kmwstring
change(web): lint kmwstring web-utility 🧶
2025-05-06 08:16:56 +07:00
Joshua Horton
d606563a8c
Merge pull request #13820 from keymanapp/maint/web/simplify-worker-main-test-script
maint(web): simplify worker-main test.sh
2025-05-06 08:16:47 +07:00
Joshua Horton
1438704ee0
Merge pull request #13819 from keymanapp/maint/web/use-builder_is_ci_build
chore(web): replace --ci flag with builder_is_ci_build
2025-05-06 08:16:37 +07:00
Joshua Horton
e382bf45ce
Merge pull request #13785 from keymanapp/change/web/drop-usvstring-alias
change(web): replace USVString with string in predictive-text engine
2025-05-06 08:16:28 +07:00
Joshua Horton
2db4c16751
Merge pull request #13726 from keymanapp/refactor/web/eliminate-kmwstring-side-effects
refactor(web): refactor string-helper library to eliminate its module side-effect 🧶
2025-05-05 15:05:11 +07:00
Joshua Horton
18ffdef6ce
Merge pull request #13719 from keymanapp/chore/web/add-string-handling-unit-tests
chore(web): add unit tests for SMP-aware string-handling helper methods 🧶
2025-05-05 15:04:58 +07:00
Joshua Horton
f86ee91bac
Merge pull request #13716 from keymanapp/chore/web/replace-kmwfromcharcode
chore(web): replace kmwFromCharCode with its ES6 equivalent 🧶
2025-05-05 15:04:45 +07:00
Joshua Horton
eb5fefa4b4
Merge pull request #13797 from keymanapp/change/web/lint-web-utils
change(web): lint engine/common/web-utils 🧶
2025-05-05 15:04:30 +07:00
Joshua Horton
dd77c268fc docs(web): add keystroke-lifecycle sequence diagram 2025-05-05 15:01:33 +07:00
Joshua Horton
62240c8b46 docs(web): applies 80-char line wrap 2025-05-05 13:45:47 +07:00
Joshua Horton
80951c247a docs(web): revised areas noted in code review
Does not include the requested flowchart, which'll be its own commit once I work out the needed details and relationships.
2025-05-05 13:31:31 +07:00
Joshua Horton
cf0b83081b change(web): use pt-style sizing for unitless touch-layout fontsizes 2025-05-02 12:49:17 +07:00
Joshua Horton
a0ce7d2934
change(web): apply suggestion from PR review
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
2025-05-02 11:58:33 +07:00
Joshua Horton
209e4e579e
Merge pull request #13807 from keymanapp/maint/disconnect-pred-text-only-ci-config
maint(web): merge LMLayer CI build config with standard Web CI build config
2025-05-02 09:55:37 +07:00
Joshua Horton
b6fbf165dd maint(web): simplify worker-main test.sh 2025-05-02 09:52:43 +07:00
Joshua Horton
cb5e3035a7 chore(web): replace --ci flag with builder_is_ci_build
Fixes: #12640
2025-05-02 09:39:39 +07:00
Joshua Horton
644837d47f Merge branch 'master' into fix/web/gesture-fixture-extraction 2025-05-02 08:25:42 +07:00
Joshua Horton
dfe3de4ce1
chore: fix indentation in worker-main/build.sh
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-05-02 08:13:30 +07:00
Joshua Horton
14657c3894 maint(web): run LMLayer tests during standard Web module tests
Related-to: #12872

Test-bot: skip
2025-04-30 15:06:11 +07:00
Joshua Horton
e5b9118356 chore(web): ensure gesture-recognizer unit tests run 2025-04-30 12:22:31 +07:00
Joshua Horton
dbbb6fd8bc fix(web): fix extraction of gesture-engine fixture used in DOM-based unit tests
Test-bot: skip
2025-04-30 12:20:35 +07:00
Joshua Horton
843221c466 chore(web): improve clean actions
A few cases weren't properly handled, while a few others simply weren't called by the top-level script.  This PR seeks to make the top-level clean action able to fully clean all built components, perhaps save for sample and test pages.

Test-bot: skip
2025-04-30 12:18:59 +07:00
Joshua Horton
de0eaa411b change(web): lint kmwstring web-utility
This removes the exception in #13797 for KMWString, properly including the newly-refactored code in linting as well.
2025-04-30 09:01:47 +07:00
Joshua Horton
16fb2fef49 Merge branch 'chore/web/add-string-handling-unit-tests' into refactor/web/eliminate-kmwstring-side-effects 2025-04-30 08:57:36 +07:00
Joshua Horton
7217d7cf72 feat(web): add more indexOf, lastIndexOf unit test statements
Co-authored-by: Eberhard Beilharz <eb1@sil.org>
2025-04-30 08:42:27 +07:00
Joshua Horton
4e4fbc174a Merge branch 'chore/web/replace-kmwfromcharcode' into chore/web/add-string-handling-unit-tests 2025-04-30 08:33:02 +07:00
Joshua Horton
efb14e7b2a Merge branch 'change/web/lint-web-utils' into chore/web/replace-kmwfromcharcode 2025-04-30 08:32:09 +07:00
Joshua Horton
80f95d979a change(web): lint engine/common/web-utils
Does not lint kmwstring.ts, as that has an existing rework.  A separate PR will be added as a followup to the refactor PR (#13726) to handle it.
2025-04-30 08:30:06 +07:00
Joshua Horton
efe8ed39cc Merge branch 'master' into chore/web/replace-kmwfromcharcode 2025-04-30 08:22:43 +07:00
Joshua Horton
d9bddee90e
Merge pull request #13714 from keymanapp/fix/web/web-util-unit-testing
fix(web): reconnect unit tests for low-level web utility classes/methods 🧶
2025-04-30 08:21:20 +07:00
Joshua Horton
8f04951c80 chore(web): enable web/ linting 2025-04-29 12:01:42 +07:00
Joshua Horton
d6579495f8 change(web): address recorder-tool linter errors 2025-04-29 11:54:44 +07:00
Joshua Horton
4762429e96 change(web): address app/ui linter errors 2025-04-29 11:40:19 +07:00
Joshua Horton
da138b098d change(web): address app/browser linter errors 2025-04-29 11:38:08 +07:00
Joshua Horton
241f9655f2 change(web): address app/webview linter errors 2025-04-29 11:32:35 +07:00
Joshua Horton
19021f1419 change(web): address engine/main linter errors 2025-04-29 11:30:30 +07:00
Joshua Horton
0288048340 change(web): address engine/keyboard-storage linter errors 2025-04-29 11:29:16 +07:00
Joshua Horton
7baf8d0b69 change(web): address engine/attachment linter errors 2025-04-29 11:28:28 +07:00