Commit graph

108 commits

Author SHA1 Message Date
Marc Durdin
49eb062c65 feat(web): prediction casing follows current layer
Fixes #6455.

This involved adding an extra hint to the data passed into the lexical
model layer, being the CasingForm that the current layer wants to use.

Given there are several entry points to the lexical model layer, this
meant a few places where we needed to check the current layer.

I refactored the very long function `InputProcessor.processKeyEvent` to
extract out the `buildAlternates` function. There should be no
functional changes to the `buildAlternates` code. But it makes
`processKeyEvent` significantly easier to read.
2022-04-08 16:14:01 +10:00
Marc Durdin
e616900cad
Revert "feat(web): prediction casing follows current layer" 2022-04-08 14:50:32 +10:00
Marc Durdin
b7ce99480f feat(web): prediction casing follows current layer
Fixes #6455.

This involved adding an extra hint to the data passed into the lexical
model layer, being the CasingForm that the current layer wants to use.

Given there are several entry points to the lexical model layer, this
meant a few places where we needed to check the current layer.

I refactored the very long function `InputProcessor.processKeyEvent` to
extract out the `buildAlternates` function. There should be no
functional changes to the `buildAlternates` code. But it makes
`processKeyEvent` significantly easier to read.
2022-04-01 16:20:50 +11:00
Joshua Horton
01217a76ae
Merge pull request #5480 from keymanapp/fix/common/models/keep-diacritic-sensitivity
fix(common/models): keep/suggestion diacritic sensitivity when de-duping
2021-08-06 11:32:48 +07:00
Joshua Horton
9d35b26f1b
docs(common/models): applies PR suggestion
Co-authored-by: Marc Durdin <marc@durdin.net>
2021-07-22 10:56:38 +07:00
jahorton
3fd881d680 fix(common/models): keep/suggestion diacritic sensitivity when de-duping 2021-07-22 09:28:23 +07:00
jahorton
52c3356c7b fix(common/models): adds worker null guard for predict 2021-07-21 11:40:21 +07:00
Joshua Horton
af0fd256d1
change(common/models): PR suggestion
Co-authored-by: Marc Durdin <marc@durdin.net>
2021-03-23 09:44:18 +07:00
jahorton
9439090205 fix(common/models): fixes overly zealous thresholding near word starts 2021-03-23 09:13:02 +07:00
jahorton
8d74ece6f7 fix(common/models): prevents wordbreak-insertion aliasing 2021-03-22 14:04:09 +07:00
jahorton
24cbb23622 fix(common/models): prevents "undefined" reversion display string 2021-03-11 10:51:48 +07:00
jahorton
978eea2204 change(common/models): a bit of tidy-up 2021-03-04 12:44:08 +07:00
jahorton
35ee5828da fix(common/models): fixes incorrect deleteLeft prop for post-bksp suggestions 2021-03-04 12:36:39 +07:00
jahorton
a232f32ea4 chore: reverts right-delete changes 2021-02-26 10:32:48 +07:00
jahorton
8516561081 change(common/models): disables right-deletion for now 2021-02-25 14:31:11 +07:00
jahorton
28ed690fe2 chore(common/models): Merge branch 'beta' into feat/common/models/mid-context-suggestions 2021-02-25 09:16:45 +07:00
jahorton
21d9f49001 fix(common/models): merges identical suggestions after casing 2021-02-22 14:43:58 +07:00
jahorton
785b9500c1 fix(common/models): correction-search smp issues 2021-02-10 10:52:32 +07:00
jahorton
f0f1ae351e docs(common/models): removes defunct comment-doc 2021-02-09 09:22:09 +07:00
jahorton
a2adfd736e chore(common/models): Merge branch 'fix/common/models/context-reset-predictions' into feat/common/models/mid-context-suggestions 2021-02-08 09:31:26 +07:00
jahorton
d5161e344e fix(common/models): accumulates 'keep' probability / prevents replacement 2021-02-08 09:27:40 +07:00
jahorton
29f9625d7a change(common/models): better suggestion thresholding strat 2021-02-08 09:11:37 +07:00
jahorton
861d1b5501 fix(common/models): branch polishing, unit test fix 2021-02-05 12:58:06 +07:00
jahorton
e1bab443ea fix(common/models): mid-context post-revert suggestion acceptance 2021-02-05 10:22:52 +07:00
jahorton
2b999d6274 fix(common/models): fixes reversion application 2021-02-05 09:33:28 +07:00
jahorton
138a7db228 feat(common/models): mid-context suggestion acceptance 2021-02-05 09:16:06 +07:00
jahorton
e50596335e fix(common/models): adds wordbreak text only at end of context 2021-02-03 10:59:37 +07:00
jahorton
1c9c64c7d7 fix(common/models): predictions after context reset / caret shift 2021-02-03 10:59:16 +07:00
jahorton
07daee7b16 fix(common/models): fixes post-wordbreak suggestions 2020-12-04 13:39:04 +07:00
jahorton
6d111783e3 fix(common/core/web): predictive context reset 2020-12-03 15:48:18 +07:00
jahorton
f7869c48b3 fix(common/models): fixes non-nil context predict bug 2020-11-11 15:42:27 +07:00
jahorton
e8322e0aa7 feat(common/models): properly casing partial suggestions 2020-11-11 10:07:29 +07:00
jahorton
d2586394c9 chore(common/models): CasingEnum -> CasingForm 2020-11-11 09:08:06 +07:00
jahorton
668ba26453 feat(common/models): initial applyCasing use, case detection 2020-11-05 14:29:52 +07:00
jahorton
b5309fc606 fix(common/models): context for reversion's wordbreak 2020-10-21 15:22:32 +07:00
jahorton
04e68f0185 chore(common/models): Merge branch 'master' into refactor/common/models/common-tokenization-and-wordbreaking 2020-10-21 15:21:49 +07:00
jahorton
d2b08d6e7d refactor(common/models): marks deprecation, detects reliance on deprecated wordbreaker def 2020-10-20 09:20:00 +07:00
Joshua Horton
6efb6d23be
Merge pull request #3685 from keymanapp/feat/common/models/context-reversion
feat(common/models): context reversion modeling
2020-10-20 08:42:07 +07:00
Joshua Horton
207b6b85f4
Merge pull request #3663 from keymanapp/feat/common/models/acceptance-context-tracking
feat(common/models):  context tracking of accepted Suggestions
2020-10-20 08:41:46 +07:00
jahorton
56afe4a221 change(common/models): better condition check 2020-10-19 13:43:19 +07:00
jahorton
1688366033 refactor(common/models): LMLayer use of refactored funcs 2020-10-14 12:16:35 +07:00
Eddie Antonio Santos
9a5f6f3a4f
Merge pull request #3705 from keymanapp/refactor/common/models/extract-outcome-type
refactor(common/models): extract Outcome type
2020-10-13 22:56:25 -06:00
Joshua Horton
73a20cfe8c
Merge pull request #3702 from keymanapp/feat/common/core/web/selective-wordbreak-swallow
feat(common/core/web): selective wordbreak swallowing after accepting suggestions
2020-10-14 08:25:35 +07:00
Eddie Antonio Santos
dfce22252c
refactor(common/models): replace & {p} with Outcome type 2020-10-13 09:28:48 -06:00
jahorton
f272efdeca feat(common/core/web): selective wordbreak swallowing after accepted suggestion 2020-10-12 15:33:40 +07:00
jahorton
46eecb81cd feat(common/models): disables "keep" when word is not suggestion otherwise 2020-10-12 12:51:47 +07:00
jahorton
934f594297 feat(common/models): adds LMLayer reversion unit tests 2020-10-09 15:47:46 +07:00
jahorton
beb19fdf84 feat(common/models): reversion in lm-layer 2020-10-08 15:15:55 +07:00
jahorton
505b5239c1 chore(common/models): Merge branch 'feat/common/models/model-dependent-revert-annotation' into feat/common/models/acceptance-context-tracking 2020-10-08 15:15:01 +07:00
jahorton
ebd9cb7df0 fix(common/models): suggestion annotation quote defaults 2020-10-08 10:16:56 +07:00