Steven R. Loomis
2bf22c440d
feat(core): marker fixes per review comments 🙀
...
- simplify and improve context processing
For: #9119
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2023-08-10 13:30:29 -05:00
Steven R. Loomis
66ee68d2b3
Apply suggestions from code review
...
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2023-08-10 09:36:16 -05:00
Steven R. Loomis
c23303ee23
Apply suggestions from code review
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-09 12:52:28 -05:00
Steven R. Loomis
f0c81687f6
feat(core): marker fixes per review comments 🙀
...
- move prepend_marker() to inline
- clear the string in context_to_string()
For: #9119
2023-08-09 12:51:35 -05:00
Steven R. Loomis
f21bd8212d
Merge branch 'master' into feat/core/9119-marker-core-epic-ldml
2023-08-09 11:03:53 -05:00
rc-swag
7e8e7be86f
Merge pull request #9353 from keymanapp/feat/windows/5822/notify-core-on-kbd-activation
...
feat(windows): Use Keyboard Activated event API call to turn off caps lock (if required) 🚏
2023-08-09 14:12:00 +10:00
rc-swag
e79cfc90d2
feat(windows): review comment
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-09 12:59:59 +10:00
Steven R. Loomis
93b1771570
Merge branch 'master' into feat/core/9119-marker-core-epic-ldml
2023-08-07 16:40:07 -05:00
rc-swag
3bcd919922
feat(windows): review suggestions
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-07 12:08:09 +10:00
Marc Durdin
49d471ba17
Merge pull request #8954 from keymanapp/feature-kmc-kmw
...
epic: kmc-kmw KeymanWeb compiler in Typescript 🗜
2023-08-07 11:37:39 +10:00
Steven R. Loomis
290bcede2f
feat(core): improve documentation on transform/marker processing loop 🙀
...
For: #9119
2023-08-04 16:12:02 -05:00
Steven R. Loomis
1480e4d934
feat(core): improve emit_text() marker processing loop 🙀
...
For: #9119
2023-08-04 16:03:13 -05:00
Steven R. Loomis
fbb874fbfe
feat(core): warning fix 🙀
...
For: #9119
2023-08-04 15:29:19 -05:00
Steven R. Loomis
a9badff183
feat(core): remove reference to CODE_DEADKEY 🙀
...
For: #9119
2023-08-04 15:21:38 -05:00
Steven R. Loomis
b80b43e1e9
feat(core): re-refactor transform processing logic 🙀
...
For: #9119
2023-08-04 15:20:00 -05:00
Steven R. Loomis
d21fd6bbc4
Merge remote-tracking branch 'upstream/master' into feat/core/9119-marker-core-epic-ldml
2023-08-04 14:14:07 -05:00
Marc Durdin
cdf026c2ba
chore: Merge branch 'feature-kmc-kmw' into chore/merge-master-into-feature-kmc-kmw-a17s18
2023-08-04 12:54:10 +07:00
Steven R. Loomis
6632aafeec
spec(core): update per code review 🙀
...
- keep 'deadkey' out of the ldml code
- other renames
For: #9119
2023-08-03 19:00:21 -05:00
Steven R. Loomis
d53ae69299
Apply suggestions from code review
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-03 18:56:05 -05:00
Steven R. Loomis
8f4cf8c24e
feat(core): refactor sentinel 🙀
...
- and break all the things
For: #9119
2023-08-03 18:52:53 -05:00
Steven R. Loomis
20d1aad679
feat(core): refactor char emit 🙀
...
- and add an assert that UC_SENTINEL doesn't go into the text stream
For: #9119
2023-08-03 17:39:09 -05:00
Steven R. Loomis
cd3116d7cb
feat(core): improve processing logic 🙀
...
- improve the ctxt managing logic a little bit.
- need to handle markers as markers, though.
#9119
2023-08-03 15:20:37 -05:00
Steven R. Loomis
8a59df7fe3
Merge branch 'feat/developer/9119-marker-update-spec-epic-ldml' into feat/core/9119-marker-core-epic-ldml
2023-08-03 14:44:34 -05:00
Steven R. Loomis
3db0220f43
feat(core): steps in marker imp 🙀
...
- fix a logic err in vars - premature optimization was skipping when we had markers but no other vars
- update marker output in keys, including to and longpress. TODO-LDML still do not handle markers in lists (longpress, multitap, or flicks). The tests are there but commented out.
For: #9119
2023-08-03 13:26:19 -05:00
Ross
85ad6125bf
feat(windows): typos
2023-08-03 13:09:12 +10:00
rc-swag
ba572f1f31
feat(windows): apply suggestions from code review
2023-08-03 13:08:11 +10:00
Ross
792899c124
feat(windows): add ProcessActionsExternalEvent
2023-08-03 12:12:57 +10:00
Steven R. Loomis
22a65711f9
feat(core): starting in on marker implementation 🙀
...
- with a failing test case, of course
- basic test of markers
For: #9119
2023-08-02 18:56:18 -05:00
Steven R. Loomis
913cb5d18a
Apply suggestions from code review
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-08-02 18:55:22 -05:00
Steven R. Loomis
2a818b1ede
spec(core,developer): update marker spec 🙀
...
- use UC_SENTINEL CODE_DEADKEY …
- use U+FFFE for any marker
- add asserts between .ts and C++
- update generation
For: #9119
2023-08-02 18:04:48 -05:00
Marc Durdin
41aac59a4a
chore(developer): minor patches to fix compile issues
...
Fixes #9377 .
1. ldml_transforms.cpp used emplace_back with char instead of dword
values (#9377 )
2. import was updated to src/ instead of ../ by vscode in build.ts
(no related issue)
2023-08-01 13:27:31 +07:00
Ross
a8f2934406
feat(windows): add unit test for external event
...
Added a unit test for an external event. Also updated
the unit test utility print code for action items to include
KM_KBP_IT_CAPSLOCK.
2023-07-31 09:52:14 +10:00
Steven R. Loomis
0d3ffbbe57
chore(core): marker - pt-abnt2 broken 🙀
...
- upstream in CLDR is incomplete in marker/transform implementation, disabling for now
#9119
2023-07-29 20:30:59 -05:00
Steven R. Loomis
c15e1f37c2
Merge branch 'feat/developer/9119-marker-epic-ldml' into feat/developer/9119-marker-emit-epic-ldml
2023-07-29 17:02:54 -05:00
Steven R. Loomis
e71e1c10d8
Merge branch 'master' into feat/developer/9119-marker-epic-ldml
2023-07-29 17:02:38 -05:00
Steven R. Loomis
2ec20ae8b4
Merge pull request #9352 from keymanapp/chore/core/7375-reorder-comments-epic-ldml
...
chore(core): update documentation in transform logic and processor 🙀
2023-07-29 17:01:39 -05:00
Steven R. Loomis
2211900e5f
feat(common): marker - move values into constants 🙀
...
- constants need to be shared with C++
#9119
2023-07-29 16:15:55 -05:00
Steven R. Loomis
7ad3f95a67
Merge branch 'chore/core/7375-reorder-comments-epic-ldml' into feat/developer/9119-marker-epic-ldml
2023-07-29 14:49:46 -05:00
Steven R. Loomis
c7881d99b2
Update core/src/ldml/ldml_processor.cpp
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-07-28 21:55:39 -05:00
Steven R. Loomis
ccc86a942b
feat(core): fix uset range check 🙀
...
- review comments
#7375
2023-07-28 21:54:09 -05:00
Steven R. Loomis
f2915bbb66
spec(core): update marker spec 🙀
...
- 'transform' doesn't have an 'after=' attribute
For: #9118
2023-07-26 17:04:50 -05:00
Steven R. Loomis
99c2aff760
chore(core): turn off debugging 🙀
...
- fix a stray define
For: #7375
2023-07-26 16:18:53 -05:00
Steven R. Loomis
875d59987a
chore(core): update documentation in transform logic and processor 🙀
...
- drop some unneeded variables also, should be no semantic change
For: #7375
2023-07-26 16:16:57 -05:00
Steven R. Loomis
97b3120829
fix(core): Optimize checks for Uni_IsValid() 🙀
...
For: #7375
2023-07-26 14:50:49 -05:00
Steven R. Loomis
f57c66ede5
Merge branch 'master' into fix/core/7375-verify-uset-range-epic-ldml
2023-07-26 13:22:36 -05:00
Steven R. Loomis
b012499528
Merge pull request #9345 from keymanapp/fix/common-9139-kmxplus-align-structs-epic-ldml
...
fix(core): tag KMXPlus file-based structs with alignment 🙀
2023-07-26 13:21:59 -05:00
Steven R. Loomis
08787ead56
Merge pull request #9344 from keymanapp/chore/developer-9236-vkey-warning-epic-ldml
...
chore(developer): make unknown vkey a hint, not error 🙀
2023-07-26 13:21:47 -05:00
Steven R. Loomis
480fd3bcad
fix(core): More range checks for Uni_IsValid() 🙀
...
For: #7375
2023-07-25 19:02:46 -05:00
Steven R. Loomis
352328fbbe
fix(core): Better range check for Uni_IsValid() 🙀
...
- rewrite macros as inlines
- brute force approach
For: #7375
2023-07-25 18:42:29 -05:00
Steven R. Loomis
b0b83b4e50
fix(core): tag KMXPlus file-based structs with alignment 🙀
...
Fixes : #9139
2023-07-25 18:14:22 -05:00