erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-10-12 08:57:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(windows): add other observed cases of disabled

Browse source
This commit is contained in:
rc-swag 2026-10-01 11:57:44 +10:00
parent 6112104e55
commit f09ff0f487
1 changed files with 27 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
windows/src/desktop/kmshell/util/Keyman.Configuration.System.StartupSettings.pas
View file

@ -23,17 +23,33 @@ uses
Windows,
SysUtils;
const
// This registry key is not documented by Microsoft, others have determined:
// The value associated with it is 12 bytes in length the first being the
// enabled/disabled state. The rest of the byte is the timestamp
// of when it was disabled.
// 03 - startup disabled, user with admin rights can enable
// 02 - startup enabled, user with admin rights can disable
// See issue #15785 for more details.
(* This registry key is not documented by Microsoft, others have determined:
The value associated with it is 12 bytes in length the first being the
enabled/disabled state. The rest of the byte is the timestamp
of when it was disabled. Drawing from our investigation of the registry
and a broader search of stackoverflow, superuser and other sources on
the web, the following table can be derived for the first byte of the value:
See issue #15785 for more details and links.
StartupEnabled: Byte = $02;
StartupDisabled: Byte = $03;
| First byte | Reported behaviour | Source quality |
| ---------- | ------------------------------ | --------------------------------------|
| `00` | enabled, user can disable | Our test on two Win 11 Home Machines |
| `01` | Disabled, user can enable | Our test + Super User |
| `02` | Enabled, user can disable | Multiple sources |
| `03` | Disabled, user can enable | Multiple sources |
| `06` | Enableduser can disable | Stack Overflow, not seen by us |
| `07` | Disabled, user can enable | Stack Overflow, not seen by us |
| `08` | Enabled, user cannot disable | Super User, not seen by us |
| `09` | Disabled, user cannot enable | Super User, not seen by us |
Maybe it is just bit 0 of the first byte that is enabled disabled? There in no
point checking for $09 as the user cannot change the setting. We would need a
different message.
*)
const
StartupDisabled: set of Byte = [$01, $03, $07];
class function TWindowsStartupSettings.IsWindowsStartupDisabled: Boolean;
var
@ -53,7 +69,7 @@ begin
Exit;
if reg.ReadBinaryData(SRegValue_WindowsRun_Keyman, data, SizeOf(data)) <> sizeof(data) then
Exit;
Result := data[0] = StartUpDisabled;
Result := data[0] in StartupDisabled;
except
on E: ERegistryException do
Result := False;