erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-29 03:37:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 14

fix(web): fix immediate application of suggestions following another

Browse source
This commit is contained in:
Joshua Horton 2025-09-05 12:16:55 -05:00
parent be25bd3891
commit eb83fb91bc
2 changed files with 24 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
web/src/engine/predictive-text/worker-thread/src/main/correction/context-transition.ts
View file

@ -72,7 +72,8 @@ export class ContextTransition {
*/
constructor(context: ContextState, transitionId: number);
/**
* Deep-copies a ContextTransition instance.
* Deep-copies a ContextTransition instance, optionally assigning a different
* transition ID to it in the process.
* @param baseTransition
*/
constructor(baseTransition: ContextTransition);

40
web/src/engine/predictive-text/worker-thread/src/main/predict-helpers.ts
View file

@ -24,6 +24,7 @@ import Reversion = LexicalModelTypes.Reversion;
import Suggestion = LexicalModelTypes.Suggestion;
import SuggestionTag = LexicalModelTypes.SuggestionTag;
import Transform = LexicalModelTypes.Transform;
import { ContextTransition } from './test-index.js';
/*
* The functions in this file exist to provide unit-testable stateless components for the
@ -280,10 +281,18 @@ export async function correctAndEnumerate(
// Corrections and predictions are based upon the post-context state, though.
let transition = contextTracker.latest;
const inputIsEmpty = TransformUtils.isEmpty(inputTransform) && transformDistribution.length == 1;
// If the input matches something we've already seen (say, a ' ' or '.'
// that auto-applied a suggestion).
if(
// Don't replace any applied-suggestion data if we have a request to trigger with
// the current context state.
if(inputIsEmpty) {
// Directly build a simple empty transition that duplicates the last seen state.
const priorState = contextTracker.latest.final;
transition = new ContextTransition(priorState, inputTransform.id);
transition.finalize(priorState, transformDistribution);
} else if(
// If the input matches something we've already seen (say, a ' ' or '.'
// that auto-applied a suggestion).
transition.transitionId == inputTransform.id &&
transition.final.context.left == postContext.left
) {
@ -292,21 +301,16 @@ export async function correctAndEnumerate(
transition.inputDistribution = transformDistribution;
contextState = transition.final;
return correctAndEnumerate(
contextTracker,
lexicalModel,
timer,
// TODO: consider finding a way to add in the auto-appended whitespace
// if `inputTransform` does not match it?
[{sample: { insert: '', deleteLeft: 0 }, p: 1}],
postContext // We need to restart in order to reset constants.
);
} else if(
// If the input is a solitary empty transform, indicating a request to
// obtain the most recent prior request's results...
transformDistribution.length != 1 ||
!TransformUtils.isEmpty(transformDistribution[0].sample)
) {
// Not yet done; we may want to consider saving the fat-finger distribution of
// incoming text for this case for correction-search - we didn't get it
// when applying a prior suggestion.
// Do NOT recurse; return none instead.
return {
rawPredictions: [],
postContextState: transition.final
};
} else {
transition = contextState.analyzeTransition(context, transformDistribution);
if(!transition) {
console.warn("Unexpected failure when computing context-state transition");