erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-05 00:15:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

chore(common): cleanup optionals in ldml keyboard reader

Browse source 
`boxArrays` had some optional chaining that was either not needed,
and/or was used in an inappropriate context, for example within the
iterable argument to a `for` statement, which would have caused an "not
iterable" error if it ever actually resolved to `undefined`.

This should have no material impact on the code, but helps to clarify
code readability.

Test-bot: skip
This commit is contained in:
Marc Durdin 2026-04-22 15:33:26 +02:00
parent f99512c328
commit e99813b3e3
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
developer/src/common/web/utils/src/types/ldml-keyboard/ldml-keyboard-xml-reader.ts
View file

@ -100,31 +100,31 @@ export class LDMLKeyboardXMLSourceFileReader implements EventResolver {
boxXmlArray(source?.keyboard3?.locales, 'locale');
boxXmlArray(source?.keyboard3, 'transforms');
if(source?.keyboard3?.layers) {
for(const layers of source?.keyboard3?.layers) {
for(const layers of source.keyboard3.layers) {
boxXmlArray(layers, 'layer');
if(layers?.layer) {
for(const layer of layers?.layer) {
if(layers.layer) {
for(const layer of layers.layer) {
boxXmlArray(layer, 'row');
}
}
}
}
if(source?.keyboard3?.forms?.form) {
boxXmlArray(source?.keyboard3?.forms, 'form');
for(const form of source?.keyboard3?.forms?.form) {
boxXmlArray(source.keyboard3.forms, 'form');
for(const form of source.keyboard3.forms.form) {
boxXmlArray(form, 'scanCodes');
}
}
if(source?.keyboard3?.flicks) {
boxXmlArray(source?.keyboard3?.flicks, 'flick');
for(const flick of source?.keyboard3?.flicks?.flick) {
boxXmlArray(source.keyboard3.flicks, 'flick');
for(const flick of source.keyboard3.flicks.flick) {
boxXmlArray(flick, 'flickSegment');
}
}
if(source?.keyboard3?.variables) {
boxXmlArray(source?.keyboard3?.variables, 'set');
boxXmlArray(source?.keyboard3?.variables, 'string');
boxXmlArray(source?.keyboard3?.variables, 'uset');
boxXmlArray(source.keyboard3.variables, 'set');
boxXmlArray(source.keyboard3.variables, 'string');
boxXmlArray(source.keyboard3.variables, 'uset');
}
if(source?.keyboard3?.transforms) {
for(const transforms of source.keyboard3.transforms) {