From 88d896e7d5d10be21f1dde1f3949b357dff0e80f Mon Sep 17 00:00:00 2001 From: Darcy Wong Date: Thu, 27 Mar 2025 15:40:53 +0700 Subject: [PATCH 1/4] fix(android): Copy values-sw600dp-land/dimens.xml to values-land-xhdpi --- .../src/main/res/values-land-xhdpi/dimens.xml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml diff --git a/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml b/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml new file mode 100644 index 0000000000..613a8b8526 --- /dev/null +++ b/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml @@ -0,0 +1,17 @@ + + + + 50dp + 140dp + 73.5dp + 58.5dp + 32dp + 12dp + 6dp + 4dp + 8dp + 125dp + 85dp + 0.5dp + 8dp + From 5871df98b65548c15d437b656232c62b0f1638ed Mon Sep 17 00:00:00 2001 From: Darcy Wong Date: Thu, 27 Mar 2025 15:42:19 +0700 Subject: [PATCH 2/4] fix(android): Modify dimens.xml for 320dpi device User requested a taller default keyboard height for a Pixel 8a device in landscape (430dpi corresponding to xhdpi). The next tier xxhdpi is for 480+ dpi. Reference https://developer.android.com/guide/topics/resources/providing-resources.html#table2 Based on `values/sw600dp-land/dimens.xml`, create `values-land-xhdpi/dimens.xml` This allows a taller landscape keyboard height. --- .../app/src/main/res/values-land-xhdpi/dimens.xml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml b/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml index 613a8b8526..f54de057e2 100644 --- a/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml +++ b/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml @@ -1,12 +1,12 @@ - + 50dp 140dp - 73.5dp - 58.5dp - 32dp - 12dp + 83.5dp + 78.5dp + 38dp + 14dp 6dp 4dp 8dp @@ -14,4 +14,5 @@ 85dp 0.5dp 8dp + 6dp From 9a4bc0c0496febd3006a4e4746f5ec25c6ac19b9 Mon Sep 17 00:00:00 2001 From: Darcy Wong Date: Fri, 28 Mar 2025 09:56:08 +0700 Subject: [PATCH 3/4] docs(android): Update table --- android/docs/engine/KMManager/applyKeyboardHeight.md | 1 + 1 file changed, 1 insertion(+) diff --git a/android/docs/engine/KMManager/applyKeyboardHeight.md b/android/docs/engine/KMManager/applyKeyboardHeight.md index 2830519c62..874ad6d5c7 100644 --- a/android/docs/engine/KMManager/applyKeyboardHeight.md +++ b/android/docs/engine/KMManager/applyKeyboardHeight.md @@ -31,6 +31,7 @@ For reference, here's a table of the default Keyman keyboard heights for various |-----------------------------------|---------------------| | Default handset in portrait | 205 | | Default handset in landscape | 150 | +| Extra High Density handset in landscape | 140 | | 7" tablet in portrait | 305 | | 7" tablet in landscape | 200 | | 10" tablet in portrait | 405 | From 6547458a3cc6e2bee77ad37e2c1374f0387fb00a Mon Sep 17 00:00:00 2001 From: Darcy Wong Date: Mon, 31 Mar 2025 13:37:23 +0700 Subject: [PATCH 4/4] fix(android): Make banner smaller Following review suggestion for banner not to be more than 1/4 of the main keyboard body. --- android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml b/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml index f54de057e2..292cfcc6b3 100644 --- a/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml +++ b/android/KMEA/app/src/main/res/values-land-xhdpi/dimens.xml @@ -1,7 +1,7 @@ - 50dp + 30dp 140dp 83.5dp 78.5dp