erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-09-28 10:37:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Merge pull request #14466 from keymanapp/maint/ios/14286-skip-publishing-on-build-buildlevel

Browse source 
maint(ios): skip unnecessary network steps when buildLevel is build 🦌
This commit is contained in:
Marc Durdin 2025-08-12 10:38:22 +07:00 • committed by GitHub
commit d8264d008a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ios/engine/build.sh
View file

@ -50,7 +50,7 @@ XCODEFLAGS="-quiet -configuration $CONFIG"
XCODEFLAGS_EXT="$XCODEFLAGS -derivedDataPath \"$DERIVED_DATA\" -workspace ../keymanios.xcworkspace"
CODE_SIGN=
if builder_is_debug_build; then
if builder_is_debug_build || ( builder_is_ci_build && ! builder_is_ci_build_level_release ); then
CODE_SIGN="CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO ${DEV_TEAM:-} CODE_SIGN_ENTITLEMENTS= CODE_SIGNING_ALLOWED=NO"
fi

23
resources/teamcity/ios/keyman-ios-test.sh
View file

@ -21,6 +21,13 @@ THIS_SCRIPT="$(readlink -f "${BASH_SOURCE[0]}")"
################################ Main script ################################
# TODO: remove unused `--pr-number` option. Unfortunately, the mechanism we
# designed to skip this, `--builder-ignore-unknown-options`, does not work for
# options with values. We need another one, for example, something like
# `--builder-ignore-unknown-value-options=pr-number[,...]`, so for now I will
# leave it alone. The option ultimately needs to be removed from the TC build
# configuration also. (Unused as of #14466)
builder_describe \
"Build KeymanEngine and Keyman for iOS" \
"all run all actions" \
@ -70,12 +77,6 @@ function __do_upload_to_testflight() {
}
function _upload_to_testflight_pr_area() {
# shellcheck disable=SC2154
if ! [[ "${PR_NUMBER}" =~ ^[0-9]+$ ]]; then
builder_echo "Ignoring TestFlight upload for non-PR build"
return
fi
builder_echo start "upload to testflight" "Uploading build to TestFlight (PR area)"
# shellcheck disable=SC2154
__do_upload_to_testflight "${SIL_ITC_PROVIDER}" "${SIL_API_KEY_ID}" "${SIL_ITC_TEAM_ID}" keyman
@ -83,12 +84,6 @@ function _upload_to_testflight_pr_area() {
}
function _upload_to_testflight_pr_area_fv() {
# shellcheck disable=SC2154
if ! [[ "${PR_NUMBER}" =~ ^[0-9]+$ ]]; then
builder_echo "Ignoring TestFlight upload for non-PR build"
return
fi
if ! builder_has_option --fv; then
builder_echo "Skipping FirstVoices upload to TestFlight as --fv option is not set"
return
@ -103,8 +98,8 @@ function _upload_to_testflight_pr_area_fv() {
function do_build() {
ios_build
ios_capture_build_artifacts
_upload_to_testflight_pr_area
_upload_to_testflight_pr_area_fv
builder_if_release_build_level _upload_to_testflight_pr_area
builder_if_release_build_level _upload_to_testflight_pr_area_fv
}
ba_mac_unlock_keychain