change(web/engine): addressing PR review

This commit is contained in:
jahorton 2020-03-27 09:10:55 +07:00
parent 84339be3cc
commit cf047bfab9
2 changed files with 5 additions and 5 deletions

View file

@ -43,7 +43,7 @@ namespace com.keyman.text {
case Browser.Native:
case Browser.Opera:
case Browser.Safari:
this.browser = browser as Browser;
this.browser = browser.toLowerCase() as Browser;
break;
default:
this.browser = Browser.Other;
@ -53,10 +53,10 @@ namespace com.keyman.text {
case FormFactor.Desktop:
case FormFactor.Phone:
case FormFactor.Tablet:
this.formFactor = formFactor as FormFactor;
this.formFactor = formFactor.toLowerCase() as FormFactor;
break;
default:
throw ("Invalid form factor specified for device!");
throw ("Invalid form factor specified for device: " + formFactor);
}
switch(OS.toLowerCase()) {
@ -65,7 +65,7 @@ namespace com.keyman.text {
case OperatingSystem.Linux.toLowerCase():
case OperatingSystem.Android.toLowerCase():
case OperatingSystem.iOS.toLowerCase():
this.OS = OS as OperatingSystem;
this.OS = OS.toLowerCase() as OperatingSystem;
break;
default:
this.OS = OperatingSystem.Other;

View file

@ -10,7 +10,7 @@
/// <reference path="../keyboards/keyboard.ts" />
// Defines built-in keymapping.
/// <reference path="keyMapping.ts" />
// Defines a headless-compatible 'Device' analogue for use in keyEvent processing
// Defines a core-compatible 'Device' analogue for use in keyEvent processing
/// <reference path="engineDeviceSpec.ts" />
namespace com.keyman.text {