erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-10-16 02:47:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 18

fix(android): Remove use of BreakIterator

Browse source 
Specifying newCursorPosition `1` fixed the cursor placement after inserting text.
This commit is contained in:
Darcy Wong 2019-11-18 11:45:31 +07:00
parent adffc42b8d
commit ce98d7ac0b
1 changed files with 3 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
android/KMEA/app/src/main/java/com/tavultesoft/kmea/KMManager.java
View file

@ -9,7 +9,6 @@ import java.io.FileFilter;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.text.BreakIterator;
import java.util.ArrayList;
import java.util.HashMap;
@ -2057,29 +2056,9 @@ public final class KMManager {
if (s.length() > 0) {
SystemKeyboardShouldIgnoreSelectionChange = true;
// Using BreakIterator to count grapheme clusters
BreakIterator boundary = BreakIterator.getCharacterInstance();
boundary.setText(s);
int count = 0;
while (boundary.next() != BreakIterator.DONE) {
count++;
}
// Commit the string s and adjust the cursor by the number of grapheme clusters
ic.commitText(s, count);
Log.d(TAG, "adjusting commitText s:" + s.toString() + ", count: " + count + ", s.length: " + s.length());
// After inserting the string s and adjusting the cursor count clusters,
// Chrome and Firefox sometimes have the cursor too far, so
// check if we need to adjust the cursor position
CharSequence charsBefore = getCharacterSequence(ic, s.length()*2);
// Adjust the cursor by "move" codepoints
int move = CharSequenceUtil.adjustCursorPosition(charsBefore, s);
if (move > 0) {
Log.d(TAG, "adjusting cursor charsBefore: " + charsBefore.toString() + ", s: " + s + ", move: " + move);
ic.commitText("", -move);
}
// Commit the string s. Use newCursorPosition 1 so cursor will end up after the string.
ic.commitText(s, 1);
Log.d(TAG, "adjusting commitText s:" + s.toString());
}
ic.endBatchEdit();