erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-05 00:15:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

fix(mac): nil window references after dismissing dialogs

Browse source 
also delete commented code
This commit is contained in:
sgschantz 2024-09-02 15:56:50 +07:00
parent b38700cb19
commit cc2c917bc2
1 changed files with 3 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
mac/Keyman4MacIM/Keyman4MacIM/KMConfiguration/KMConfigurationWindowController.m
View file

@ -422,8 +422,8 @@
if (returnCode == NSAlertFirstButtonReturn) {
os_log_debug([KMLogs uiLog], "confirm delete keyboard alert dismissed");
[self deleteFileAtIndex:[NSNumber numberWithInteger:deleteButton.tag]];
self.deleteAlertView = nil;
}
self.deleteAlertView = nil;
}];
}
@ -462,8 +462,9 @@
os_log_debug([KMLogs uiLog], "confirm keyboard installation alert dismissed");
if (returnCode == NSAlertFirstButtonReturn) {
[self installPackageFile: package.getTempKmpFilename];
self.confirmKmpInstallAlertView = nil;
}
[package releaseTempKMPFile];
self.confirmKmpInstallAlertView = nil;
}];
}
@ -564,29 +565,6 @@
return _confirmKmpInstallAlertView;
}
/*
- (void)alertDidEnd:(NSAlert *)alert returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo {
os_log_debug([KMLogs uiLog], "User responded to NSAlert");
if (alert == _deleteAlertView) {
if (returnCode == NSAlertFirstButtonReturn) { // Delete
[self deleteFileAtIndex:(__bridge NSNumber *)contextInfo];
}
_deleteAlertView = nil;
}
else if (alert == _confirmKmpInstallAlertView) {
KMPackage *package = (__bridge KMPackage *)contextInfo;
os_log_debug([KMLogs uiLog], "KMP - Temp file: %{public}@", package.getTempKmpFilename);
if (returnCode == NSAlertFirstButtonReturn) { // Install
[self installPackageFile: package.getTempKmpFilename];
}
[package releaseTempKMPFile];
_confirmKmpInstallAlertView = nil;
}
// else, just a message - nothing to do.
}
*/
- (void)deleteFileAtIndex:(NSNumber *) n {
NSInteger index = [n integerValue];
NSString *path2Remove = nil;