From 80dfa615a9459fed40cc75d288dc24a8c0fb98c7 Mon Sep 17 00:00:00 2001 From: jahorton Date: Wed, 11 Sep 2019 15:29:51 +0700 Subject: [PATCH 1/3] Highlighting checks key instance, not key id --- web/source/osk/visualKeyboard.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/source/osk/visualKeyboard.ts b/web/source/osk/visualKeyboard.ts index beffc245cc..e0288fe6fd 100644 --- a/web/source/osk/visualKeyboard.ts +++ b/web/source/osk/visualKeyboard.ts @@ -1097,7 +1097,7 @@ namespace com.keyman.osk { this.currentTarget = key1; // Clear previous key highlighting - if(key0 && key1 && (key1.id != key0.id)) { + if(key0 && key1 && key1 !== key0) { this.highlightKey(key0,false); } From 3805d9da7e15eedaf8c8479891ebb89a6368412d Mon Sep 17 00:00:00 2001 From: jahorton Date: Wed, 11 Sep 2019 15:33:05 +0700 Subject: [PATCH 2/3] A bit of future-proofing --- web/source/dom/uiTouchHandlerBase.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/source/dom/uiTouchHandlerBase.ts b/web/source/dom/uiTouchHandlerBase.ts index ae59f4981b..169544b89e 100644 --- a/web/source/dom/uiTouchHandlerBase.ts +++ b/web/source/dom/uiTouchHandlerBase.ts @@ -395,7 +395,7 @@ namespace com.keyman.dom { this.currentTarget = key1; // Clear previous key highlighting - if(key0 && key1 && (key1.id != key0.id)) { + if(key0 && key1 && key1 != key0) { this.highlight(key0,false); } From ba984c3947e55a5c84a735cb13f09211c6ab0f9b Mon Sep 17 00:00:00 2001 From: jahorton Date: Thu, 12 Sep 2019 08:18:12 +0700 Subject: [PATCH 3/3] Addresses PR comment --- web/source/dom/uiTouchHandlerBase.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/source/dom/uiTouchHandlerBase.ts b/web/source/dom/uiTouchHandlerBase.ts index 169544b89e..78a0e82b10 100644 --- a/web/source/dom/uiTouchHandlerBase.ts +++ b/web/source/dom/uiTouchHandlerBase.ts @@ -395,7 +395,7 @@ namespace com.keyman.dom { this.currentTarget = key1; // Clear previous key highlighting - if(key0 && key1 && key1 != key0) { + if(key0 && key1 && key1 !== key0) { this.highlight(key0,false); }