erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-09-24 08:37:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

chore(common): Add comments to tests

Browse source 
Fix comments per review
This commit is contained in:
Darcy Wong 2020-02-10 09:33:21 +07:00
parent 8546ed47ab
commit ca5445dc19
3 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
common/engine/keyboardprocessor/tests/unit/kmx/041 - long context and deadkeys.kmn
View file

@ -12,12 +12,14 @@ group(Main) using keys
c Test 1
dk(1) 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefgh' + '1' > context '1'
c Test 2
c Test 2: Test that we haven't split a deadkey code: UC_SENTINEL CODE_DEADKEY <deadkey_number>
c because: CODE_DEADKEY = U+0008; deadkey_number = U+0001
U+0008 U+0001 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefgh1' + '2' > 'FAIL TEST 2'
U+0001 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefgh1' + '2' > 'FAIL TEST 2'
'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefgh1' + '2' > context '2'
c Test 3
c Test 3: Test that we haven't split a deadkey code: UC_SENTINEL CODE_DEADKEY <deadkey_number>
c because: CODE_DEADKEY = U+0008; deadkey_number = U+0001
U+0008 U+0001 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefgh12' + '3' > 'FAIL TEST 3'
U+0001 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefgh12' + '3' > 'FAIL TEST 3'
'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefgh12' + '3' > context '3'

2
common/engine/keyboardprocessor/tests/unit/kmx/042 - long context and split deadkeys.kmn
View file

@ -9,4 +9,6 @@ begin Unicode > use(Main)
group(Main) using keys
c Test 1: Test that we haven't split a deadkey code: UC_SENTINEL CODE_DEADKEY <deadkey_number>
c Here, looking at last char only: deadkey_number = U+0001
U+0001 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefgh' + ' ' > 'FAIL'

4
common/engine/keyboardprocessor/tests/unit/kmx/kmx.cpp
View file

@ -362,8 +362,8 @@ std::u16string parse_source_string(std::string const & s) {
size_t n;
std::string s1 = s.substr(p - s.begin(), 8);
v = std::stoul(s1, &n, 16);
// Allow deadkey characters onward
assert(v >= CODE_ANY && v <= 0x10FFFF);
// Allow deadkey_number (U+0001) characters and onward
assert(v >= 0x0001 && v <= 0x10FFFF);
p += n-1;
if (v < 0x10000) {
t += km_kbp_cp(v);