From c6e733747556576ab6317fa7a8523b46dc427efb Mon Sep 17 00:00:00 2001 From: Eberhard Beilharz Date: Mon, 9 Feb 2026 18:59:35 +0100 Subject: [PATCH] refactor(linux): make `get_ibus_version()` public --- linux/keyman-config/keyman_config/ibus_util.py | 4 ++-- linux/keyman-config/tests/ibus_util_tests.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/linux/keyman-config/keyman_config/ibus_util.py b/linux/keyman-config/keyman_config/ibus_util.py index 7eec49a373..3401b7d3b9 100644 --- a/linux/keyman-config/keyman_config/ibus_util.py +++ b/linux/keyman-config/keyman_config/ibus_util.py @@ -143,7 +143,7 @@ def verify_ibus_daemon(start): return retval -def _get_ibus_version(): +def get_ibus_version(): ibus_version = subprocess.run(('ibus', 'version'), check=False, stdout=subprocess.PIPE).stdout match = re.search(r'^IBus (.*)\n$', ibus_version.decode('utf-8')) @@ -156,7 +156,7 @@ def _get_ibus_version(): def _start_ibus_daemon(realuser): try: - if version.parse(_get_ibus_version()) >= version.parse('1.5.28'): + if version.parse(get_ibus_version()) >= version.parse('1.5.28'): # IBus ~1.5.28 added the `start` command, so we use that if possible # and let IBus deal with the necessary parameters args = ['ibus', 'start', '-d'] diff --git a/linux/keyman-config/tests/ibus_util_tests.py b/linux/keyman-config/tests/ibus_util_tests.py index e9b9261a20..57829f0502 100644 --- a/linux/keyman-config/tests/ibus_util_tests.py +++ b/linux/keyman-config/tests/ibus_util_tests.py @@ -2,7 +2,7 @@ import unittest from unittest.mock import Mock, patch -from keyman_config.ibus_util import _get_ibus_version, get_ibus_bus, install_to_ibus, uninstall_from_ibus +from keyman_config.ibus_util import get_ibus_version, get_ibus_bus, install_to_ibus, uninstall_from_ibus @patch('keyman_config.ibus_util.IBus.Bus') @@ -100,7 +100,7 @@ class IbusUtilTests(unittest.TestCase): ) # Execute - ibus_version = _get_ibus_version() + ibus_version = get_ibus_version() # Verify self.assertEqual(ibus_version, '1.5.28')