From bc0e4af58a1a872e2623e10978799a399e8e7326 Mon Sep 17 00:00:00 2001 From: Ross Date: Tue, 19 Oct 2021 07:34:24 +1000 Subject: [PATCH 1/3] docs(windows): add note to caps-lock-stores test Add a note the caps lock stores manual test describing the problem with the virtual box soft keyboad and the shift key for test-caps-off-5 test. --- windows/src/test/manual-tests/caps-lock-stores/TestReadme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md b/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md index 85cc33a3c5..3da593a0c2 100644 --- a/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md +++ b/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md @@ -105,7 +105,7 @@ Any keyboard with that store set will work; if you don't have one at hand you ca Expected result: - caps lock indicator turned off - output: `ncaps_little_a` - +**Note:** Test caps off 5 using a soft keyboard provided in virtual box will fail to turn the cap lock indicator off. This because the soft keyboard does pre processing of the shift key and any key pressed and the shift key stroke does not get sent to the keyman engine. ## CapsOnOnly/ShiftFreesCaps For these tests, use a keyboard with the `CapsOnOnly` and `ShiftFreesCaps` stores set. We call this keyboard _shift_frees_caps_ below. From 1c3b96a706c818044295f5cf770b2aa94d032db1 Mon Sep 17 00:00:00 2001 From: Ross Date: Tue, 19 Oct 2021 07:59:45 +1000 Subject: [PATCH 2/3] docs(windows): missing CR in md for testing --- windows/src/test/manual-tests/caps-lock-stores/TestReadme.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md b/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md index 3da593a0c2..5f5ee9ae24 100644 --- a/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md +++ b/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md @@ -105,7 +105,8 @@ Any keyboard with that store set will work; if you don't have one at hand you ca Expected result: - caps lock indicator turned off - output: `ncaps_little_a` -**Note:** Test caps off 5 using a soft keyboard provided in virtual box will fail to turn the cap lock indicator off. This because the soft keyboard does pre processing of the shift key and any key pressed and the shift key stroke does not get sent to the keyman engine. + +**Note:** For `Test caps off 5` using a soft keyboard provided in virtual box will fail to turn the cap lock indicator off. This because the soft keyboard does pre processing of the shift key combined with any key pressed and the shift key stroke does not get sent to the keyman engine. ## CapsOnOnly/ShiftFreesCaps For these tests, use a keyboard with the `CapsOnOnly` and `ShiftFreesCaps` stores set. We call this keyboard _shift_frees_caps_ below. From bccc075986491155c2411f18862a034774fb6087 Mon Sep 17 00:00:00 2001 From: rc-swag <58423624+rc-swag@users.noreply.github.com> Date: Tue, 19 Oct 2021 20:06:12 +1000 Subject: [PATCH 3/3] docs(windows): review comments Co-authored-by: Eberhard Beilharz --- windows/src/test/manual-tests/caps-lock-stores/TestReadme.md | 1 + 1 file changed, 1 insertion(+) diff --git a/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md b/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md index 5f5ee9ae24..1f231cbe63 100644 --- a/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md +++ b/windows/src/test/manual-tests/caps-lock-stores/TestReadme.md @@ -107,6 +107,7 @@ Any keyboard with that store set will work; if you don't have one at hand you ca - output: `ncaps_little_a` **Note:** For `Test caps off 5` using a soft keyboard provided in virtual box will fail to turn the cap lock indicator off. This because the soft keyboard does pre processing of the shift key combined with any key pressed and the shift key stroke does not get sent to the keyman engine. + ## CapsOnOnly/ShiftFreesCaps For these tests, use a keyboard with the `CapsOnOnly` and `ShiftFreesCaps` stores set. We call this keyboard _shift_frees_caps_ below.