erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-10-12 08:57:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(web): prevent insert-delete edit sequences from aliasing as substitution edits

Browse source 
Build-bot: skip build:web
Test-bot: skip
This commit is contained in:
Joshua Horton 2026-01-06 14:34:38 -06:00
parent 4f98dbff7f
commit bfad3ef074
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
web/src/engine/predictive-text/worker-thread/src/main/correction/distance-modeler.ts
View file

@ -135,6 +135,14 @@ export class SearchNode {
*/
private _inputCost?: number;
/**
* Counts the number of delete edits modeled directly after insert edits in
* this SearchNode's path. Such a sequence shows up within the calculation
* matrix as a substitution rather than two separate edits; we use this count
* to adjust accordingly.
*/
private readonly deleteAfterInsertEditPairs: number;
/**
* A unique identifier corresponding to the earliest SearchPath containing
* the correction-search graph edge represented by this instance.
@ -164,6 +172,8 @@ export class SearchNode {
this.matchedTraversals = priorNode.matchedTraversals.slice();
this.lastEdgeType = param2 as PathEdge;
const isInsertAfterDelete = priorNode.lastEdgeType == PathEdge.INSERTION && this.lastEdgeType == PathEdge.DELETION;
this.deleteAfterInsertEditPairs = priorNode.deleteAfterInsertEditPairs + (isInsertAfterDelete ? 1 : 0);
// Do NOT copy over _inputCost; this is a helper-constructor for methods
// building new nodes... which will have a different cost.
@ -180,6 +190,7 @@ export class SearchNode {
this.toKey = toKey || (x => x);
this.spaceId = spaceId;
this.lastEdgeType = PathEdge.ROOT;
this.deleteAfterInsertEditPairs = 0;
}
}
@ -189,7 +200,7 @@ export class SearchNode {
* by the current node.
*/
get editCount(): number {
return this.calculation.getHeuristicFinalCost();
return this.calculation.getHeuristicFinalCost() + this.deleteAfterInsertEditPairs;
}
/**