From 109f216c7bd8403f3078ed59af8164cfc675532b Mon Sep 17 00:00:00 2001 From: Joshua Horton Date: Tue, 19 Aug 2025 08:17:10 -0500 Subject: [PATCH 1/2] change(web): adjustments per PR review Removes duplicate line, fixes doc-comment. --- web/src/engine/common/web-utils/src/rewindable-cache.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/src/engine/common/web-utils/src/rewindable-cache.ts b/web/src/engine/common/web-utils/src/rewindable-cache.ts index edba06256c..eb439cde1a 100644 --- a/web/src/engine/common/web-utils/src/rewindable-cache.ts +++ b/web/src/engine/common/web-utils/src/rewindable-cache.ts @@ -88,8 +88,9 @@ export class RewindableCache { } /** - * Deletes all entries with a key less than the specified key, leaving - * the specified key as the most recent entry. + * Deletes all entries with a key greater than the specified key (which indicates + * the entry was first created more recently), leaving the specified key as + * the most recent entry. * @param key */ rewindTo(key: number) { @@ -106,7 +107,6 @@ export class RewindableCache { // It is safe to delete a key from a Set or Map while iterating over it in ES6+. // https://stackoverflow.com/a/28306768 map.delete(k); - map.delete(k); } } } From 5b379a82f4aa9d93f343bbc50d2410337a75e380 Mon Sep 17 00:00:00 2001 From: Joshua Horton Date: Tue, 19 Aug 2025 10:52:48 -0500 Subject: [PATCH 2/2] chore(web): remove extra duplicated line --- web/src/engine/common/web-utils/src/rewindable-cache.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/web/src/engine/common/web-utils/src/rewindable-cache.ts b/web/src/engine/common/web-utils/src/rewindable-cache.ts index eb439cde1a..c334e7f9d2 100644 --- a/web/src/engine/common/web-utils/src/rewindable-cache.ts +++ b/web/src/engine/common/web-utils/src/rewindable-cache.ts @@ -64,7 +64,6 @@ export class RewindableCache { if(map.size > this.maxSize) { const oldest = map.keys().next().value as number; map.delete(oldest); - map.delete(oldest); } } }