fix(linux): Address code review comments

This commit is contained in:
Eberhard Beilharz 2021-08-19 12:15:42 +02:00
parent f0c3280517
commit b51d0e0b00
No known key found for this signature in database
GPG key ID: 64A39A9E98B53105
7 changed files with 21 additions and 14 deletions

View file

@ -1,6 +1,6 @@
c Description: Tests a simple deadkey rule in Unicode
c keys: [SHIFT K_6][K_A][SHIFT K_6][K_SHIFT][K_A][SHIFT K_6][RALT K_B][K_A][SHIFT K_6][K_CAPS][K_A]
c expected: pass.pass.pass.pass.
c keys: [SHIFT K_6][K_A]
c expected: \u00E2
c context:
store(&VERSION) '9.0'
@ -11,4 +11,4 @@ group(main) using keys
+ '^' > deadkey(1)
dk(1) + [K_A] > 'pass.'
dk(1) + 'a' > U+00E2

View file

@ -1,6 +1,6 @@
c Description: Tests Caps Lock
c keys: [K_1][SHIFT K_2][SHIFT K_3][K_A][SHIFT K_B][K_C][K_CAPS][K_D]
c expected: pass.pass.pass.pass.pass.pass.pass.
c keys: [K_1][SHIFT K_2][SHIFT K_3][K_A][SHIFT K_B]
c expected: pass.pass.pass.pass.pass.
c capsLock: 1
c context:
@ -24,11 +24,3 @@ group(Main) using keys
+ 'b' > 'pass.'
+ 'B' > 'fail.'
c Caps is on. The virtual key should match.
+ [SHIFT K_C] > 'fail.'
+ [K_C] > 'pass.'
c Caps was pressed and released, so Caps is now off. The virtual key should still match.
+ [SHIFT K_D] > 'fail.'
+ [K_D] > 'pass.'

View file

@ -0,0 +1,14 @@
c Description: Tests that modifier keys don't reset context (#5591)
c keys: [K_A][K_SHIFT][K_B][K_A][K_ALT][K_B][K_A][K_CAPS][K_B]
c expected: pass.pass.pass.
c context:
store(&VERSION) '9.0'
begin unicode > use(main)
group(main) using keys
+ [K_A] > 'a'
'a' + [K_B] > 'pass.'

View file

@ -69,7 +69,8 @@ tests = [
'044 - if and context',
'045 - deadkey and context',
'046 - deadkey and contextex',
'047 - caps always off initially on'
'047 - caps always off initially on',
'048 - modifier keys keep context'
]
if build_machine.system() == 'windows'