Merge pull request #6886 from keymanapp/fix/web/6885-unbound-banner-event-handler

fix(web): post-keystroke processing after use of pred. text selection
This commit is contained in:
Joshua Horton 2022-07-04 15:03:20 +07:00 committed by GitHub
commit ae2acfb913
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -399,7 +399,7 @@ namespace com.keyman.osk {
* @param outputTarget
* @returns true
*/
suggestionApplied(outputTarget: text.OutputTarget): boolean {
suggestionApplied: (outputTarget: text.OutputTarget) => boolean = function(this: SuggestionBanner, outputTarget: text.OutputTarget) {
const keyman = com.keyman.singleton;
// Tell the keyboard that the current layer has not changed
keyman.core.keyboardProcessor.newLayerStore.set('');
@ -411,7 +411,7 @@ namespace com.keyman.osk {
?.finalize(keyman.core.keyboardProcessor, outputTarget, true);
return true;
};
}.bind(this);
postConfigure() {
let keyman = com.keyman.singleton;
@ -427,6 +427,7 @@ namespace com.keyman.osk {
keyman.core.languageProcessor.removeListener('suggestionsready', manager.updateSuggestions);
keyman.core.languageProcessor.removeListener('tryaccept', manager.tryAccept);
keyman.core.languageProcessor.removeListener('tryrevert', manager.tryRevert);
keyman.core.languageProcessor.removeListener('suggestionapplied', this.suggestionApplied);
}
}