From adfb4ab2313bcbd3eebd2e397a83c13044d2159f Mon Sep 17 00:00:00 2001
From: "Joshua A. Horton" <joshua_horton@sil.org>
Date: Tue, 30 May 2023 12:55:49 +0700
Subject: [PATCH] chore(web): general cleanup

---
 web/src/app/browser/src/keymanEngine.ts       |  2 +-
 web/src/engine/namespaced-main/kmwbase.ts     | 40 -------------------
 .../web/build-visual-keyboard/index.html      |  5 ---
 web/src/test/manual/web/inline-osk/index.html |  2 +-
 4 files changed, 2 insertions(+), 47 deletions(-)

diff --git a/web/src/app/browser/src/keymanEngine.ts b/web/src/app/browser/src/keymanEngine.ts
index 3ab724d74c..d5ee66502b 100644
--- a/web/src/app/browser/src/keymanEngine.ts
+++ b/web/src/app/browser/src/keymanEngine.ts
@@ -535,7 +535,7 @@ export default class KeymanEngine extends KeymanEngineBase<BrowserConfiguration,
     PKbd = PKbd || this.core.activeKeyboard;
     let Pstub = this.keyboardRequisitioner.cache.getStub(PKbd);
 
-    // help.keyman.com will (lkudingly) set this function in place to specify the desired
+    // help.keyman.com will set this function in place to specify the desired
     // dimensions for the documentation-keyboards, so we'll give it priority.  One of those
     // "temporary" (but actually permanent) solutions from yesteryear.
     //
diff --git a/web/src/engine/namespaced-main/kmwbase.ts b/web/src/engine/namespaced-main/kmwbase.ts
index 71ce63c93a..27d8ac9ba0 100644
--- a/web/src/engine/namespaced-main/kmwbase.ts
+++ b/web/src/engine/namespaced-main/kmwbase.ts
@@ -296,46 +296,6 @@ namespace com.keyman {
      * @param {number=}  dr  Number of post-caret characters to delete
      */
     ['oninserttext']: (dn: number, s: string, dr?: number) => void;
-
-    /**
-     * Create copy of the OSK that can be used for embedding in documentation or help
-     * The currently active keyboard will be returned if PInternalName is null
-     *
-     *  @param  {string}          PInternalName   internal name of keyboard, with or without Keyboard_ prefix
-     *  @param  {number}          Pstatic         static keyboard flag  (unselectable elements)
-     *  @param  {string=}         argFormFactor   layout form factor, defaulting to 'desktop'
-     *  @param  {(string|number)=}  argLayerId    name or index of layer to show, defaulting to 'default'
-     *  @return {Object}                          DIV object with filled keyboard layer content
-     */
-    ['BuildVisualKeyboard'](PInternalName, Pstatic, argFormFactor, argLayerId): HTMLElement {
-      let PKbd: com.keyman.keyboards.Keyboard = null;
-
-      if(PInternalName != null) {
-        var p=PInternalName.toLowerCase().replace('keyboard_','');
-        var keyboardsList = this.keyboardManager.keyboards;
-
-        for(let Ln=0; Ln<keyboardsList.length; Ln++) {
-          if(p == keyboardsList[Ln]['KI'].toLowerCase().replace('keyboard_','')) {
-            // Requires the Keyboard wrapping object now.
-            PKbd = new com.keyman.keyboards.Keyboard(keyboardsList[Ln]);
-            break;
-          }
-        }
-      }
-
-      PKbd = PKbd || this.core.activeKeyboard;
-
-      // help.keyman.com will (lkudingly) set this function in place to specify the desired
-      // dimensions for the documentation-keyboards, so we'll give it priority.  One of those
-      // "temporary" (but actually permanent) solutions from yesteryear.
-      //
-      // Note that the main intended use of that function is for embedded KMW on the mobile apps...
-      // but they never call `BuildVisualKeyboard`, so it's all good.
-      const getOskHeight = this['getOskHeight'];
-      let targetHeight = (typeof getOskHeight == 'function' ? getOskHeight() : null) || this.osk.computedHeight || 200;
-
-      return com.keyman.osk.VisualKeyboard.buildDocumentationKeyboard(PKbd, argFormFactor, argLayerId, targetHeight);
-    }
   }
 }
 
diff --git a/web/src/test/manual/web/build-visual-keyboard/index.html b/web/src/test/manual/web/build-visual-keyboard/index.html
index 8cca466d8a..d2bed2610e 100644
--- a/web/src/test/manual/web/build-visual-keyboard/index.html
+++ b/web/src/test/manual/web/build-visual-keyboard/index.html
@@ -90,11 +90,6 @@
         // highly-controlled environment.
         await Promise.resolve();
 
-        // // Grab the stylesheet element that was inserted; there should be no intervening additions,
-        // // so the newly-added stylesheet element should be the last element in the <head> section.
-        // const stylesheet = keyman.osk._Box.lastChild;
-        // stylesheet.parentElement.removeChild(stylesheet);
-
         shadowfy(container);
       }
 
diff --git a/web/src/test/manual/web/inline-osk/index.html b/web/src/test/manual/web/inline-osk/index.html
index 5b7e561edc..87c68ade8a 100644
--- a/web/src/test/manual/web/inline-osk/index.html
+++ b/web/src/test/manual/web/inline-osk/index.html
@@ -52,7 +52,7 @@
 
       var kmw=window.keyman;
       kmw.init({
-		    attachType:'auto',
+        attachType:'auto',
         resources:'../../resources'
       }).then(function() {
         setOSK('windows');