erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-05 00:15:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

chore(ios): Cleanup RELEASE_OEM_FIRSTVOICES var in build.sh scripts

Browse source 
Fixes #9051

* Fixes unbound variable in tools/prepRelease.sh
* Checks `RELEASE_OEM_FIRSTVOICES` env var for build targets
This commit is contained in:
Darcy Wong 2026-02-20 10:34:55 +07:00
parent 65408863b5
commit a6d92d30f4
2 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
ios/build.sh
View file

@ -1,4 +1,12 @@
#!/usr/bin/env bash #!/usr/bin/env bash
#
# Build Keyman Engine for iPhone and iPad, Keyman for iPhone and iPad, OEM FirstVoices iOS app,
# Samples: KMSample1 and KMSample2
#
# OEM FirstVoices iOS app requires the following env vars set:
# RELEASE_OEM should be set
# RELEASE_OEM_FIRSTVOICES should be true
## START STANDARD BUILD SCRIPT INCLUDE ## START STANDARD BUILD SCRIPT INCLUDE
# adjust relative paths as necessary # adjust relative paths as necessary
THIS_SCRIPT="$(readlink -f "${BASH_SOURCE[0]}")" THIS_SCRIPT="$(readlink -f "${BASH_SOURCE[0]}")"
@ -7,6 +15,17 @@ THIS_SCRIPT="$(readlink -f "${BASH_SOURCE[0]}")"
. "$KEYMAN_ROOT/resources/build/utils.inc.sh" . "$KEYMAN_ROOT/resources/build/utils.inc.sh"
#
# Restrict available OEM publish targets to those that can be built on the current system
#
oemtargets=()
if [[ ! -z "${RELEASE_OEM+x}" ]]; then
if [[ "${RELEASE_OEM_FIRSTVOICES-false}" = true ]]; then
oemtargets+=(":fv=../oem/firstvoices/ios Builds OEM FirstVoices for iOS platforms")
fi
fi
builder_describe "Builds Keyman Engine and the Keyman app for use on iOS devices - iPhone and iPad." \ builder_describe "Builds Keyman Engine and the Keyman app for use on iOS devices - iPhone and iPad." \
"@/resources/tools/check-markdown test:help" \ "@/resources/tools/check-markdown test:help" \
"clean" \ "clean" \
@ -18,7 +37,7 @@ builder_describe "Builds Keyman Engine and the Keyman app for use on iOS devices
":help Online documentation" \ ":help Online documentation" \
":sample1=samples/KMSample1 Builds the first KeymanEngine sample app" \ ":sample1=samples/KMSample1 Builds the first KeymanEngine sample app" \
":sample2=samples/KMSample2 Builds the second KeymanEngine sample app" \ ":sample2=samples/KMSample2 Builds the second KeymanEngine sample app" \
":fv=../oem/firstvoices/ios Builds OEM FirstVoices for iOS platforms" \ "${oemtargets[@]}" \
"--sim-artifact+ Also outputs a simulator-friendly test artifact corresponding to the build" "--sim-artifact+ Also outputs a simulator-friendly test artifact corresponding to the build"
builder_parse "$@" builder_parse "$@"

4
ios/tools/prepRelease.sh
View file

@ -105,7 +105,7 @@ cd "$WORK_DIR"
# FirstVoices app # FirstVoices app
# #
if [ "${RELEASE_OEM_FIRSTVOICES}" = true ]; then if [[ "${RELEASE_OEM_FIRSTVOICES-false}" = true ]]; then
FIRSTVOICESAPP_IPA="../oem/firstvoices/ios/build/Build/Products/Release-iphoneos/FirstVoices.ipa" FIRSTVOICESAPP_IPA="../oem/firstvoices/ios/build/Build/Products/Release-iphoneos/FirstVoices.ipa"
FIRSTVOICESAPP_IPA_DST="firstvoices-ios-${KEYMAN_VERSION_FOR_FILENAME}.ipa" FIRSTVOICESAPP_IPA_DST="firstvoices-ios-${KEYMAN_VERSION_FOR_FILENAME}.ipa"
@ -129,6 +129,6 @@ fi
write_download_info "${UPLOAD_DIR}" "${KMEI_DST_NAME}" "Keyman Engine for iOS" zip ios write_download_info "${UPLOAD_DIR}" "${KMEI_DST_NAME}" "Keyman Engine for iOS" zip ios
write_download_info "${UPLOAD_DIR}" "${KEYMANAPP_IPA_DST}" "Keyman for iPhone and iPad" ipa ios write_download_info "${UPLOAD_DIR}" "${KEYMANAPP_IPA_DST}" "Keyman for iPhone and iPad" ipa ios
if [[ ${RELEASE_OEM_FIRSTVOICES} = true ]]; then if [[ ${RELEASE_OEM_FIRSTVOICES-false} = true ]]; then
write_download_info "${UPLOAD_DIR}" "${FIRSTVOICESAPP_IPA_DST}" "FirstVoices Keyboards" ipa ios write_download_info "${UPLOAD_DIR}" "${FIRSTVOICESAPP_IPA_DST}" "FirstVoices Keyboards" ipa ios
fi fi