From c72d761e119c1f04cf9e8e0fd9d1361f1e328612 Mon Sep 17 00:00:00 2001 From: jahorton Date: Thu, 16 Jun 2022 10:13:50 +0700 Subject: [PATCH 1/4] fix(web): key tip constraint logic requires .bottom CSS --- web/source/osk/browser/keytip.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/source/osk/browser/keytip.ts b/web/source/osk/browser/keytip.ts index fe5c7dd80d..e6a980c6a2 100644 --- a/web/source/osk/browser/keytip.ts +++ b/web/source/osk/browser/keytip.ts @@ -78,7 +78,7 @@ namespace com.keyman.osk.browser { let canvasWidth = xWidth + Math.ceil(xWidth * 0.3) * 2; let canvasHeight = Math.ceil(2.3 * xHeight) + (ySubPixelPadding); // - kts.top = Math.floor(y - canvasHeight) + 'px'; + kts.bottom = Math.floor(keyman.osk.computedHeight - y) + 'px'; kts.textAlign = 'center'; kts.overflow = 'visible'; kts.fontFamily = util.getStyleValue(kc,'font-family'); From d7a205508ff27e8da7b2915c594ea9cd893f33a5 Mon Sep 17 00:00:00 2001 From: jahorton Date: Thu, 16 Jun 2022 15:00:44 +0700 Subject: [PATCH 2/4] fix(web): 'auto' actually mattered --- web/source/osk/browser/keytip.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/web/source/osk/browser/keytip.ts b/web/source/osk/browser/keytip.ts index e6a980c6a2..7404edba3c 100644 --- a/web/source/osk/browser/keytip.ts +++ b/web/source/osk/browser/keytip.ts @@ -78,6 +78,7 @@ namespace com.keyman.osk.browser { let canvasWidth = xWidth + Math.ceil(xWidth * 0.3) * 2; let canvasHeight = Math.ceil(2.3 * xHeight) + (ySubPixelPadding); // + kts.top = 'auto'; kts.bottom = Math.floor(keyman.osk.computedHeight - y) + 'px'; kts.textAlign = 'center'; kts.overflow = 'visible'; From 3aa4ea77d41af988d95e809e05e05517f7c1148b Mon Sep 17 00:00:00 2001 From: jahorton Date: Fri, 17 Jun 2022 12:35:59 +0700 Subject: [PATCH 3/4] fix(web): android keytip-cap lacked styling; was invisible --- web/source/resources/osk/kmwosk.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/web/source/resources/osk/kmwosk.css b/web/source/resources/osk/kmwosk.css index 9c9bde7198..4e2d72feac 100644 --- a/web/source/resources/osk/kmwosk.css +++ b/web/source/resources/osk/kmwosk.css @@ -402,6 +402,10 @@ div.android div.kmw-keytip-tip { background: #999; } +div.android div.kmw-keytip-cap { + background: #999; +} + /* Dark mode - ensure text is colored appropriately for key tips. */ @media (prefers-color-scheme: dark) { div.ios div.kmw-keytip { From 9753e93116634a65421056998e66a7777e80553e Mon Sep 17 00:00:00 2001 From: jahorton Date: Fri, 17 Jun 2022 12:56:44 +0700 Subject: [PATCH 4/4] fix(android): missed a few CSS properties --- web/source/resources/osk/kmwosk.css | 3 +++ 1 file changed, 3 insertions(+) diff --git a/web/source/resources/osk/kmwosk.css b/web/source/resources/osk/kmwosk.css index 4e2d72feac..23c6327653 100644 --- a/web/source/resources/osk/kmwosk.css +++ b/web/source/resources/osk/kmwosk.css @@ -403,7 +403,10 @@ div.android div.kmw-keytip-tip { } div.android div.kmw-keytip-cap { + position: absolute; background: #999; + border-radius: 0 0 5px 5px; + border-bottom: solid 1px #8a8d90 } /* Dark mode - ensure text is colored appropriately for key tips. */