From 94433f74eb3d8168b8400a7cc78be82c67f596a0 Mon Sep 17 00:00:00 2001 From: "Joshua A. Horton" Date: Tue, 5 Mar 2024 12:23:29 +0700 Subject: [PATCH] fix(developer): search-term quote replacement was not global --- developer/src/kmc-model/src/model-defaults.ts | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/developer/src/kmc-model/src/model-defaults.ts b/developer/src/kmc-model/src/model-defaults.ts index 0fb44ffa5b..07213f43a8 100644 --- a/developer/src/kmc-model/src/model-defaults.ts +++ b/developer/src/kmc-model/src/model-defaults.ts @@ -25,11 +25,9 @@ export function defaultSearchTermToKey(wordform: string): string { // Remove any combining diacritics (if input is in NFKD) .replace(/[\u0300-\u036F]/g, '') // Replace directional quotation marks with plain apostrophes - .replace(/‘/, "'") - .replace(/’/, "'") + .replace(/[‘’]/g, "'") // Also double-quote marks. - .replace(/“/, '"') - .replace(/”/, '"'); + .replace(/[“”]/g, '"'); } /** @@ -62,14 +60,14 @@ export function defaultCasedSearchTermToKey(wordform: string, applyCasing: Casin // Remove any combining diacritics (if input is in NFKD) .replace(/[\u0300-\u036F]/g, '') ) // end of `Array.from` - .map(function(c) { return applyCasing('lower', c)}) + .map(function(c) { + return applyCasing('lower', c) + }) .join('') // Replace directional quotation marks with plain apostrophes - .replace(/‘/, "'") - .replace(/’/, "'") + .replace(/[‘’]/g, "'") // Also double-quote marks. - .replace(/“/, '"') - .replace(/”/, '"'); + .replace(/[“”]/g, '"'); } /**