From 910e8d65b9250d944d82d066cf21990bd4e2f704 Mon Sep 17 00:00:00 2001
From: jahorton <jahorton@sil.org>
Date: Wed, 26 May 2021 12:21:20 +0700
Subject: [PATCH] change(ios): -no-codesign -> .xcarchive by default

---
 ios/kmbuild.sh | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/ios/kmbuild.sh b/ios/kmbuild.sh
index fe69db612a..d0d43c2b77 100755
--- a/ios/kmbuild.sh
+++ b/ios/kmbuild.sh
@@ -60,6 +60,7 @@ CLEAN_ONLY=false
 CONFIG=Release
 DO_KMP_DOWNLOADS=false
 CODE_SIGN=
+DO_CODE_SIGN=true
 
 # Parse args
 while [[ $# -gt 0 ]] ; do
@@ -77,7 +78,7 @@ while [[ $# -gt 0 ]] ; do
             ;;
         -no-codesign)
             CODE_SIGN="CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO ${DEV_TEAM:-} CODE_SIGN_ENTITLEMENTS= CODE_SIGNING_ALLOWED=NO"
-            DO_ARCHIVE=false
+            DO_CODE_SIGN=false
             ;;
         -no-archive)
             DO_ARCHIVE=false
@@ -281,7 +282,7 @@ if [ $DO_KEYMANAPP = true ]; then
   else
     # Time to prepare the deployment archive data.
     echo ""
-    echo "Preparing .ipa file for deployment."
+    echo "Preparing .xcarchive."
     xcodebuild $XCODEFLAGS_EXT -scheme Keyman \
                 -archivePath $ARCHIVE_PATH \
                 archive -allowProvisioningUpdates \
@@ -292,9 +293,12 @@ if [ $DO_KEYMANAPP = true ]; then
 
     assertDirExists "$ARCHIVE_PATH"
 
-    xcodebuild $XCODEFLAGS -exportArchive -archivePath $ARCHIVE_PATH \
-                -exportOptionsPlist exportAppStore.plist \
-                -exportPath $BUILD_PATH/${CONFIG}-iphoneos -allowProvisioningUpdates
+    if [ $DO_CODE_SIGN == true ]; then
+      echo "Preparing .ipa file for deployment"
+      xcodebuild $XCODEFLAGS -exportArchive -archivePath $ARCHIVE_PATH \
+                  -exportOptionsPlist exportAppStore.plist \
+                  -exportPath $BUILD_PATH/${CONFIG}-iphoneos -allowProvisioningUpdates
+    fi
   fi
 
   echo ""