erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-25 17:57:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

chore(android): address code review comments
Some checks failed
Keyman Build Summary / Summarize build status checks (push) Has been cancelled
Details

Browse source 
Sample apps should not reference the project but the .aar instead.
This commit is contained in:
Eberhard Beilharz 2026-08-20 12:10:57 +02:00
parent d74e2cd3a4
commit 8f62333e99
No known key found for this signature in database
GPG key ID: E9140597606020D3
6 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
android/Samples/KMSample1/app/build.gradle
View file

@ -59,7 +59,8 @@ dependencies {
implementation 'androidx.appcompat:appcompat:1.7.0'
implementation 'androidx.constraintlayout:constraintlayout:2.2.1'
implementation 'com.google.android.material:material:1.12.0'
implementation project(':keyman-engine')
// intentionally not referencing the keyman-engine project but the .aar instead
implementation files('libs/keyman-engine.aar')
implementation 'androidx.preference:preference:1.2.1'
implementation 'androidx.webkit:webkit:1.14.0'
}

2
android/Samples/KMSample1/build.gradle
View file

@ -7,7 +7,6 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:8.9.2'
classpath 'name.remal:gradle-plugins:1.9.2'
// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
@ -18,6 +17,5 @@ allprojects {
repositories {
google()
mavenCentral()
maven { url "https://jitpack.io" }
}
}

2
android/Samples/KMSample1/settings.gradle
View file

@ -1,3 +1 @@
include ':app'
include ':keyman-engine'
project(':keyman-engine').projectDir = new File(settingsDir, '../../KMEA/app')

3
android/Samples/KMSample2/app/build.gradle
View file

@ -59,7 +59,8 @@ dependencies {
implementation 'androidx.appcompat:appcompat:1.7.0'
implementation 'androidx.constraintlayout:constraintlayout:2.2.1'
implementation 'com.google.android.material:material:1.12.0'
implementation project(':keyman-engine')
// intentionally not referencing the keyman-engine project but the .aar instead
implementation files('libs/keyman-engine.aar')
implementation 'androidx.preference:preference:1.2.1'
implementation 'androidx.webkit:webkit:1.14.0'
}

2
android/Samples/KMSample2/build.gradle
View file

@ -7,7 +7,6 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:8.9.2'
classpath 'name.remal:gradle-plugins:1.9.2'
// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
@ -18,6 +17,5 @@ allprojects {
repositories {
google()
mavenCentral()
maven { url "https://jitpack.io" }
}
}

2
android/Samples/KMSample2/settings.gradle
View file

@ -1,3 +1 @@
include ':app'
include ':keyman-engine'
project(':keyman-engine').projectDir = new File(settingsDir, '../../KMEA/app')