From 913cb5d18a7be23bf33c0573374c5bfe70a4ea1c Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Wed, 2 Aug 2023 18:55:22 -0500 Subject: [PATCH 1/2] Apply suggestions from code review Co-authored-by: Marc Durdin --- core/include/ldml/keyboardprocessor_ldml.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/include/ldml/keyboardprocessor_ldml.ts b/core/include/ldml/keyboardprocessor_ldml.ts index c894ec2b2d..246beed106 100644 --- a/core/include/ldml/keyboardprocessor_ldml.ts +++ b/core/include/ldml/keyboardprocessor_ldml.ts @@ -615,9 +615,9 @@ class Constants { } // ---- marker stuff ---- - /** == UC_SENTINEL, first item of a */ + /** == kmx_file.UC_SENTINEL, always followed by `marker_code`, marker index 0x0001-0xfffe */ readonly marker_sentinel = 0xFFFF; - /** == CODE_DEADKEY */ + /** == kmx_file.CODE_DEADKEY */ readonly marker_code_deadkey = 0x0008; /** minimum usable marker index */ readonly marker_min_index = 0x0001; From af05f5155e254f387f02a1c4bd4e66d64e69e244 Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Thu, 3 Aug 2023 12:38:05 -0500 Subject: [PATCH 2/2] chore(developer): test fix For: #9119 --- developer/src/kmc-ldml/test/test-vars.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/developer/src/kmc-ldml/test/test-vars.ts b/developer/src/kmc-ldml/test/test-vars.ts index af81ca1ec6..3ab10a8939 100644 --- a/developer/src/kmc-ldml/test/test-vars.ts +++ b/developer/src/kmc-ldml/test/test-vars.ts @@ -191,8 +191,8 @@ describe('vars', function () { describe('should match some marker constants', () => { // neither of these live here, but, common/web/types does not import ldml-keyboard-constants otherwise. - assert.equal(constants.marker_sentinel, KMX.UC_SENTINEL); - assert.equal(constants.marker_code_deadkey, KMX.CODE_DEADKEY); + assert.equal(constants.marker_sentinel, KMX.KMXFile.UC_SENTINEL); + assert.equal(constants.marker_code_deadkey, KMX.KMXFile.CODE_DEADKEY); }); describe('markers', function () { this.slow(500); // 0.5 sec -- json schema validation takes a while