From 8390e7db966ce600792eecbe59f3b13bfe2d435b Mon Sep 17 00:00:00 2001 From: Marc Durdin Date: Fri, 3 Jul 2026 10:36:47 +0200 Subject: [PATCH] chore(developer): remove duplicated createWarningText post merge --- .../src/keylayout-to-kmn/kmn-file-writer.ts | 143 +----------------- 1 file changed, 2 insertions(+), 141 deletions(-) diff --git a/developer/src/kmc-convert/src/keylayout-to-kmn/kmn-file-writer.ts b/developer/src/kmc-convert/src/keylayout-to-kmn/kmn-file-writer.ts index 2b24ecc4b9..d4c661057c 100644 --- a/developer/src/kmc-convert/src/keylayout-to-kmn/kmn-file-writer.ts +++ b/developer/src/kmc-convert/src/keylayout-to-kmn/kmn-file-writer.ts @@ -1094,147 +1094,7 @@ export class KmnFileWriter { return resultWarningTextSet; } - /** - * @brief take a child object of RuleReview and return the appropriate warning message array - * @param inObj : an object containing filtered data for a specified comparison - * @param posWarning : index specifying to which element of the warning message array a warning message will be added: - * outMsg[0]: Warning for part 1 of a rule (e.g. modifier_prev_dk + key_prev_dk > prev_dk) - * outMsg[1]: Warning for part 2 of a rule (e.g. (prev_dk +) modifier_dk + key_dk > dk) - * outMsg[2]: Warning for part 3 of a rule (e.g. (dk +) modifier+key > output) - * see here on parts of a rule: - * https://docs.google.com/document/d/12J3NGO6RxIthCpZDTR8FYSRjiMgXJDLwPY2z9xqKzJ0/edit?tab=t.0#heading=h.16sx096j6jmy - * @return outMsg the warning message array for all parts - */ - public createWarningText(inObj: RuleReview, posWarning: number = 2): string[] { - - const outMsg = [...inObj.warningMessages]; - - if (inObj.compare_type === 'unav_C0_C1') { - outMsg[posWarning] = 'unavailable modifier '; - } - - if (inObj.compare_type === 'unav_C2') { - // if the dk is unavailable, the modifiers of the dependant C0 rule will get a warning 'unavailable superior rule ' - if (inObj.Dk_modifier) { - outMsg[1] = 'unavailable modifier '; - outMsg[2] = 'unavailable superior rule ( [' - + inObj.Dk_modifier + ' ' - + inObj.Dk_key - + '] > dk(' - + inObj.dk_prefix[1] - + inObj.dk_id[1] - + ') ) : '; - } - - if (inObj.modifier) { - outMsg[2] = 'unavailable modifier '; - } - } - - if (inObj.compare_type === 'unav_C3') { - - // if the dk is unavailable, the modifiers of the dependant C0 rule will get a warning 'unavailable superior rule ' - if (inObj.prevDk_modifier) { - outMsg[0] = 'unavailable modifier '; - outMsg[1] = 'unavailable superior rule ( [' - + inObj.prevDk_modifier + ' ' - + inObj.prevDk_key - + '] > dk(' - + inObj.dk_prefix[0] - + inObj.dk_id[0] - + ') ) : '; - } - - - // if the dk is unavailable, the modifiers of the dependant C0 rule will get a warning 'unavailable superior rule ' - if (inObj.Dk_modifier) { - outMsg[1] += 'unavailable modifier '; - outMsg[2] = 'unavailable superior rule ( [' - + inObj.Dk_modifier + ' ' - + inObj.Dk_key - + '] > dk(' - + inObj.dk_prefix[1] - + inObj.dk_id[1] - + ') ) : '; - } - - if (inObj.modifier) { - outMsg[2] = 'unavailable modifier '; - } - } - - if (inObj.compare_type === 'amb_1_1' || inObj.compare_type === 'dup_1_1') { - - outMsg[posWarning] = inObj.warningMessages[posWarning] - + ((inObj.type === 'AmbiguousRule') ? 'ambiguous ' : 'duplicate ') + 'rule: ' - + (inObj.isEarlier ? 'earlier' : 'later') - + ': [' + inObj.modifier + ' ' + inObj.key + '] > \'' - + inObj.output + '\' '; - } - - - if (inObj.compare_type === 'amb_2_2' || inObj.compare_type === 'dup_2_2' - || inObj.compare_type === 'amb_2_1' - || inObj.compare_type === 'amb_2_4') { - - const textsegment = ( - ((inObj.type === 'AmbiguousRule') ? 'ambiguous ' : 'duplicate ') + 'rule: ' - + (inObj.isEarlier ? 'earlier' : 'later') - + ': [' + inObj.Dk_modifier + ' ' + inObj.Dk_key + '] > dk(' - + inObj.dk_prefix[1] + inObj.dk_id[1] + ') '); - - if (outMsg[posWarning].indexOf(textsegment) === -1) - outMsg[posWarning] += textsegment; - } - - - if (inObj.compare_type === 'amb_4_4' || inObj.compare_type === 'dup_4_4' - || inObj.compare_type === 'amb_4_1' - || inObj.compare_type === 'amb_4_2') { - - const textsegment = ( - ((inObj.type === 'AmbiguousRule') ? 'ambiguous ' : 'duplicate ') + 'rule: ' - + (inObj.isEarlier ? 'earlier' : 'later') - + ': [' + inObj.prevDk_modifier + ' ' + inObj.prevDk_key + '] > dk(' - + inObj.dk_prefix[0] + inObj.dk_id[0] + ') '); - - if (outMsg[posWarning].indexOf(textsegment) === -1) - outMsg[posWarning] += textsegment; - } - - - if (inObj.compare_type === 'amb_5_5' || inObj.compare_type === 'dup_5_5') { - - const textsegment = ( - ((inObj.type === 'AmbiguousRule') ? 'ambiguous ' : 'duplicate ') + 'rule: ' - + (inObj.isEarlier ? 'earlier' : 'later') - + ': dk(' + inObj.dk_prefix[0] + inObj.dk_id[0] + ") + [" - + inObj.Dk_modifier + " " + inObj.Dk_key + "] > " - + 'dk(' + inObj.dk_prefix[1] + inObj.dk_id[1] + ") "); - - if (outMsg[1].indexOf(textsegment) === -1) - outMsg[1] += textsegment; - } - - - if (inObj.compare_type === 'amb_6_3' || inObj.compare_type === 'dup_6_3' - || inObj.compare_type === 'amb_3_3' || inObj.compare_type === 'dup_3_3' - || inObj.compare_type === 'amb_6_6' || inObj.compare_type === 'dup_6_6') { - - const textsegment = ( - ((inObj.type === 'AmbiguousRule') ? 'ambiguous ' : 'duplicate ') + 'rule: ' - + (inObj.isEarlier ? 'earlier' : 'later') - + ': dk(' + inObj.dk_prefix[1] + inObj.dk_id[1] + ") + [" - + inObj.modifier + " " + inObj.key + "] > \'" - + inObj.output + "\' "); - - if (outMsg[posWarning].indexOf(textsegment) === -1) - outMsg[posWarning] += textsegment; - } - - return outMsg; - } - /** +/** * @brief member function to write a character as Unicode Character or Unicode Codepoint depending on the character that is to be written * @param ctr : string - the character to be written * @return a string containing the Unicode representation of the control character. @@ -1404,6 +1264,7 @@ export class KmnFileWriter { } return undefined; } + /** @internal */ public unitTestEndpoints = { reviewRules: this.reviewRules.bind(this),