erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-09-14 19:47:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Merge pull request #7581 from keymanapp/fix/android/empty-play-store-notes

Browse source 
fix(android): Handle empty Play Store release notes
This commit is contained in:
Darcy Wong 2022-11-01 10:34:36 +07:00 • committed by GitHub
commit 820e228911
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
android/KMAPro/build-play-store-notes.sh
View file

@ -29,8 +29,15 @@ echo "" > "$PLAY_RELEASE_NOTES"
# Copy whatsnew.md to release notes 1 line at a time,
# filtering for lines that start with "*".
# Pad release notes if whatsnew.md doesn't have any line items
# Play Store release notes have a limit of 500 characters
FILTERED_LINES=`grep '^\s*\*.*$' "$KEYMAN_ROOT/android/help/about/whatsnew.md"`
DEFAULT_RELEASE_NOTE="* Additional bug fixes and improvements"
FILTERED_LINES=$( grep '^\s*\*.*$' "$KEYMAN_ROOT/android/help/about/whatsnew.md" || [[ $? == 1 ]] ) # Continue if grep has no matches
if [ -z "$FILTERED_LINES" ]; then
FILTERED_LINES="$DEFAULT_RELEASE_NOTE"
warn "Warning: whatsnew.md empty so using default release note: '$FILTERED_LINES'"
fi
IFS=$'\n' # Change IFS to new line
for line in $FILTERED_LINES
do
@ -42,7 +49,7 @@ do
else
# 450 chars reached
warn "Warning: Play Store release notes approaching 500 character limit"
echo '* Additional bug fixes and improvements' >> $PLAY_RELEASE_NOTES
echo "$DEFAULT_RELEASE_NOTE" >> $PLAY_RELEASE_NOTES
break
fi
done