erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-05 00:15:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

chore(android): address review comments
Some checks failed
Keyman Build Summary / Summarize build status checks (push) Has been cancelled
Details

Browse source 
Also add logging if unit test fails
This commit is contained in:
Marc Durdin 2026-06-30 15:12:59 +02:00
parent 7155e9d722
commit 809a3cad4a
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
android/KMEA/app/src/main/java/com/keyman/engine/util/KMLog.java
View file

@ -117,8 +117,8 @@ public final class KMLog {
// Sentry does limit the size of messages... so let's just
// keep 10 entries and call it a day.
int limit = Math.min(rawTrace.length, 10 + skipCount);
if(rawTrace.length > skipCount) {
int limit = Math.min(rawTrace.length, 10 + skipCount);
String[] trace = new String[limit - skipCount];
for (int i = skipCount; i < limit; i++) {
trace[i-skipCount] = rawTrace[i].toString();
@ -190,7 +190,7 @@ public final class KMLog {
String errorMsg = "";
try {
if (msg != null && !msg.isEmpty()) {
errorMsg = msg + "\n" + e.toString();
errorMsg = msg + "\n" + e;
} else if (e != null) {
errorMsg = e.toString();
}
@ -206,6 +206,8 @@ public final class KMLog {
}
}
Log.e(tag, errorMsg);
if (!canLogToSentry()) {
return;
}
@ -215,12 +217,18 @@ public final class KMLog {
tagDebugInfo();
try {
if(obj != null && objName != null) {
Sentry.setTag(objName, obj.toString());
Sentry.setExtra(objName, obj.toString());
}
} catch(Exception innerE) {
Sentry.captureException(innerE);
}
Sentry.captureException(e);
if(obj != null && objName != null) {
// And remove the exception-specific tagged data, lest it also be
// tracked on subsequent errors not associated with the current call.
Sentry.removeExtra(objName);
}
});
}
}

2
android/KMEA/app/src/test/java/com/keyman/engine/util/FileUtilsTest.java
View file

@ -23,7 +23,7 @@ public class FileUtilsTest {
List<ShadowLog.LogItem> logs = ShadowLog.getLogs();
// The logs contain type 4, but we only care about type 6 for connection messages
Assert.assertEquals(2, logs.size());
Assert.assertEquals("Size did not match 2: " + logs.toString(), 2, logs.size());
Assert.assertEquals("Connection", logs.get(0).tag);
Assert.assertEquals("Initialization failed:\njava.net.MalformedURLException: no protocol: invalidURL", logs.get(0).msg);