erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-05 08:25:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

chore(web): suggestions from pr review

Browse source
This commit is contained in:
Joshua A. Horton 2024-01-23 10:44:55 +07:00
parent c632d1f419
commit 7c507abef2
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
web/common.inc.sh
View file

@ -103,8 +103,6 @@ function test-headless() {
# if the command is started within the appropriate subfolder.
pushd "${TEST_BASE}" > /dev/null
TEST_BASE=
else
TEST_BASE="${TEST_BASE}/"
fi
if [[ -e .c8rc.json ]]; then

12
web/src/test/auto/headless/app/browser/hardware-event-processing.tests.ts
View file

@ -554,8 +554,10 @@ describe("app/browser: hardware event processing", () => {
'us'
);
// Legacy keyboards expect this to be false; this acts as a filter for legacy keyboards
// to prevent key processing with held CTRL / ALT.
// KMW 1.0 keyboards expect this to be false; setting it to true prevents the keyboard
// from matching the event to a rule. As KMW 1.0 keyboards shouldn't handle modifiers
// other than shift, this acts as a filter to prevent rule processing for the unsupported
// modifier.
assert.isTrue(finalKeyEvent.LisVirtualKey);
assert.equal(finalKeyEvent.Lcode, KeyCodes.K_A);
assert.equal(finalKeyEvent.Lmodifiers, ModifierCodes.ALT);
@ -579,8 +581,10 @@ describe("app/browser: hardware event processing", () => {
'us'
);
// Legacy keyboards expect this to be false; this acts as a filter for legacy keyboards
// to prevent key processing with held CTRL / ALT.
// KMW 1.0 keyboards expect this to be false; setting it to true prevents the keyboard
// from matching the event to a rule. As KMW 1.0 keyboards shouldn't handle modifiers
// other than shift, this acts internally as a filter to prevent rule matching for
// events with the unsupported modifier.
assert.isTrue(finalKeyEvent.LisVirtualKey);
assert.equal(finalKeyEvent.Lcode, KeyCodes.K_A);
assert.equal(finalKeyEvent.Lmodifiers, ModifierCodes.LALT);