erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-27 02:37:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Merge pull request #4443 from keymanapp/chore/ios/case-statement-cleanup

Browse source 
chore(ios): Settings case-statement cleanup
This commit is contained in:
Joshua Horton 2021-02-10 12:24:08 +07:00 • committed by GitHub
commit 7aed5dc2d9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
ios/engine/KMEI/KeymanEngine/Classes/Settings/SettingsViewController.swift
View file

@ -146,9 +146,8 @@ open class SettingsViewController: UITableViewController {
switch(cellIdentifier) {
case "languages":
cell.accessoryType = .disclosureIndicator
break
case "showbanner":
cell.accessoryType = .none
let showBannerSwitch = UISwitch()
showBannerSwitch.translatesAutoresizingMaskIntoConstraints = false
@ -165,7 +164,6 @@ open class SettingsViewController: UITableViewController {
showBannerSwitch.centerYAnchor.constraint(equalTo: cell.layoutMarginsGuide.centerYAnchor).isActive = true
}
case "showgetstarted":
cell.accessoryType = .none
let showAgainSwitch = UISwitch()
showAgainSwitch.translatesAutoresizingMaskIntoConstraints = false
@ -182,7 +180,6 @@ open class SettingsViewController: UITableViewController {
showAgainSwitch.centerYAnchor.constraint(equalTo: cell.layoutMarginsGuide.centerYAnchor).isActive = true
}
case "enablecrashreporting":
cell.accessoryType = .none
let enableReportingSwitch = UISwitch()
enableReportingSwitch.translatesAutoresizingMaskIntoConstraints = false
@ -198,12 +195,8 @@ open class SettingsViewController: UITableViewController {
enableReportingSwitch.rightAnchor.constraint(equalTo: cell.layoutMarginsGuide.rightAnchor).isActive = true
enableReportingSwitch.centerYAnchor.constraint(equalTo: cell.layoutMarginsGuide.centerYAnchor).isActive = true
}
case "systemkeyboardsettings":
cell.accessoryType = .disclosureIndicator
case "installfile":
cell.accessoryType = .disclosureIndicator
case "forcederror":
cell.accessoryType = .disclosureIndicator
case "systemkeyboardsettings", "installfile", "forcederror":
break
default:
log.error("unknown cellIdentifier(\"\(cellIdentifier ?? "EMPTY")\")")
cell.accessoryType = .none
@ -252,8 +245,12 @@ open class SettingsViewController: UITableViewController {
override open func tableView(_ tableView: UITableView, willDisplay cell: UITableViewCell, forRowAt indexPath: IndexPath) {
cell.accessoryType = .none
// Remember, UITableViewCells may be reused, so we should always reset relevant properties.
cell.textLabel?.text = itemsArray[indexPath.row]["title"]
cell.detailTextLabel?.text = itemsArray[indexPath.row]["subtitle"]
cell.textLabel?.isEnabled = true
cell.tag = indexPath.row
cell.isUserInteractionEnabled = true
@ -262,11 +259,14 @@ open class SettingsViewController: UITableViewController {
switch (cellIdentifier) {
case "languages", "installfile", "systemkeyboardsettings", "forcederror":
cell.accessoryType = .disclosureIndicator
cell.detailTextLabel?.isEnabled = true
case "enablecrashreporting":
cell.detailTextLabel?.isEnabled = true
break
default:
cell.textLabel?.isEnabled = true
case "showbanner", "showgetstarted":
cell.detailTextLabel?.isEnabled = false
default:
log.error("unknown cellIdentifier(\"\(cellIdentifier ?? "EMPTY")\")")
}
}