From 763f7abeb03dafbab1383da9d30a7af3434c19ff Mon Sep 17 00:00:00 2001
From: "Steven R. Loomis" <srl295@gmail.com>
Date: Thu, 28 Dec 2023 18:57:33 -0600
Subject: [PATCH] =?UTF-8?q?chore(core):=20failing=20test=20with=20markers?=
 =?UTF-8?q?=20=F0=9F=99=80?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- marker overrun! the 40th marker becomes a parenthesis, breaking regex

feat(core): ldml proper regex implementation 🙀🙀 #9121
---
 .../keyboards/k_211_marker_escape-test.xml    | 12 +++++++
 .../ldml/keyboards/k_211_marker_escape.xml    | 35 +++++++++++++++++++
 core/tests/unit/ldml/keyboards/meson.build    |  1 +
 3 files changed, 48 insertions(+)
 create mode 100644 core/tests/unit/ldml/keyboards/k_211_marker_escape-test.xml
 create mode 100644 core/tests/unit/ldml/keyboards/k_211_marker_escape.xml

diff --git a/core/tests/unit/ldml/keyboards/k_211_marker_escape-test.xml b/core/tests/unit/ldml/keyboards/k_211_marker_escape-test.xml
new file mode 100644
index 0000000000..f8eb8ed921
--- /dev/null
+++ b/core/tests/unit/ldml/keyboards/k_211_marker_escape-test.xml
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE keyboardTest3 SYSTEM "../../../../../resources/standards-data/ldml-keyboards/techpreview/dtd/ldmlKeyboardTest3.dtd">
+<keyboardTest3 conformsTo="techpreview">
+  <info keyboard="k_211_marker_escape.xml" author="Team Keyboard" name="marker" />
+  <tests name="marker-escape">
+    <test name="marker-escape0">
+      <keystroke key="z" />
+      <keystroke key="e" />
+      <check result="E" />
+    </test>
+  </tests>
+</keyboardTest3>
diff --git a/core/tests/unit/ldml/keyboards/k_211_marker_escape.xml b/core/tests/unit/ldml/keyboards/k_211_marker_escape.xml
new file mode 100644
index 0000000000..8ddae39819
--- /dev/null
+++ b/core/tests/unit/ldml/keyboards/k_211_marker_escape.xml
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+  Test Keyboard
+-->
+
+<!DOCTYPE keyboard3 SYSTEM "../../../../../resources/standards-data/ldml-keyboards/techpreview/dtd/ldmlKeyboard3.dtd">
+<keyboard3 locale="en" conformsTo="techpreview">
+  <info author="srl295" indicator="🙀" layout="qwerty"  name="Marker Escape Test"/>
+
+  <displays>
+  </displays>
+
+  <keys>
+    <!-- fourty markers.  so that the next one would have its representation as '(' -->
+    <key id="1" output="\m{m01}\m{m02}\m{m03}\m{m04}\m{m05}\m{m06}\m{m07}\m{m08}\m{m09}\m{m10}\m{m11}\m{m12}\m{m13}\m{m14}\m{m15}\m{m16}\m{m17}\m{m18}\m{m19}\m{m20}\m{m21}\m{m22}\m{m23}\m{m24}\m{m25}\m{m26}\m{m27}\m{m28}\m{m29}\m{m30}\m{m31}\m{m32}\m{m33}\m{m34}\m{m35}\m{m36}\m{m37}\m{m38}\m{m39}\m{m40}"/>
+    <!-- this marker should output as U+FFFF U+0008 U+0029  which will break regex -->
+    <key id="z" output="\m{z}" />
+  </keys>
+
+  <layers formId="us">
+    <layer modifiers="none" id="base">
+      <row keys="B 1 2 3" />
+      <row keys="q w e" /> <!-- etc -->
+      <row keys="a s d" /> <!-- etc -->
+      <row keys="z x c" /> <!-- etc -->
+    </layer>
+  </layers>
+
+  <transforms type="simple">
+    <transformGroup>
+      <transform from="\m{z}e" to="E" /> <!-- will end up as '…(e' an unclosed group -->
+    </transformGroup>
+  </transforms>
+</keyboard3>
diff --git a/core/tests/unit/ldml/keyboards/meson.build b/core/tests/unit/ldml/keyboards/meson.build
index c703d542ab..d5bc5fb584 100644
--- a/core/tests/unit/ldml/keyboards/meson.build
+++ b/core/tests/unit/ldml/keyboards/meson.build
@@ -41,6 +41,7 @@ tests_with_testdata = [
   'k_200_reorder_nod_Lana',
   'k_201_reorder_esk',
   'k_210_marker',
+  'k_211_marker_escape',
 ]
 
 tests =  tests_without_testdata