diff --git a/common/predictive-text/unit_tests/in_browser/cases/top-level-lmlayer.js b/common/predictive-text/unit_tests/in_browser/cases/top-level-lmlayer.js index ed875b1d7d..29660bde2d 100644 --- a/common/predictive-text/unit_tests/in_browser/cases/top-level-lmlayer.js +++ b/common/predictive-text/unit_tests/in_browser/cases/top-level-lmlayer.js @@ -9,6 +9,7 @@ describe('LMLayer', function () { }); describe('#initialize()', function () { + // TODO: implement configuration negotiation? it.skip('should yield a reasonable configuration', function () { let maxLeftContext = 64; let lmLayer = new LMLayer(); diff --git a/common/predictive-text/unit_tests/in_browser/cases/worker-dummy-integration.js b/common/predictive-text/unit_tests/in_browser/cases/worker-dummy-integration.js index 064fca78c3..c173a61cba 100644 --- a/common/predictive-text/unit_tests/in_browser/cases/worker-dummy-integration.js +++ b/common/predictive-text/unit_tests/in_browser/cases/worker-dummy-integration.js @@ -16,7 +16,9 @@ describe('LMLayer using dummy model', function () { maxLefContextCodeUnits: 32 + ~~Math.random() * 32 }; - // Tower of promises! + // We're testing many as asynchronous messages in a row. + // this would be cleaner using async/await syntax, but + // alas some of our browsers don't support it. return lmLayer.initialize( capabilities, { @@ -52,103 +54,6 @@ describe('LMLayer using dummy model', function () { } function iGotDistractedByHazel() { - return [ - [ - { - transform: { - insert: 'I ', - deleteLeft: 0 - }, - displayAs: 'I', - }, - { - transform: { - insert: "I'm ", - deleteLeft: 0 - }, - displayAs: "I'm", - }, - { - transform: { - insert: "Oh ", - deleteLeft: 0 - }, - displayAs: "Oh ", - } - ], - // Second set of suggestions, after choosing "I" - [ - { - transform: { - insert: 'love ', - deleteLeft: 0 - }, - displayAs: 'love', - }, - { - transform: { - insert: "am ", - deleteLeft: 0 - }, - displayAs: "am", - }, - { - transform: { - insert: "got ", - deleteLeft: 0 - }, - displayAs: "got", - } - ], - // Third set of suggestions, after choosing "got" - [ - { - transform: { - insert: 'distracted ', - deleteLeft: 0 - }, - displayAs: 'distracted by', - }, - { - transform: { - insert: "distracted ", - deleteLeft: 0 - }, - displayAs: "distracted", - }, - { - transform: { - insert: "a ", - deleteLeft: 0 - }, - displayAs: "a", - } - ], - // Last set of suggestions, after choosing "distracted by" - [ - { - transform: { - insert: 'Hazel ', - deleteLeft: 0 - }, - displayAs: 'Hazel', - }, - { - transform: { - insert: 'the ', - deleteLeft: 0 - }, - displayAs: 'the', - }, - { - transform: { - insert: 'a ', - deleteLeft: 0 - }, - displayAs: 'a', - }, - ], - - ] + return __json__['future_suggestions/i_got_distracted_by_hazel'] } }); diff --git a/common/predictive-text/unit_tests/in_browser/json/future_suggestions/i_got_distracted_by_hazel.json b/common/predictive-text/unit_tests/in_browser/json/future_suggestions/i_got_distracted_by_hazel.json new file mode 100644 index 0000000000..347b98d2e6 --- /dev/null +++ b/common/predictive-text/unit_tests/in_browser/json/future_suggestions/i_got_distracted_by_hazel.json @@ -0,0 +1,94 @@ +[ + [ + { + "transform": { + "insert": "I ", + "deleteLeft": 0 + }, + "displayAs": "I" + }, + { + "transform": { + "insert": "I'm ", + "deleteLeft": 0 + }, + "displayAs": "I'm" + }, + { + "transform": { + "insert": "Oh ", + "deleteLeft": 0 + }, + "displayAs": "Oh " + } + ], + [ + { + "transform": { + "insert": "love ", + "deleteLeft": 0 + }, + "displayAs": "love" + }, + { + "transform": { + "insert": "am ", + "deleteLeft": 0 + }, + "displayAs": "am" + }, + { + "transform": { + "insert": "got ", + "deleteLeft": 0 + }, + "displayAs": "got" + } + ], + [ + { + "transform": { + "insert": "distracted ", + "deleteLeft": 0 + }, + "displayAs": "distracted by" + }, + { + "transform": { + "insert": "distracted ", + "deleteLeft": 0 + }, + "displayAs": "distracted" + }, + { + "transform": { + "insert": "a ", + "deleteLeft": 0 + }, + "displayAs": "a" + } + ], + [ + { + "transform": { + "insert": "Hazel ", + "deleteLeft": 0 + }, + "displayAs": "Hazel" + }, + { + "transform": { + "insert": "the ", + "deleteLeft": 0 + }, + "displayAs": "the" + }, + { + "transform": { + "insert": "a ", + "deleteLeft": 0 + }, + "displayAs": "a" + } + ] +]