From 4ef2f8fe6ccf2d420846a3d424b6c99c89f930ea Mon Sep 17 00:00:00 2001 From: "Joshua A. Horton" Date: Mon, 23 Oct 2023 15:14:32 +0700 Subject: [PATCH] chore(web): adjustments per PR review comments --- web/src/engine/osk/src/banner/banner.ts | 9 ++------- .../osk/src/input/gestures/browser/pendingMultiTap.ts | 2 +- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/web/src/engine/osk/src/banner/banner.ts b/web/src/engine/osk/src/banner/banner.ts index 0aa601c1a3..e90187ce02 100644 --- a/web/src/engine/osk/src/banner/banner.ts +++ b/web/src/engine/osk/src/banner/banner.ts @@ -308,8 +308,6 @@ export class SuggestionBanner extends Banner { private gestureEngine: GestureRecognizer; - // private manager: SuggestionInputManager; - private _predictionContext: PredictionContext; static readonly TOUCHED_CLASS: string = 'kmw-suggest-touched'; @@ -320,10 +318,8 @@ export class SuggestionBanner extends Banner { this.hostDevice = hostDevice; this.getDiv().className = this.getDiv().className + ' ' + SuggestionBanner.BANNER_CLASS; - this.buildInternals(false); - // this.manager = new SuggestionInputManager(this.getDiv()); this.events = new EventEmitter(); //this.manager.events; this.gestureEngine = this.setupInputHandling(); @@ -387,8 +383,7 @@ export class SuggestionBanner extends Banner { let bestMatch: BannerSuggestion = null; let bestDist = Number.MAX_VALUE; - for(let i = 0; i < this.options.length; i++) { - const option = this.options[i]; + for(const option of this.options) { const optionBounding = option.div.getBoundingClientRect(); if(optionBounding.left <= sample.clientX && sample.clientX < optionBounding.right) { @@ -437,7 +432,7 @@ export class SuggestionBanner extends Banner { sourceTracker.suggestion = suggestion; } }; - sourceTracker.suggestion = source.currentSample.item + sourceTracker.suggestion = source.currentSample.item; source.currentSample.item.highlight(true); diff --git a/web/src/engine/osk/src/input/gestures/browser/pendingMultiTap.ts b/web/src/engine/osk/src/input/gestures/browser/pendingMultiTap.ts index 9bafbbb1f7..4f26862e8d 100644 --- a/web/src/engine/osk/src/input/gestures/browser/pendingMultiTap.ts +++ b/web/src/engine/osk/src/input/gestures/browser/pendingMultiTap.ts @@ -9,7 +9,7 @@ export enum PendingMultiTapState { Waiting, Realized, Cancelled }; * (based on key id substring in the case of the shift key), within a * specified timeout period. */ -export default class PendingMultiTap /*implements PendingGesture*/ { +export default class PendingMultiTap { public readonly vkbd: VisualKeyboard; public readonly baseKey: KeyElement; public readonly count: number;